From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1AEE281E84 for ; Thu, 19 Jan 2017 02:28:52 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP; 19 Jan 2017 02:28:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,253,1477983600"; d="scan'208";a="50373322" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 19 Jan 2017 02:28:51 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 02:28:51 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 02:28:51 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Thu, 19 Jan 2017 18:28:50 +0800 From: "Zhu, Yonghong" To: "Huber, Brandon" , "edk2-devel (edk2-devel@lists.01.org)" Thread-Topic: DSC macro expansion Thread-Index: AdJx3wIrGWFOlc3CQMKmYniX23lLXQAX1l9g Date: Thu, 19 Jan 2017 10:28:49 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjQwODk5ZDEtMjcwNC00OWQ5LTllMjEtYWRjM2Q5OWVjZWMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjE3aENUYTJySktZN1M4VTdWR0ppczVodWlOMWZLZWhhRythdVJ6WDR4OVE9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: DSC macro expansion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 10:28:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Brandon, Thanks for the info. I think the spec is out of date, I will propose to upd= ate the spec and file a document change bug on Bugzilla system. Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Hube= r, Brandon Sent: Thursday, January 19, 2017 7:35 AM To: edk2-devel (edk2-devel@lists.01.org) Subject: [edk2] DSC macro expansion Hi All, There seems to be a discrepancy between the DSC spec and the EDKII implemen= tation regarding what macros are allowed in !include statements within a DS= C file. >>From the spec (v1.26 section 2.2.5): Macros, defined in this file, are not permitted in the path or file name of= the !include statement, as these files are included prior to processing th= e file for macros. If the path starts with a "$" character, then one of the= system environment variables, $(WORKSPACE), $(EDK_SOURCE), $(EFI_SOURCE), = or $(ECP_SOURCE) is being used; only these system environment variables are= permitted to start the path of the included file. Yet from experimentation, all macros defined in DSC files seem to be permit= ted in !include statements by the build tools. Is the spec out of date, or = is the code wrong? I think the code in question is _GetMacros() in BaseTools/Source/Python/Wor= kspace/WorkspaceDatabase.py (https://github.com/tianocore/edk2/commit/0d2711a69397d2971079121df4326d= 84736c181e#diff-7cfd5e9099421b207e7718d47950d40dR148). Thanks, -Brandon _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel