Hi Paolo Bonzini, We already had another patch for this issue. Please help to check the attachment. Thanks. Best Regards, Zhu Yonghong -----Original Message----- From: Paolo Bonzini [mailto:pbonzini@redhat.com] Sent: Monday, February 13, 2017 8:54 PM To: edk2-devel@ml01.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] VfrCompile: fix invalid comparison between pointer and integer This would be valid C but is not valid C++, so change the comparison to do what it has always been doing. Signed-off-by: Paolo Bonzini --- BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp index 3ca57ed..2f97975 100644 --- a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp +++ b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp @@ -3372,7 +3372,7 @@ CVfrStringDB::GetVarStoreNameFormStringId ( UINT8 BlockType; EFI_HII_STRING_PACKAGE_HDR *PkgHeader; - if (mStringFileName == '\0' ) { + if (mStringFileName == NULL) { return NULL; } -- 2.9.3