From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 95BE020D77DDA for ; Thu, 6 Apr 2017 18:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491528172; x=1523064172; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5hQ54nJyrxFh5UWvoOPy33Ph67rQmuRlVtspuxxGF5Y=; b=SBWeqdjzEAo51yePCGUOQjYEyRFOh8j2kNVmlGL4gEu6ySqCDTFOkwpg nLrqyuv1SjslZSU5qXh0rJmYEV6Vlw==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 18:22:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,162,1488873600"; d="scan'208";a="1132301998" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 06 Apr 2017 18:22:52 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 18:22:52 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 18:22:51 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Fri, 7 Apr 2017 09:22:49 +0800 From: "Zhu, Yonghong" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Shaw, Kevin W" , "Zhu, Yonghong" Thread-Topic: [edk2-FdfSpecification PATCH] Fix conditional statement examples Thread-Index: AQHSryCzmu/XDm3T/ky9sztl4otiiKG5HKnQ Date: Fri, 7 Apr 2017 01:22:49 +0000 Message-ID: References: <1491515783-6496-1-git-send-email-michael.d.kinney@intel.com> <1491515783-6496-2-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1491515783-6496-2-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWY1MTRjYWMtZWUyNC00NjAxLTg4NzgtODBkMzlkMTc5ZTJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdkTTBMU2VJOVZ6SU9mVkd0eXNNVWk3T2RDMjVsZ2pmYWpSK2JZeE5WV1E9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-FdfSpecification PATCH] Fix conditional statement examples X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 01:22:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Friday, April 7, 2017 5:56 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-FdfSpecification PATCH] Fix conditional statement examples https://bugzilla.tianocore.org/show_bug.cgi?id=3D373 * Removge space between !if and else * Add $() around BARFOO Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_fdf_design_discussion/22_flash_description_file_format.md | 4 ++-- README.md | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/2_fdf_design_discussion/22_flash_description_file_format.md b/= 2_fdf_design_discussion/22_flash_description_file_format.md index 9c993f4..dfbd889 100644 --- a/2_fdf_design_discussion/22_flash_description_file_format.md +++ b/2_fdf_design_discussion/22_flash_description_file_format.md @@ -600,7 +600,7 @@ The following is an example of conditional statements. ```ini !if ("MSFT" in $(FAMILY)) or ("INTEL" in $(FAMILY)) ... statements -!else= if $(FAMILY) =3D=3D "GCC" +!elseif $(FAMILY) =3D=3D "GCC" ... statements !endif =20 @@ -610,7 +610,7 @@ The following is an example of conditional statements. !else # FOO defined, BAR is defined !endif -!elseif BARFOO +!elseif $(BARFOO) # FOO is not defined, BARFOO is defined as TRUE !elseif $(BARFOO) =3D= =3D "FOOBAR" # FOO is not defined, BARFOO is defined as FOOBAR diff --git a/README.md= b/README.md index 9a7f13a..74269dc 100644 --- a/README.md +++ b/README.md @@ -196,3 +196,4 @@ Copyright (c) 2006-2017, Intel Corporation. All rights = reserved. | | Clarified [UserExtensions] content in chapter 2 (to match i= mplementation) = | | | 1.28 | Convert to GitBooks = = | March 2017 | | | [#426](https://bugzilla.tianocore.org/show_bug.cgi?id=3D426= ) IMAGE_TYPE_ID must be provided with value, FDF should mark it as required= section | | +| | [#373](https://bugzilla.tianocore.org/show_bug.cgi?id=3D373= ) Conditional statement examples incorrect = | | -- 2.6.3.windows.1