Re: [edk2-FdfSpecification PATCH] Add missing EBNF definition for <UiFmpName>

["Zhu, Yonghong" <yonghong.zhu@intel.com>]

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Kinney, Michael D 
Sent: Friday, April 7, 2017 7:22 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
Subject: [edk2-FdfSpecification PATCH] Add missing EBNF definition for <UiFmpName>

https://bugzilla.tianocore.org/show_bug.cgi?id=249

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 3_edk_ii_fdf_file_format/37_[capsule]_sections.md    | 1 +
 3_edk_ii_fdf_file_format/38_[fmppayload]_sections.md | 3 ++-
 README.md                                            | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/3_edk_ii_fdf_file_format/37_[capsule]_sections.md b/3_edk_ii_fdf_file_format/37_[capsule]_sections.md
index c912b40..c2aedba 100644
--- a/3_edk_ii_fdf_file_format/37_[capsule]_sections.md
+++ b/3_edk_ii_fdf_file_format/37_[capsule]_sections.md
@@ -304,6 +304,7 @@ Conditional statements may be used anywhere within this section.
 <SmmDepexExp>       ::= "SECTION" <MTS> [<FfsAlignment>] "SMM_DEPEX_EXP"
                         <Eq> "{" [<EOL>] <DxeDepex> "}" <EOL>
 <FmpPayload>        ::= <TS> "FMP_PAYLOAD" <Eq> <UiFmpName> <EOL>
+<UiFmpName>         ::= <Word>
 <FmpFileStatement>  ::= <TS> "FILE" <Space> "DATA" <Eq> <Filename> <EOL>  ```
 
diff --git a/3_edk_ii_fdf_file_format/38_[fmppayload]_sections.md b/3_edk_ii_fdf_file_format/38_[fmppayload]_sections.md
index 1c38f59..31e1166 100644
--- a/3_edk_ii_fdf_file_format/38_[fmppayload]_sections.md
+++ b/3_edk_ii_fdf_file_format/38_[fmppayload]_sections.md
@@ -37,9 +37,10 @@ Capsule files.
 #### Prototype
 
 ```c
-<FmpPayload>  ::= "[FmpPayload" <UiFmpName> "]" <EOL>
+<FmpPayload>  ::= "[FmpPayload" "." <UiFmpName> "]" <EOL>
                   <FmpTokens>
                   <FmpFileData>
+<UiFmpName>   ::= <Word>
 <FmpTokens>   ::= [<TS> "IMAGE_HEADER_INIT_VERSION" <Eq> <Hex2> <EOL>]
                   <TS> "IMAGE_TYPE_ID" <Eq> <RegistryFormatGUID> <EOL>
                   [<TS> "IMAGE_INDEX" <Eq> <Hex2> <EOL>] diff --git a/README.md b/README.md index 9a7f13a..1c9b315 100644
--- a/README.md
+++ b/README.md
@@ -196,3 +196,4 @@ Copyright (c) 2006-2017, Intel Corporation. All rights reserved.
 |            | Clarified [UserExtensions] content in chapter 2 (to match implementation)                                                                                                  |               |
 | 1.28       | Convert to GitBooks                                                                                                                                                        | March 2017    |
 |            | [#426](https://bugzilla.tianocore.org/show_bug.cgi?id=426) IMAGE_TYPE_ID must be provided with value, FDF should mark it as required section                               |               |
+|            | [#249](https://bugzilla.tianocore.org/show_bug.cgi?id=249) FDF spec miss '<UiFmpName>' definition                                                                          |               |
--
2.6.3.windows.1