public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-BuildSpecification PATCH] Use macros in !include file paths
@ 2017-04-12 21:38 Michael Kinney
  2017-04-12 21:38 ` Michael Kinney
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kinney @ 2017-04-12 21:38 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Yonghong Zhu, Kevin W Shaw

https://bugzilla.tianocore.org/show_bug.cgi?id=472

GitHub branch for review:

  https://github.com/mdkinney/edk2-BuildSpecification/tree/Bugzilla_472_MacrosInIncludes
  
GitHub branch compare against latest DRAFT for review:

  https://github.com/tianocore-docs/edk2-BuildSpecification/compare/master...mdkinney:Bugzilla_472_MacrosInIncludes?w=1

The EBNF already allows !include statements to use
$(MACRO) values in the file path.  This change updates
the description and examples for !include statements
to allow the use of macros and specific environment
variables in !include file paths.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>

Michael Kinney (1):
  Use macros in !include file paths

 8_pre-build_autogen_stage/82_auto-generation_process.md | 4 ++--
 README.md                                               | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.6.3.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [edk2-BuildSpecification PATCH] Use macros in !include file paths
  2017-04-12 21:38 [edk2-BuildSpecification PATCH] Use macros in !include file paths Michael Kinney
@ 2017-04-12 21:38 ` Michael Kinney
  2017-04-13  2:25   ` Zhu, Yonghong
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kinney @ 2017-04-12 21:38 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Yonghong Zhu, Kevin W Shaw

https://bugzilla.tianocore.org/show_bug.cgi?id=472

The EBNF already allows !include statements to use
$(MACRO) values in the file path.  This change updates
the description and examples for !include statements
to allow the use of macros and specific environment
variables in !include file paths.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 8_pre-build_autogen_stage/82_auto-generation_process.md | 4 ++--
 README.md                                               | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/8_pre-build_autogen_stage/82_auto-generation_process.md b/8_pre-build_autogen_stage/82_auto-generation_process.md
index 84f6b6b..deb1c47 100644
--- a/8_pre-build_autogen_stage/82_auto-generation_process.md
+++ b/8_pre-build_autogen_stage/82_auto-generation_process.md
@@ -410,8 +410,8 @@ in the DSC file can be used for file names, paths, PCD values, in the
 conditional directives. Macros can also be defined or used in the `[Defines]`,
 `[LibraryClasses]`, `[Libraries]`, `[Components]` and all PCD sections.
 
-Macros defined by the user cannot be used in the !include statements in either
-the DSC or FDF file.
+Macros defined by the user may be used in the !include statements in DSC and
+FDF files.
 
 `EDK_GLOBAL` type macros defined in the DSC file can be used in later sections
 of the DSC, FDF and any of the included EDK INF files.
diff --git a/README.md b/README.md
index 3bd1d32..ce76bb4 100644
--- a/README.md
+++ b/README.md
@@ -200,4 +200,5 @@ Copyright (c) 2008-2017, Intel Corporation. All rights reserved.
 |            | Remove Unicode file storage requirement; refer to the Multi-String UNI File Format Specification instead.                                                                                                                                                                                                                                                           |               |
 |            | Clarify BUILDRULEORDER                                                                                                                                                                                                                                                                                                                                              |               |
 |            | Add support for INF statement in an FD region.                                                                                                                                                                                                                                                                                                                      |               |
-| 1.27       | Convert to Gitbook                                                                                                                                                                                                                                                                                                                                                  | March 2017    |
+| 1.27       | Convert to Gitbook                                                                                                                                                                                                                                                                                                                                                  | April 2017    |
+|            | [#472](https://bugzilla.tianocore.org/show_bug.cgi?id=472) [Build Spec] Extend macro usage in the !include statements for DSC/FDF files                                                                                                                                                                                                                             |               |
-- 
2.6.3.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-BuildSpecification PATCH] Use macros in !include file paths
  2017-04-12 21:38 ` Michael Kinney
@ 2017-04-13  2:25   ` Zhu, Yonghong
  0 siblings, 0 replies; 3+ messages in thread
From: Zhu, Yonghong @ 2017-04-13  2:25 UTC (permalink / raw)
  To: Kinney, Michael D, edk2-devel@lists.01.org
  Cc: Gao, Liming, Shaw, Kevin W, Zhu, Yonghong

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Kinney, Michael D 
Sent: Thursday, April 13, 2017 5:39 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
Subject: [edk2-BuildSpecification PATCH] Use macros in !include file paths

https://bugzilla.tianocore.org/show_bug.cgi?id=472

The EBNF already allows !include statements to use
$(MACRO) values in the file path.  This change updates the description and examples for !include statements to allow the use of macros and specific environment variables in !include file paths.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 8_pre-build_autogen_stage/82_auto-generation_process.md | 4 ++--
 README.md                                               | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/8_pre-build_autogen_stage/82_auto-generation_process.md b/8_pre-build_autogen_stage/82_auto-generation_process.md
index 84f6b6b..deb1c47 100644
--- a/8_pre-build_autogen_stage/82_auto-generation_process.md
+++ b/8_pre-build_autogen_stage/82_auto-generation_process.md
@@ -410,8 +410,8 @@ in the DSC file can be used for file names, paths, PCD values, in the  conditional directives. Macros can also be defined or used in the `[Defines]`,  `[LibraryClasses]`, `[Libraries]`, `[Components]` and all PCD sections.
 
-Macros defined by the user cannot be used in the !include statements in either -the DSC or FDF file.
+Macros defined by the user may be used in the !include statements in 
+DSC and FDF files.
 
 `EDK_GLOBAL` type macros defined in the DSC file can be used in later sections  of the DSC, FDF and any of the included EDK INF files.
diff --git a/README.md b/README.md
index 3bd1d32..ce76bb4 100644
--- a/README.md
+++ b/README.md
@@ -200,4 +200,5 @@ Copyright (c) 2008-2017, Intel Corporation. All rights reserved.
 |            | Remove Unicode file storage requirement; refer to the Multi-String UNI File Format Specification instead.                                                                                                                                                                                                                                                           |               |
 |            | Clarify BUILDRULEORDER                                                                                                                                                                                                                                                                                                                                              |               |
 |            | Add support for INF statement in an FD region.                                                                                                                                                                                                                                                                                                                      |               |
-| 1.27       | Convert to Gitbook                                                                                                                                                                                                                                                                                                                                                  | March 2017    |
+| 1.27       | Convert to Gitbook                                                                                                                                                                                                                                                                                                                                                  | April 2017    |
+|            | [#472](https://bugzilla.tianocore.org/show_bug.cgi?id=472) [Build Spec] Extend macro usage in the !include statements for DSC/FDF files                                                                                                                                                                                                                             |               |
--
2.6.3.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-13  2:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-12 21:38 [edk2-BuildSpecification PATCH] Use macros in !include file paths Michael Kinney
2017-04-12 21:38 ` Michael Kinney
2017-04-13  2:25   ` Zhu, Yonghong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox