From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2AF5521A18AA9 for ; Mon, 17 Apr 2017 22:24:57 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 17 Apr 2017 22:24:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,218,1488873600"; d="scan'208";a="1157356231" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 17 Apr 2017 22:24:56 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Apr 2017 22:24:56 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Apr 2017 22:24:56 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Tue, 18 Apr 2017 13:24:53 +0800 From: "Zhu, Yonghong" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Shaw, Kevin W" , "Zhu, Yonghong" Thread-Topic: [edk2-BuildSpecification PATCH] Clarify alignment requirements for VPD VOID* PCDs Thread-Index: AQHSt/4dGXheArMHgk20w2cunJI3CaHKBeUAgACRtGA= Date: Tue, 18 Apr 2017 05:24:53 +0000 Message-ID: References: <1492490468-23216-1-git-send-email-michael.d.kinney@intel.com> <1492490468-23216-2-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1492490468-23216-2-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-BuildSpecification PATCH] Clarify alignment requirements for VPD VOID* PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 05:24:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Tuesday, April 18, 2017 12:41 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-BuildSpecification PATCH] Clarify alignment requirements for= VPD VOID* PCDs https://bugzilla.tianocore.org/show_bug.cgi?id=3D490 Clarify when error or warning messages are generated for VOID* PCDs when VP= D offset is not aligned. Unicode string VPD PCDs must be 2-byte aligned. Byte array {} VPD PCDs should be 8-byte aligned, but is only a warning mess= age if they are not 8-byte aligned. All other data types only require byte-= alignment. Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 7_build_environment/73_guided_tools.md | 16 ++++++++++++++-- README.md | 1 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/7_build_environment/73_guided_tools.md b/7_build_environment/7= 3_guided_tools.md index 878ae33..a8881d3 100644 --- a/7_build_environment/73_guided_tools.md +++ b/7_build_environment/73_guided_tools.md @@ -123,8 +123,20 @@ file required by the build system is provided in the a= ppendix, VPD Tool. =20 * ASCII strings, "string", will be byte aligned. * Unicode strings, L"string" will be two-byte aligned. - * Byte arrays, {0x00, 0x01} will be 8-byte aligned. If the developer ass= igns - offset values in the DSC file, the developer must follow the same rule= s. + * Byte arrays, {0x00, 0x01} will be 8-byte aligned. + + If the developer manually assigns offset values in the DSC file, the=20 + developer must follow the same rules. + + ********** + **Note:** If a developer manually sets the offset of a `VOID*` PCD=20 + with Unicode string, L"string", style to a value that is not 2-byte=20 + aligned, then an error is generated and the build halts. + ********** + **Note:** If a developer manually sets the offset of a `VOID*` PCD=20 + with byte array {} style to a value that is not 8-byte aligned, then=20 + a warning is generated, but the build will continue. + ********** =20 2. Modify the FDF file: =20 diff --git a/README.md b/README.md index 71c4511..8542434 100644 --- a/README.md +++ b/README.md @@ -203,3 +203,4 @@ Copyright (c) 2008-2017, Intel Corporation. All rights = reserved. | 1.27 | Convert to Gitbook = = = = | A= pril 2017 | | | [#471](https://bugzilla.tianocore.org/show_bug.cgi?id=3D471= ) Build spec: only copy the "TianoCore" Userextension section into "As Buil= t" INF = = |= | | | [#472](https://bugzilla.tianocore.org/show_bug.cgi?id=3D472= ) [Build Spec] Extend macro usage in the !include statements for DSC/FDF fi= les = = |= | +| | [#490](https://bugzilla.tianocore.org/show_bug.cgi?id=3D490= ) Build Spec: specify the alignment requirements for VOID* PCDs stored in a= PCD section = = |= | -- 2.6.3.windows.1