From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C61BF21A13491 for ; Tue, 30 May 2017 18:44:44 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2017 18:45:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,420,1491289200"; d="scan'208";a="974899226" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 30 May 2017 18:45:43 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 30 May 2017 18:45:42 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 30 May 2017 18:45:42 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Wed, 31 May 2017 09:45:40 +0800 From: "Zhu, Yonghong" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Shaw, Kevin W" , "Zhu, Yonghong" Thread-Topic: [edk2-DscSpecification PATCH] Allow mixed PCD access methods Thread-Index: AQHS1yQ/VvxjB1euZUS8QOCjL4EwrKIIFAoAgAWc2EA= Date: Wed, 31 May 2017 01:45:40 +0000 Message-ID: References: <1495915370-38844-1-git-send-email-michael.d.kinney@intel.com> <1495915370-38844-2-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1495915370-38844-2-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-DscSpecification PATCH] Allow mixed PCD access methods X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 01:44:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Sunday, May 28, 2017 4:03 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-DscSpecification PATCH] Allow mixed PCD access methods https://bugzilla.tianocore.org/show_bug.cgi?id=3D521 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_dsc_overview/28_pcd_section_processing.md | 12 ++++++++++-- 3_edk_ii_d= sc_file_format/310_pcd_sections.md | 15 +++++++++++---- README.md | 5 +++-- 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/2_dsc_overview/28_pcd_section_processing.md b/2_dsc_overview/2= 8_pcd_section_processing.md index 60e7de7..0969b41 100644 --- a/2_dsc_overview/28_pcd_section_processing.md +++ b/2_dsc_overview/28_pcd_section_processing.md @@ -103,10 +103,18 @@ of three categories: **Note:** For the dynamic types of PCDs, using an `$(Arch)` extension othe= r than `common` in the section header is not valid. ********** -**Warning:** A PCD can only use one type for all modules. It is not permis= sible -to list a PCD in a PcdsFixedAtBuild section and also list it in a +**Warning:** A PCD can only use one type for all source modules. It is=20 +not permissible to list a PCD in a PcdsFixedAtBuild section and also=20 +list it in a PcdsPatchableInModule section. ********** +**Note:** Binary modules included in a platform build are permitted to=20 +use the PatchableInModule or DynamicEx access methods (the Binary=20 +module must specify which of these two methods were used to create the=20 +binary module) regardless of the method used for a given PCD in modules=20 +built from source. The build supports binary modules that use the same=20 +or different PCD access method than the source modules or other binary=20 +modules. The build parser must break with an error if a PCD is listed as F= ixedAtBuild or Dynamic (not DynamicEx) in the Binary INF. +********** =20 Datum Types for PCD values are either Boolean (`BOOLEAN` - 1 byte), numeri= c (`UINT8` - 1 byte, `UINT16` - 2 bytes, `UINT32` - 4 bytes or `UINT64` - = 8 diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_= file_format/310_pcd_sections.md index bf20cc5..c061e5b 100644 --- a/3_edk_ii_dsc_file_format/310_pcd_sections.md +++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md @@ -75,10 +75,17 @@ value specified in the INF file or the default value li= sted in the DEC file (for modules that do not list a preferred value). Thi= s same rule applies to `FeatureFlag` PCDs. =20 -If the INF values differ (or are not listed) and the access methods are -d= ifferent, then the build must break. A PCD can only use a single method of = -access for the platform and all modules in the platform that use the PCD m= ust -use the same access method. +If the Source INF values differ (or are not listed) and the access=20 +methods are different, then the build must break. All source modules in=20 +a platform must use the same PCD same access method. + +Binary modules included in a platform build are permitted to use the=20 +PatchableInModule or DynamicEx access methods (the Binary module must=20 +specify which of these two methods were used to create the binary=20 +module) regardless of the method used for a given PCD in modules built=20 +from source. The build supports binary modules that use the same or=20 +different PCD access method than the source modules or other binary=20 +modules. The build parser must break with an error if a PCD is listed as F= ixedAtBuild or Dynamic (not DynamicEx) in the Binary INF. =20 If no value is entered in the DSC file, and no INF files provide a preferr= ed value, then the DEC file's default value must be used. diff --git a/README.md b/README.md index 1d1f99c..eb6966f 100644 --- a/README.md +++ b/README.md @@ -176,7 +176,8 @@ Copyright (c) 2006-2017, Intel Corporation. All rights = reserved. | | Update the DSC_SPECIFICATION version to 0x0001001A = = = = | | | | Revised WORKSPACE wording for updated build system that can= handle packages located outside of the WORKSPACE directory tree (refer to = the TianoCore.org/ EDKII website for additional instructions on setting up = a development environment). = | | | | Added new system environment variables used by the build sy= stem. = = = | | -| 1.27 | Convert to GitBooks = = = = | April 2017 | +| 1.27 | Convert to GitBooks = = = = | May 2017 | | | [#351](https://bugzilla.tianocore.org/show_bug.cgi?id=3D351= ) [DSC Spec] Extend macro usage in the !include statement = = = | | | | [#484](https://bugzilla.tianocore.org/show_bug.cgi?id=3D484= ) DSC spec: support Prebuild and Postbuild in the [Defines] section = = = | | -| | [#353](https://bugzilla.tianocore.org/show_bug.cgi?id=3D353= ) Build spec: Allow nested includes in DSC and FDF files = = = | | +| | [#353](https://bugzilla.tianocore.org/show_bug.cgi?id=3D353= ) Build spec: Allow nested includes in DSC and FDF files = = = | | +| | [#521](https://bugzilla.tianocore.org/show_bug.cgi?id=3D521= ) DSC spec: add clarification for mixed PCD usage in the DSC spec = = = | | -- 2.6.3.windows.1