public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py
Date: Fri, 11 Aug 2017 05:40:58 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51EC70E9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170803173023.2452-4-michael.d.kinney@intel.com>

Hi Mike,

The patch 3 has some "Tab character used". Please fix it when you commit.
Others are good to me.

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Kinney, Michael D 
Sent: Friday, August 04, 2017 1:30 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py

Add sample makefile that can be used to test RunMakefile.py script and can also be used as a template to start a new PREBUILD/POSTBUILD makefile.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 BaseTools/Scripts/RunMakefileSample.mak | 43 +++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 BaseTools/Scripts/RunMakefileSample.mak

diff --git a/BaseTools/Scripts/RunMakefileSample.mak b/BaseTools/Scripts/RunMakefileSample.mak
new file mode 100644
index 0000000000..b0947b7644
--- /dev/null
+++ b/BaseTools/Scripts/RunMakefileSample.mak
@@ -0,0 +1,43 @@
+## @file
+# Sample makefile for PREBUILD or POSTBUILD action.
+#
+# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> # 
+This program and the accompanying materials # are licensed and made 
+available under the terms and conditions of the BSD License
+# which accompanies this distribution.	The full text of the license may be found at
+# http://opensource.org/licenses/bsd-license.php
+#
+# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, 
+# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+
+all: show
+	@echo $@
+genc: show
+	@echo $@
+genmake: show
+	@echo $@
+modules: show
+	@echo $@
+libraries: show
+	@echo $@
+fds: show
+	@echo $@
+clean: show
+	@echo $@
+cleanall: show
+	@echo $@
+cleanlib: show
+	@echo $@
+run: show
+	@echo $@
+
+show:
+	@echo WORKSPACE........ $(WORKSPACE)
+	@echo PACKAGES_PATH.... $(PACKAGES_PATH)
+	@echo ACTIVE_PLATFORM.. $(ACTIVE_PLATFORM)
+	@echo TARGET_ARCH...... $(TARGET_ARCH)
+	@echo TOOL_CHAIN_TAG... $(TOOL_CHAIN_TAG)
+	@echo CONF_DIRECTORY... $(CONF_DIRECTORY)
+	@echo TARGET........... $(TARGET)
+	@echo EXTRA_FLAGS...... $(EXTRA_FLAGS)
--
2.13.1.windows.2



  reply	other threads:[~2017-08-11  5:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 17:30 [RFC Patch 0/3] Expand PREBUILD/POSTBUILD actions Michael D Kinney
2017-08-03 17:30 ` [RFC Patch 1/3] BaseTools/build: Expand PREBUILD/POSTBUILD DSC actions Michael D Kinney
2017-08-03 17:30 ` [RFC Patch 2/3] BaseTools/Scripts: Add python script to run a makefile Michael D Kinney
2017-08-03 17:30 ` [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py Michael D Kinney
2017-08-11  5:40   ` Zhu, Yonghong [this message]
2017-08-11 16:33     ` Kinney, Michael D
2017-08-12  4:19       ` Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51EC70E9@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox