From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C1F9C2095DE48 for ; Fri, 11 Aug 2017 21:17:18 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2017 21:19:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,361,1498546800"; d="scan'208";a="139408922" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2017 21:19:39 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 11 Aug 2017 21:19:39 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 11 Aug 2017 21:19:38 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.236]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.128]) with mapi id 14.03.0319.002; Sat, 12 Aug 2017 12:19:37 +0800 From: "Zhu, Yonghong" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py Thread-Index: AQHTDH49hlbk/Blt30GfDveDJgdKTqJ+rzqQgAAwzYCAAUtcgA== Date: Sat, 12 Aug 2017 04:19:36 +0000 Message-ID: References: <20170803173023.2452-1-michael.d.kinney@intel.com> <20170803173023.2452-4-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2017 04:17:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Got you. Thanks. Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Saturday, August 12, 2017 12:33 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney= , Michael D Cc: Gao, Liming Subject: RE: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use= with RunMakefile.py Hi Yonghong, The tab characters in the makefile are required. The makefile does not run= in all environments if they are replaced with spaces. The makefiles generated by build also use tabs. Mike > -----Original Message----- > From: Zhu, Yonghong > Sent: Thursday, August 10, 2017 10:41 PM > To: Kinney, Michael D ; edk2-=20 > devel@lists.01.org > Cc: Gao, Liming ; Zhu, Yonghong=20 > > Subject: RE: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile=20 > for use with RunMakefile.py >=20 > Hi Mike, >=20 > The patch 3 has some "Tab character used". Please fix it when you=20 > commit. > Others are good to me. >=20 > Reviewed-by: Yonghong Zhu >=20 > Best Regards, > Zhu Yonghong >=20 >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, August 04, 2017 1:30 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Zhu, Yonghong=20 > ; Kinney, Michael D=20 > > Subject: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for=20 > use with RunMakefile.py >=20 > Add sample makefile that can be used to test RunMakefile.py script and=20 > can also be used as a template to start a new PREBUILD/POSTBUILD=20 > makefile. >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney > --- > BaseTools/Scripts/RunMakefileSample.mak | 43 > +++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 BaseTools/Scripts/RunMakefileSample.mak >=20 > diff --git a/BaseTools/Scripts/RunMakefileSample.mak > b/BaseTools/Scripts/RunMakefileSample.mak > new file mode 100644 > index 0000000000..b0947b7644 > --- /dev/null > +++ b/BaseTools/Scripts/RunMakefileSample.mak > @@ -0,0 +1,43 @@ > +## @file > +# Sample makefile for PREBUILD or POSTBUILD action. > +# > +# Copyright (c) 2017, Intel Corporation. All rights > reserved.
# > +This program and the accompanying materials # are licensed and > made > +available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the > license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS > IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > +# > + > +all: show > + @echo $@ > +genc: show > + @echo $@ > +genmake: show > + @echo $@ > +modules: show > + @echo $@ > +libraries: show > + @echo $@ > +fds: show > + @echo $@ > +clean: show > + @echo $@ > +cleanall: show > + @echo $@ > +cleanlib: show > + @echo $@ > +run: show > + @echo $@ > + > +show: > + @echo WORKSPACE........ $(WORKSPACE) > + @echo PACKAGES_PATH.... $(PACKAGES_PATH) > + @echo ACTIVE_PLATFORM.. $(ACTIVE_PLATFORM) > + @echo TARGET_ARCH...... $(TARGET_ARCH) > + @echo TOOL_CHAIN_TAG... $(TOOL_CHAIN_TAG) > + @echo CONF_DIRECTORY... $(CONF_DIRECTORY) > + @echo TARGET........... $(TARGET) > + @echo EXTRA_FLAGS...... $(EXTRA_FLAGS) > -- > 2.13.1.windows.2