From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B0E221DFC897 for ; Thu, 24 Aug 2017 20:03:37 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2017 20:06:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,423,1498546800"; d="scan'208";a="122424822" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 24 Aug 2017 20:06:12 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 24 Aug 2017 20:06:11 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 24 Aug 2017 20:06:11 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.183]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.219]) with mapi id 14.03.0319.002; Fri, 25 Aug 2017 11:05:45 +0800 From: "Zhu, Yonghong" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] BaseTools: Support /WHOLEARCHIVE option in VS2015 tool chain Thread-Index: AQHTHJLKGRdPm9x4/069rfNziJb3A6KUZNng Date: Fri, 25 Aug 2017 03:05:44 +0000 Message-ID: References: <1503549481-8016-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1503549481-8016-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTVmMjJjOGUtMzM3Mi00OWJiLTg4MDUtNzcwNDcwZTdhZmQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imprc0Z6T2dBbk5udDR4OXBUZ1FuMUx6TlwvM3pHaXZjTElkMjVaT3BmdkVVPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Support /WHOLEARCHIVE option in VS2015 tool chain X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 03:03:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Gao, Liming=20 Sent: Thursday, August 24, 2017 12:38 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools: Support /WHOLEARCHIVE option in VS2015 tool cha= in https://bugzilla.tianocore.org/show_bug.cgi?id=3D582 Don't enable this option in the default setting, because it may cause VS201= 5 linker crash. Platform can enable this option in PlatformPkg.dsc like bel= ow: [BuildOptions] *_*_*_DLINK2_FLAGS =3D /WHOLEARCHIVE Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/Conf/build_rule.template | 1 + BaseTools/Conf/tools_def.templat= e | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index 1db94b6..d8c8253 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -289,6 +289,7 @@ $(DEBUG_DIR)(+)$(MODULE_NAME).dll =20 + "$(DLINK)" /OUT:${dst} $(DLINK_FLAGS) $(DLINK2_FLAGS)=20 + $(DLINK_SPATH) @$(STATIC_LIBRARY_FILES_LIST) "$(DLINK)" /OUT:${dst} $(DLINK_FLAGS) $(DLINK_SPATH) @$(STATIC_LIB= RARY_FILES_LIST) =20 diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index 1fa3ca3..e0ef4b1 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -575,7 +575,7 @@ DEFINE SOURCERY_CYGWIN_TOOLS =3D /cygdrive/c/Program Fi= les/CodeSourcery/Sourcery G # Intel(r) ACPI Compiler (iasl.exe) from # https://acpica.org/downloads # VS2015x86 -win64- Requires: -# Microsoft Visual Studio 2015 (x86) Professio= nal Edition +# Microsoft Visual Studio 2015 (x86) Update 2 = or above # Microsoft Windows Server 2003 Driver Develop= ment Kit (Microsoft WINDDK) version 3790.1830 # Optional: # Required to build platforms or ACPI tables: @@ -3605,6 +3605,7 @@ NOOPT_VS2013x86xASL_X64_DLINK_FLAGS =3D /NOLOGO /N= ODEFAULTLIB /IGNORE:4001 /OPT *_VS2015_*_APP_FLAGS =3D /nologo /E /TC *_VS2015_*_PP_FLAGS =3D /nologo /E /TC /FIAutoGen.h *_VS2015_*_VFRPP_FLAGS =3D /nologo /E /TC /DVFRCOMPILE /FI$(MOD= ULE_NAME)StrDefs.h +*_VS2015_*_DLINK2_FLAGS =3D =20 *_VS2015_*_ASM16_PATH =3D DEF(VS2015_BIN)\ml.exe =20 @@ -3723,6 +3724,7 @@ NOOPT_VS2015_X64_DLINK_FLAGS =3D /NOLOGO /NODEFAULTL= IB /IGNORE:4001 /OPT:REF /OPT *_VS2015xASL_*_APP_FLAGS =3D /nologo /E /TC *_VS2015xASL_*_PP_FLAGS =3D /nologo /E /TC /FIAutoGen.h *_VS2015xASL_*_VFRPP_FLAGS =3D /nologo /E /TC /DVFRCOMPILE /FI$(MODULE= _NAME)StrDefs.h +*_VS2015xASL_*_DLINK2_FLAGS =3D =20 *_VS2015xASL_*_ASM16_PATH =3D DEF(VS2015_BIN)\ml.exe =20 @@ -3839,6 +3841,7 @@ NOOPT_VS2015xASL_X64_DLINK_FLAGS =3D /NOLOGO /NODE= FAULTLIB /IGNORE:4001 /OPT:RE *_VS2015x86_*_APP_FLAGS =3D /nologo /E /TC *_VS2015x86_*_PP_FLAGS =3D /nologo /E /TC /FIAutoGen.h *_VS2015x86_*_VFRPP_FLAGS =3D /nologo /E /TC /DVFRCOMPILE /FI$(MODULE_= NAME)StrDefs.h +*_VS2015x86_*_DLINK2_FLAGS =3D =20 *_VS2015x86_*_ASM16_PATH =3D DEF(VS2015x86_BIN)\ml.exe =20 @@ -3954,6 +3957,7 @@ NOOPT_VS2015x86_X64_DLINK_FLAGS =3D /NOLOGO /NODEF= AULTLIB /IGNORE:4001 /OPT:REF *_VS2015x86xASL_*_APP_FLAGS =3D /nologo /E /TC *_VS2015x86xASL_*_PP_FLAGS =3D /nologo /E /TC /FIAutoGen.h *_VS2015x86xASL_*_VFRPP_FLAGS =3D /nologo /E /TC /DVFRCOMPILE /FI$(MOD= ULE_NAME)StrDefs.h +*_VS2015x86xASL_*_DLINK2_FLAGS =3D =20 *_VS2015x86xASL_*_ASM16_PATH =3D DEF(VS2015x86_BIN)\ml.exe =20 -- 2.8.0.windows.1