From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [Patch] BaseTools: Fix the bug to collect source files per build rule family
Date: Thu, 16 Nov 2017 00:02:33 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51F35195@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1101ea54-bd52-6add-7065-f126d1737d96@redhat.com>
The bug is https://bugzilla.tianocore.org/show_bug.cgi?id=780 .
I will update the message to more clear, thanks.
Best Regards,
Zhu Yonghong
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com]
Sent: Thursday, November 16, 2017 12:23 AM
To: Zhu, Yonghong <yonghong.zhu@intel.com>; edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [Patch] BaseTools: Fix the bug to collect source files per build rule family
Hello Yonghong,
On 11/14/17 06:52, Yonghong Zhu wrote:
> when collect source files list we should also consider build rule
> family.
what bug does this patch fix? I guess the bug is that something is missed / not done, because changes to the build rules are not noticed?
Can you please elaborate in the commit message?
Thanks!
Laszlo
>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
> b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index b3e7089..008ad8e 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -3265,17 +3265,17 @@ class ModuleAutoGen(AutoGen):
> # match tool chain
> if F.TagName not in ("", "*", self.ToolChain):
> EdkLogger.debug(EdkLogger.DEBUG_9, "The toolchain [%s] for processing file [%s] is found, "
> "but [%s] is needed" % (F.TagName, str(F), self.ToolChain))
> continue
> - # match tool chain family
> - if F.ToolChainFamily not in ("", "*", self.ToolChainFamily):
> + # match tool chain family or build rule family
> + if F.ToolChainFamily not in ("", "*", self.ToolChainFamily, self.BuildRuleFamily):
> EdkLogger.debug(
> EdkLogger.DEBUG_0,
> "The file [%s] must be built by tools of [%s], " \
> - "but current toolchain family is [%s]" \
> - % (str(F), F.ToolChainFamily, self.ToolChainFamily))
> + "but current toolchain family is [%s], buildrule family is [%s]" \
> + % (str(F), F.ToolChainFamily,
> + self.ToolChainFamily, self.BuildRuleFamily))
> continue
>
> # add the file path into search path list for file including
> if F.Dir not in self.IncludePathList and self.AutoGenVersion >= 0x00010005:
> self.IncludePathList.insert(0, F.Dir)
>
prev parent reply other threads:[~2017-11-15 23:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 5:52 [Patch] BaseTools: Fix the bug to collect source files per build rule family Yonghong Zhu
2017-11-14 9:58 ` Gao, Liming
2017-11-15 16:23 ` Laszlo Ersek
2017-11-16 0:02 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51F35195@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox