From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A06EC22364883 for ; Wed, 31 Jan 2018 02:33:40 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 02:39:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,439,1511856000"; d="scan'208";a="30874994" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 31 Jan 2018 02:39:15 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 Jan 2018 02:39:15 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 Jan 2018 02:39:15 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.145]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.192]) with mapi id 14.03.0319.002; Wed, 31 Jan 2018 18:39:12 +0800 From: "Zhu, Yonghong" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon Thread-Index: AQHTmnJtH0NsUe7lhkySgRl3dLt7PqONtHuA Date: Wed, 31 Jan 2018 10:39:12 +0000 Message-ID: References: <1517389417-25112-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1517389417-25112-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2M2MDNiNTItZGUyYi00MDY4LTk4MjQtNmNhZDAyYjQ0NmQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpFRmJxS3llaUtBUWRXdmdUU0NDTTFZbCs1clc4aWU5Rng4SVl6MHdcL2gwPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 10:33:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Limi= ng Gao Sent: Wednesday, January 31, 2018 5:04 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools CommonLib: Remove the unnecessary print m= essage in PcdValueCommon Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/Common/PcdValueCommon.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/= C/Common/PcdValueCommon.c index 92328da..210f87b 100644 --- a/BaseTools/Source/C/Common/PcdValueCommon.c +++ b/BaseTools/Source/C/Common/PcdValueCommon.c @@ -330,9 +330,7 @@ Returns: break; case PcdDataTypePointer: Value =3D &PcdList[Index].Value[1]; - printf ("Value =3D %s\n", PcdList[Index].Value); for (*Size =3D 0, Byte =3D (UINT8) strtoul(Value, &End, 16); Value != =3D End; Byte =3D (UINT8) strtoul(Value, &End, 16), *Size =3D *Size + 1) { - printf("%x\n", Byte); Value =3D End + 1; } Buffer =3D malloc(*Size + 1); @@ -401,7 +399,6 @@ Returns: PcdList[Index].Value =3D malloc(Size * 5 + 3); PcdList[Index].Value[0] =3D '{'; for (ValueIndex =3D 0; ValueIndex < Size; ValueIndex++) { - printf("Value[%d] =3D %02x\n", ValueIndex, Value[ValueIndex]); sprintf(&PcdList[Index].Value[1 + ValueIndex * 5], "0x%02x,", Value[= ValueIndex]); } PcdList[Index].Value[1 + Size * 5 - 1] =3D '}'; @@ -724,15 +721,11 @@ = Returns: if (*InputFileName =3D=3D NULL) { fprintf (stderr, "Missing option. Input files is not specified\n"); exit (EXIT_FAILURE); - } else { - printf ("Input file name is %s\n", *InputFileName); } =20 if (*OutputFileName =3D=3D NULL) { fprintf (stderr, "Missing option. Output file is not specified\n"); exit (EXIT_FAILURE); - } else { - printf ("Output file name is %s\n", *OutputFileName); } } =20 @@ -761,7 +754,6 @@ Returns: UINT8 *FileBuffer; UINT32 FileSize; =20 - printf ("PCD tool start.\n"); InputFileName =3D NULL; OutputFileName =3D NULL; =20 @@ -790,7 +782,5 @@ Returns: // WriteOutputFile (OutputFileName); =20 - printf ("PCD tool done.\n"); - exit (EXIT_SUCCESS); } -- 2.8.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel