[Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile
@ 2018-01-31 11:59 Liming Gao
  2018-01-31 11:59 ` [Patch 1/2] " Liming Gao
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Liming Gao @ 2018-01-31 11:59 UTC (permalink / raw)
  To: edk2-devel


Liming Gao (2):
  BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile
  BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile

 BaseTools/Source/C/BootSectImage/GNUmakefile    |  3 +--
 BaseTools/Source/C/BrotliCompress/GNUmakefile   |  3 +--
 BaseTools/Source/C/Common/GNUmakefile           |  3 +--
 BaseTools/Source/C/EfiLdrImage/GNUmakefile      |  3 +--
 BaseTools/Source/C/EfiRom/GNUmakefile           |  3 +--
 BaseTools/Source/C/GenCrc32/GNUmakefile         |  3 +--
 BaseTools/Source/C/GenFfs/GNUmakefile           |  3 +--
 BaseTools/Source/C/GenFv/GNUmakefile            |  3 +--
 BaseTools/Source/C/GenFw/GNUmakefile            |  3 +--
 BaseTools/Source/C/GenPage/GNUmakefile          |  3 +--
 BaseTools/Source/C/GenSec/GNUmakefile           |  3 +--
 BaseTools/Source/C/GenVtf/GNUmakefile           |  3 +--
 BaseTools/Source/C/GnuGenBootSector/GNUmakefile |  3 +--
 BaseTools/Source/C/LzmaCompress/GNUmakefile     |  3 +--
 BaseTools/Source/C/Makefiles/header.makefile    | 28 +++++++++++++++++++++++--
 BaseTools/Source/C/Split/GNUmakefile            |  3 +--
 BaseTools/Source/C/TianoCompress/GNUmakefile    |  3 +--
 BaseTools/Source/C/VfrCompile/GNUmakefile       |  3 +--
 BaseTools/Source/C/VolInfo/GNUmakefile          |  3 +--
 19 files changed, 44 insertions(+), 38 deletions(-)

-- 
2.8.0.windows.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Patch 1/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile
  2018-01-31 11:59 [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile Liming Gao
@ 2018-01-31 11:59 ` Liming Gao
  2018-01-31 11:59 ` [Patch 2/2] BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile Liming Gao
  2018-02-05  3:23 ` [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile Zhu, Yonghong
  2 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2018-01-31 11:59 UTC (permalink / raw)
  To: edk2-devel

With this change, enter single tool directory, make can pass.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/C/Makefiles/header.makefile | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile
index e034da2..0976973 100644
--- a/BaseTools/Source/C/Makefiles/header.makefile
+++ b/BaseTools/Source/C/Makefiles/header.makefile
@@ -6,7 +6,7 @@
 # HOST_ARCH = ia64 or IA64 for IA64 build
 # HOST_ARCH = Arm or ARM for ARM build
 #
-# Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.    The full text of the license may be found at
@@ -15,7 +15,31 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
-HOST_ARCH ?= IA32
+ifndef HOST_ARCH
+  #
+  # If HOST_ARCH is not defined, then we use 'uname -m' to attempt
+  # try to figure out the appropriate HOST_ARCH.
+  #
+  uname_m = $(shell uname -m)
+  $(info Attempting to detect HOST_ARCH from 'uname -m': $(uname_m))
+  ifneq (,$(strip $(filter $(uname_m), x86_64 amd64)))
+    HOST_ARCH=X64
+  endif
+  ifeq ($(patsubst i%86,IA32,$(uname_m)),IA32)
+    HOST_ARCH=IA32
+  endif
+  ifneq (,$(findstring aarch64,$(uname_m)))
+    HOST_ARCH=AARCH64
+  endif
+  ifneq (,$(findstring arm,$(uname_m)))
+    HOST_ARCH=ARM
+  endif
+  ifndef HOST_ARCH
+    $(info Could not detected HOST_ARCH from uname results)
+    $(error HOST_ARCH is not defined!)
+  endif
+  $(info Detected HOST_ARCH of $(HOST_ARCH) using uname.)
+endif
 
 CYGWIN:=$(findstring CYGWIN, $(shell uname -s))
 LINUX:=$(findstring Linux, $(shell uname -s))
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Patch 2/2] BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile
  2018-01-31 11:59 [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile Liming Gao
  2018-01-31 11:59 ` [Patch 1/2] " Liming Gao
@ 2018-01-31 11:59 ` Liming Gao
  2018-02-05  3:23 ` [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile Zhu, Yonghong
  2 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2018-01-31 11:59 UTC (permalink / raw)
  To: edk2-devel

HOST_ARCH has been moved into the common header.makefile

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/C/BootSectImage/GNUmakefile    | 3 +--
 BaseTools/Source/C/BrotliCompress/GNUmakefile   | 3 +--
 BaseTools/Source/C/Common/GNUmakefile           | 3 +--
 BaseTools/Source/C/EfiLdrImage/GNUmakefile      | 3 +--
 BaseTools/Source/C/EfiRom/GNUmakefile           | 3 +--
 BaseTools/Source/C/GenCrc32/GNUmakefile         | 3 +--
 BaseTools/Source/C/GenFfs/GNUmakefile           | 3 +--
 BaseTools/Source/C/GenFv/GNUmakefile            | 3 +--
 BaseTools/Source/C/GenFw/GNUmakefile            | 3 +--
 BaseTools/Source/C/GenPage/GNUmakefile          | 3 +--
 BaseTools/Source/C/GenSec/GNUmakefile           | 3 +--
 BaseTools/Source/C/GenVtf/GNUmakefile           | 3 +--
 BaseTools/Source/C/GnuGenBootSector/GNUmakefile | 3 +--
 BaseTools/Source/C/LzmaCompress/GNUmakefile     | 3 +--
 BaseTools/Source/C/Split/GNUmakefile            | 3 +--
 BaseTools/Source/C/TianoCompress/GNUmakefile    | 3 +--
 BaseTools/Source/C/VfrCompile/GNUmakefile       | 3 +--
 BaseTools/Source/C/VolInfo/GNUmakefile          | 3 +--
 18 files changed, 18 insertions(+), 36 deletions(-)

diff --git a/BaseTools/Source/C/BootSectImage/GNUmakefile b/BaseTools/Source/C/BootSectImage/GNUmakefile
index 90800a4..f76beac 100644
--- a/BaseTools/Source/C/BootSectImage/GNUmakefile
+++ b/BaseTools/Source/C/BootSectImage/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'BootSectImage' module build.
 #
-# Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = BootSectImage
diff --git a/BaseTools/Source/C/BrotliCompress/GNUmakefile b/BaseTools/Source/C/BrotliCompress/GNUmakefile
index 3426a00..1eaade7 100644
--- a/BaseTools/Source/C/BrotliCompress/GNUmakefile
+++ b/BaseTools/Source/C/BrotliCompress/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'Brotli' module build.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = Brotli
diff --git a/BaseTools/Source/C/Common/GNUmakefile b/BaseTools/Source/C/Common/GNUmakefile
index 66bd3a6..8214f18 100644
--- a/BaseTools/Source/C/Common/GNUmakefile
+++ b/BaseTools/Source/C/Common/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'Common' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 # VPATH = ..
diff --git a/BaseTools/Source/C/EfiLdrImage/GNUmakefile b/BaseTools/Source/C/EfiLdrImage/GNUmakefile
index 75c04ea..f5fe49c 100644
--- a/BaseTools/Source/C/EfiLdrImage/GNUmakefile
+++ b/BaseTools/Source/C/EfiLdrImage/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'EfiLdrImage' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = EfiLdrImage
diff --git a/BaseTools/Source/C/EfiRom/GNUmakefile b/BaseTools/Source/C/EfiRom/GNUmakefile
index a13111c..6a65ce8 100644
--- a/BaseTools/Source/C/EfiRom/GNUmakefile
+++ b/BaseTools/Source/C/EfiRom/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'EfiRom' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = EfiRom
diff --git a/BaseTools/Source/C/GenCrc32/GNUmakefile b/BaseTools/Source/C/GenCrc32/GNUmakefile
index a3b4aa8..89a06ae 100644
--- a/BaseTools/Source/C/GenCrc32/GNUmakefile
+++ b/BaseTools/Source/C/GenCrc32/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GenCrc32' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GenCrc32
diff --git a/BaseTools/Source/C/GenFfs/GNUmakefile b/BaseTools/Source/C/GenFfs/GNUmakefile
index af0a27c..6252b68 100644
--- a/BaseTools/Source/C/GenFfs/GNUmakefile
+++ b/BaseTools/Source/C/GenFfs/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GenFfs' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GenFfs
diff --git a/BaseTools/Source/C/GenFv/GNUmakefile b/BaseTools/Source/C/GenFv/GNUmakefile
index 008ceb7..5f0d3b8 100644
--- a/BaseTools/Source/C/GenFv/GNUmakefile
+++ b/BaseTools/Source/C/GenFv/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GenFv' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GenFv
diff --git a/BaseTools/Source/C/GenFw/GNUmakefile b/BaseTools/Source/C/GenFw/GNUmakefile
index 89b2aa6..15d4d09 100644
--- a/BaseTools/Source/C/GenFw/GNUmakefile
+++ b/BaseTools/Source/C/GenFw/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GenFw' module build.
 #
-# Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GenFw
diff --git a/BaseTools/Source/C/GenPage/GNUmakefile b/BaseTools/Source/C/GenPage/GNUmakefile
index 9b5a4d3..9590042 100644
--- a/BaseTools/Source/C/GenPage/GNUmakefile
+++ b/BaseTools/Source/C/GenPage/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GenPage' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GenPage
diff --git a/BaseTools/Source/C/GenSec/GNUmakefile b/BaseTools/Source/C/GenSec/GNUmakefile
index 6c8fd44..84f255f 100644
--- a/BaseTools/Source/C/GenSec/GNUmakefile
+++ b/BaseTools/Source/C/GenSec/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GenSec' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GenSec
diff --git a/BaseTools/Source/C/GenVtf/GNUmakefile b/BaseTools/Source/C/GenVtf/GNUmakefile
index 4eb4cc7..54160c6 100644
--- a/BaseTools/Source/C/GenVtf/GNUmakefile
+++ b/BaseTools/Source/C/GenVtf/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GenVtf' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GenVtf
diff --git a/BaseTools/Source/C/GnuGenBootSector/GNUmakefile b/BaseTools/Source/C/GnuGenBootSector/GNUmakefile
index 350014a..2c9d887 100644
--- a/BaseTools/Source/C/GnuGenBootSector/GNUmakefile
+++ b/BaseTools/Source/C/GnuGenBootSector/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'GnuGenBootSector' module build.
 #
-# Copyright (c) 2009 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = GnuGenBootSector
diff --git a/BaseTools/Source/C/LzmaCompress/GNUmakefile b/BaseTools/Source/C/LzmaCompress/GNUmakefile
index 390a97f..bafff21 100644
--- a/BaseTools/Source/C/LzmaCompress/GNUmakefile
+++ b/BaseTools/Source/C/LzmaCompress/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'LzmaCompress' module build.
 #
-# Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = LzmaCompress
diff --git a/BaseTools/Source/C/Split/GNUmakefile b/BaseTools/Source/C/Split/GNUmakefile
index a42fe1a..8a764f6 100644
--- a/BaseTools/Source/C/Split/GNUmakefile
+++ b/BaseTools/Source/C/Split/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'Split' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = Split
diff --git a/BaseTools/Source/C/TianoCompress/GNUmakefile b/BaseTools/Source/C/TianoCompress/GNUmakefile
index 403b363..6265a2a 100644
--- a/BaseTools/Source/C/TianoCompress/GNUmakefile
+++ b/BaseTools/Source/C/TianoCompress/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'TianoCompress' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = TianoCompress
diff --git a/BaseTools/Source/C/VfrCompile/GNUmakefile b/BaseTools/Source/C/VfrCompile/GNUmakefile
index b9f8f8c..c4ec61a 100644
--- a/BaseTools/Source/C/VfrCompile/GNUmakefile
+++ b/BaseTools/Source/C/VfrCompile/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'VfrCompile' module build.
 #
-# Copyright (c) 2008 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -11,7 +11,6 @@
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
 
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = VfrCompile
diff --git a/BaseTools/Source/C/VolInfo/GNUmakefile b/BaseTools/Source/C/VolInfo/GNUmakefile
index 86929c5..f6f35f9 100644
--- a/BaseTools/Source/C/VolInfo/GNUmakefile
+++ b/BaseTools/Source/C/VolInfo/GNUmakefile
@@ -1,7 +1,7 @@
 ## @file
 # GNU/Linux makefile for 'VolInfo' module build.
 #
-# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -10,7 +10,6 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
-HOST_ARCH ?= IA32
 MAKEROOT ?= ..
 
 APPNAME = VolInfo
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile
  2018-01-31 11:59 [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile Liming Gao
  2018-01-31 11:59 ` [Patch 1/2] " Liming Gao
  2018-01-31 11:59 ` [Patch 2/2] BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile Liming Gao
@ 2018-02-05  3:23 ` Zhu, Yonghong
  2 siblings, 0 replies; 4+ messages in thread
From: Zhu, Yonghong @ 2018-02-05  3:23 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Wednesday, January 31, 2018 8:00 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile


Liming Gao (2):
  BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile
  BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile

 BaseTools/Source/C/BootSectImage/GNUmakefile    |  3 +--
 BaseTools/Source/C/BrotliCompress/GNUmakefile   |  3 +--
 BaseTools/Source/C/Common/GNUmakefile           |  3 +--
 BaseTools/Source/C/EfiLdrImage/GNUmakefile      |  3 +--
 BaseTools/Source/C/EfiRom/GNUmakefile           |  3 +--
 BaseTools/Source/C/GenCrc32/GNUmakefile         |  3 +--
 BaseTools/Source/C/GenFfs/GNUmakefile           |  3 +--
 BaseTools/Source/C/GenFv/GNUmakefile            |  3 +--
 BaseTools/Source/C/GenFw/GNUmakefile            |  3 +--
 BaseTools/Source/C/GenPage/GNUmakefile          |  3 +--
 BaseTools/Source/C/GenSec/GNUmakefile           |  3 +--
 BaseTools/Source/C/GenVtf/GNUmakefile           |  3 +--
 BaseTools/Source/C/GnuGenBootSector/GNUmakefile |  3 +--
 BaseTools/Source/C/LzmaCompress/GNUmakefile     |  3 +--
 BaseTools/Source/C/Makefiles/header.makefile    | 28 +++++++++++++++++++++++--
 BaseTools/Source/C/Split/GNUmakefile            |  3 +--
 BaseTools/Source/C/TianoCompress/GNUmakefile    |  3 +--
 BaseTools/Source/C/VfrCompile/GNUmakefile       |  3 +--
 BaseTools/Source/C/VolInfo/GNUmakefile          |  3 +--
 19 files changed, 44 insertions(+), 38 deletions(-)

-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-02-05  3:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-31 11:59 [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile Liming Gao
2018-01-31 11:59 ` [Patch 1/2] " Liming Gao
2018-01-31 11:59 ` [Patch 2/2] BaseTools GNUmakefile: Remove HOST_ARCH in every tool Makefile Liming Gao
2018-02-05  3:23 ` [Patch 0/2] BaseTools GNUmakefile: Move HOST_ARCH detection into common makefile Zhu, Yonghong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox