From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yonghong.zhu@intel.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=134.134.136.24; helo=mga09.intel.com;
 envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org 
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 142EF22487290
 for <edk2-devel@lists.01.org>; Tue, 20 Mar 2018 01:21:02 -0700 (PDT)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 20 Mar 2018 01:27:31 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,334,1517904000"; d="scan'208";a="40492991"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga001.jf.intel.com with ESMTP; 20 Mar 2018 01:27:31 -0700
Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Tue, 20 Mar 2018 01:27:30 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Tue, 20 Mar 2018 01:27:30 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002;
 Tue, 20 Mar 2018 16:27:28 +0800
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
CC: "Kinney, Michael D" <michael.d.kinney@intel.com>, "Zhu, Yonghong"
 <yonghong.zhu@intel.com>
Thread-Topic: [Patch 3/3] DscSpecification: Add structure PCD field value
 assignment syntax
Thread-Index: AQHTvOE4FJwamquzmk6b8YAqGxUJi6PY0MoA
Date: Tue, 20 Mar 2018 08:27:28 +0000
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FBA493@SHSMSX103.ccr.corp.intel.com>
References: <1521175314-6672-1-git-send-email-liming.gao@intel.com>
 <1521175314-6672-4-git-send-email-liming.gao@intel.com>
In-Reply-To: <1521175314-6672-4-git-send-email-liming.gao@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [Patch 3/3] DscSpecification: Add structure PCD field value assignment syntax
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 08:21:02 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>=20

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Gao, Liming=20
Sent: Friday, March 16, 2018 12:42 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Zhu, Yonghong <yonghong=
.zhu@intel.com>
Subject: [Patch 3/3] DscSpecification: Add structure PCD field value assign=
ment syntax

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
 2_dsc_overview/28_pcd_section_processing.md           | 10 ++++++----
 3_edk_ii_dsc_file_format/310_pcd_sections.md          | 19 +++++++++++----=
----
 .../33_platform_dsc_definition.md                     |  6 +++++-
 3 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/2_dsc_overview/28_pcd_section_processing.md b/2_dsc_overview/2=
8_pcd_section_processing.md
index 1adde81..4c5d952 100644
--- a/2_dsc_overview/28_pcd_section_processing.md
+++ b/2_dsc_overview/28_pcd_section_processing.md
@@ -1,7 +1,7 @@
 <!--- @file
   2.8 PCD Section Processing
=20
-  Copyright (c) 2006-2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006-2018, Intel Corporation. All rights reserved.<BR>
=20
   Redistribution and use in source (original document form) and 'compiled'
   forms (converted to PDF, epub, HTML and other formats) with or without @=
@ -283,8 +283,9 @@ Unique PCDs are identified using the format to identify =
the named PCD:
 `TokenSpaceGuidCName.PcdCName`
=20
 The content for a PCD in this section is the PCD's Name (PCD Token Space G=
uid -C name, the PCD C name - separated by a period character,) and Default=
 value.
-Field entries on a line are separated by the pipe "|" character.
+C name, the PCD C name and the optional field name - separated by a=20
+period
+character) and Default value. Field entries on a line are separated by=20
+the pipe "|" character.
=20
 This specification prohibits setting different PCD access methods for a si=
ngle  PCD in different modules. The access methods here are `PcdsFixedAtBui=
ld`, @@ -373,7 +374,8 @@ prohibited in this type of platform description fi=
le.
 **Note:** PCD values within a section are positional, (last wins) if a PCD=
 is  listed more than one time within a section. List a PCD in one of the o=
ther  access methods is allowed, provided a single access method must be us=
ed for all -instances of the PCD.
+instances of the PCD. If PCD field value is listed, it will override=20
+PCD value even if PCD value is after PCD field value.
 **********
=20
 #### 2.8.3.9 Library Instances
diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_fi=
le_format/310_pcd_sections.md
index f79a0fd..4eaa15c 100644
--- a/3_edk_ii_dsc_file_format/310_pcd_sections.md
+++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md
@@ -107,6 +107,9 @@ value. If not provided, the maximum length will be calc=
ulated as the largest of  the size of the data in the DSC file, the size of=
 the data in the INF file or  the size of the data in the DEC file that dec=
lares the PCD.
=20
+PCDs with a C strucutre type is also a VOID* PCD. Its value can be=20
+specified like normal VOID* PCD, and also be specified by its structure fi=
eld.
+
 Refer to the _EDK II Build Specification_ for the description of the PCD  =
processing rules.
=20
@@ -218,7 +221,7 @@ fields that are separated by the pipe character, "|".
 <SkuIdS>        ::=3D <Keyword> [<FS> <Keyword>]*
 <Keyword>       ::=3D <UiName>
 <UiName>        ::=3D <Word>
-<FabStatements> ::=3D {<MacroDefinition>} {<IncludeStatement>} {<PcdEntry>=
}
+<FabStatements> ::=3D {<MacroDefinition>} {<IncludeStatement>}=20
+{<PcdEntry>} {<PcdFieldEntry>}
 <PcdEntry>      ::=3D <TS> <PcdName> [<FS> <PcdValue>] <EOL>
 <PcdValue>      ::=3D if (pcddatumtype =3D=3D "BOOLEAN"):
                       {<BoolType>} {<Expression>} @@ -326,7 +329,7 @@ of t=
he DSC file.
 <SkuIdS>        ::=3D <Keyword> [<FS> <Keyword>]*
 <Keyword>       ::=3D <UiName>
 <UiName>        ::=3D <Word>
-<PimStatements> ::=3D {<MacroDefinition>} {<IncludeStatement>} {<PcdEntry>=
}
+<PimStatements> ::=3D {<MacroDefinition>} {<IncludeStatement>}=20
+{<PcdEntry>} {<PcdFieldEntry>}
 <PcdEntry>      ::=3D <TS> <PcdName> [<FS> <PcdValue>] <EOL>
 <PcdValue>      ::=3D if (pcddatumtype =3D=3D "BOOLEAN"):
                       {<BoolType>} {<Expression>} @@ -449,16 +452,16 @@ se=
ctions of the DSC file.
 <PcdsDefault>    ::=3D "[PcdsDynamicDefault" [<PddAttribs>] "]" <EOL>
                      <PddEntries>*
 <PddEntries>     ::=3D {<MacroDefinition>} {<IncludeStatement>}
-                     {<TS> <MinEntry>}
+                     {<TS> <MinEntry>} {<TS> <PcdFieldEntry>}
 <PddAttribs>     ::=3D <attrs> ["," <TS> "PcdsDynamicDefault" <attrs>]*
 <PcdsVpd>        ::=3D "[PcdsDynamicVpd" [<PdvAttribs>] "]" <EOL>
                      <PdvEntries>*
 <PdvAttribs>     ::=3D <attrs> [ "," <TS> "PcdsDynamicVpd" <attrs>]*
-<PdvEntries>     ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS> <Vpd=
Entry>}
+<PdvEntries>     ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS> <Vpd=
Entry>} {<TS> <PcdFieldEntry>}
 <PcdsHii>        ::=3D "[PcdsDynamicHii" [<PdhAttribs>] "]" <EOL>
                      <PcdHiiEntries>*
 <PdhAttribs>     ::=3D <phattrs> ["," <TS> "PcdsDynamicHii <phattrs>]* <Pd=
vEntries>*
-<PcdHiiEntries>  ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS> <Hii=
Entry>}
+<PcdHiiEntries>  ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS>=20
+<HiiEntry>} {<TS> <PcdFieldEntry>}
 <attrs>          ::=3D "." <arch> ["." <SkuIds>]
 <phattrs>        ::=3D "." <arch> ["." <SkuIds>]["." <DefaultStore>]
 <SkuIdS>         ::=3D <Keyword> [<FS> <Keyword>]*
@@ -662,18 +665,18 @@ sections of the DSC file.
 <Pcds>           ::=3D {<PcdsExDefault>} {<PcdsExVpd>} {<PcdsExHii>}
 <PcdsExDefault>  ::=3D "[PcdsDynamicExDefault" [<PddAttribs>] "]" <EOL>
                      <PddEntries>*
-<PddEntries>     ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS> <Min=
Entry>}
+<PddEntries>     ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS> <Min=
Entry>} {<TS> <PcdFieldEntry>}
 <PddAttribs>     ::=3D <attrs> ["," <TS> "PcdsDynamicExDefault" <attrs>]*
 <PcdsExVpd>      ::=3D "[PcdsDynamicExVpd" [<PdvAttribs>] "]" <EOL>
                      <PdvEntries>*
 <PdvAttribs>     ::=3D <attrs> [ "," <TS> "PcdsDynamicExVpd" <attrs>]*
 <PdvEntries>     ::=3D {<MacroDefinition>} {<IncludeStatement>}
-                     {<TS> <VpdEntry>}
+                     {<TS> <VpdEntry>} {<TS> <PcdFieldEntry>}
 <PcdsExHii>      ::=3D "[PcdsDynamicExHii" [<PdhAttribs>] "]" <EOL>
                      <PcdHiiEntries>*
 <PdhAttribs>     ::=3D <phattrs> ["," <TS> "PcdsDynamicExHii <phattrs>]*
                      <PdvEntries>*
-<PcdHiiEntries>  ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS> <Hii=
Entry>}
+<PcdHiiEntries>  ::=3D {<MacroDefinition>} {<IncludeStatement>} {<TS>=20
+<HiiEntry>} {<TS> <PcdFieldEntry>}
 <attrs>          ::=3D "." <arch> ["." <SkuIds>]
 <phattrs>        ::=3D "." <arch> ["." <SkuIds>]["." <DefaultStore>]
 <SkuIdS>         ::=3D <Keyword> [<FS> <Keyword>]*
diff --git a/3_edk_ii_dsc_file_format/33_platform_dsc_definition.md b/3_edk=
_ii_dsc_file_format/33_platform_dsc_definition.md
index 5b1c0d4..313fc20 100644
--- a/3_edk_ii_dsc_file_format/33_platform_dsc_definition.md
+++ b/3_edk_ii_dsc_file_format/33_platform_dsc_definition.md
@@ -1,7 +1,7 @@
 <!--- @file
   3.3 Platform DSC Definition
=20
-  Copyright (c) 2006-2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006-2018, Intel Corporation. All rights reserved.<BR>
=20
   Redistribution and use in source (original document form) and 'compiled'
   forms (converted to PDF, epub, HTML and other formats) with or without @=
@ -192,9 +192,13 @@ The following are common definitions used by multiple s=
ection types.
 <BoolType>             ::=3D {<BoolVal>} {"{"<BoolVal>"}"}
 <MACRO>                ::=3D (A-Z)(A-Z0-9_)*
 <MACROVAL>             ::=3D "$(" <MACRO> ")"
+<PcdFieldName>         ::=3D <TokenSpaceGuidCName> "." <PcdCName> "." <Fie=
ld>
 <PcdName>              ::=3D <TokenSpaceGuidCName> "." <PcdCName>
 <PcdCName>             ::=3D <CName>
 <TokenSpaceGuidCName>  ::=3D <CName>
+<Field>                ::=3D <CName>
+<PcdFieldEntry>        ::=3D <PcdFieldName> <FS> <PcdFieldValue> <EOL>
+<PcdFieldValue>        ::=3D {<BoolType>} {<NumValUint8>} {<NumValUint16>}=
 {<NumValUint32>} {<NumValUint64>} {<StringVal>} {<MACROVAL>} {<Expression>=
}
 <PCDVAL>               ::=3D "PCD(" <PcdName> ")"
 <UINT8>                ::=3D {"0x"} {"0X"} (\x0 - \xFF)
 <UINT16>               ::=3D {"0x"} {"0X"} (\x0 - \xFFFF)
--
2.8.0.windows.1