From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v1 0/4] BaseTools: eliminate some redundant code.
Date: Fri, 30 Mar 2018 01:12:01 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FBFEAC@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1522281624.git.jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Thursday, March 29, 2018 8:02 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/4] BaseTools: eliminate some redundant code.
no external behavorial change, but remove some confusing and unneeded code.
Jaben Carsey (4):
BaseTools: no need to do int() API work for it
BaseTools: use in to compare single chars
BaseTools: remove loop and variables.
BaseTools: cleanup class heirarchy
BaseTools/Source/Python/AutoGen/GenC.py | 5 +----
BaseTools/Source/Python/Common/DecClassObject.py | 13 +------------
BaseTools/Source/Python/Common/DscClassObject.py | 13 +------------
BaseTools/Source/Python/Common/Expression.py | 6 +++---
BaseTools/Source/Python/Common/FdfClassObject.py | 12 +-----------
BaseTools/Source/Python/Common/InfClassObject.py | 13 +------------
BaseTools/Source/Python/Common/Misc.py | 13 -------------
BaseTools/Source/Python/Ecc/MetaFileWorkspace/MetaFileParser.py | 13 +------------
BaseTools/Source/Python/GenFds/FdfParser.py | 5 +----
BaseTools/Source/Python/PatchPcdValue/PatchPcdValue.py | 10 ++--------
10 files changed, 12 insertions(+), 91 deletions(-)
--
2.16.2.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-03-30 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 0:02 [PATCH v1 0/4] BaseTools: eliminate some redundant code Jaben Carsey
2018-03-29 0:02 ` [PATCH v1 1/4] BaseTools: no need to do int() API work for it Jaben Carsey
2018-03-29 0:02 ` [PATCH v1 2/4] BaseTools: use in to compare single chars Jaben Carsey
2018-03-29 0:02 ` [PATCH v1 3/4] BaseTools: remove loop and variables Jaben Carsey
2018-03-29 0:02 ` [PATCH v1 4/4] BaseTools: cleanup class heirarchy Jaben Carsey
2018-03-30 1:12 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51FBFEAC@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox