public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v1 0/4] BaseTools: remove un-needed code
Date: Tue, 3 Apr 2018 09:26:53 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FC2FC1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1522369072.git.jaben.carsey@intel.com>

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Friday, March 30, 2018 8:19 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/4] BaseTools: remove un-needed code

improve the code by removing uncalled functions and using more built in functionality.

Jaben Carsey (4):
  BaseTools: change hex parsing to use built in
  BaseTools: remove uncalled function
  BaseTools: make static functions when self is not needed
  BaseTools: remove uncalled functions

 BaseTools/Source/Python/Common/FdfParserLite.py      | 63 +++++--------------
 BaseTools/Source/Python/Ecc/CodeFragmentCollector.py | 36 +----------  BaseTools/Source/Python/Eot/CodeFragmentCollector.py | 36 +----------
 BaseTools/Source/Python/GenFds/FdfParser.py          | 66 +++++---------------
 4 files changed, 32 insertions(+), 169 deletions(-)

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2018-04-03  9:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30  0:19 [PATCH v1 0/4] BaseTools: remove un-needed code Jaben Carsey
2018-03-30  0:19 ` [PATCH v1 1/4] BaseTools: change hex parsing to use built in Jaben Carsey
2018-03-30  0:19 ` [PATCH v1 2/4] BaseTools: remove uncalled function Jaben Carsey
2018-03-30  0:19 ` [PATCH v1 3/4] BaseTools: make static functions when self is not needed Jaben Carsey
2018-03-30  0:19 ` [PATCH v1 4/4] BaseTools: remove uncalled functions Jaben Carsey
2018-04-03  9:26 ` Zhu, Yonghong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51FC2FC1@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox