public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v1 00/10] BaseTools: refactor code
Date: Sun, 8 Apr 2018 06:40:37 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FDA42C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1522789210.git.jaben.carsey@intel.com>

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Wednesday, April 04, 2018 5:03 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 00/10] BaseTools: refactor code

remove sdict class use and replace with built in types remove unused code

Jaben Carsey (10):
  BaseTools: Use local variable for list of constants.
  BaseTools: use built in dict instead of custom version.
  BaseTools: Eot tool never populates this dictionary
  BaseTools: remove unused include statement
  BaseTools - AutoGen - replace custom dictionary class with python
    standard one
  BaseTools: Eot remove unused code
  BaseTools: use built in dict instead of custom version.
  BaseTools: use combined version of standard dicts
  BaseTools: Workspace - use built in OrderedDict instead of custom
    version.
  BaseTools: Remove unused code from Misc

 BaseTools/Source/Python/AutoGen/AutoGen.py              |  31 +--
 BaseTools/Source/Python/AutoGen/GenC.py                 |  30 ++-
 BaseTools/Source/Python/AutoGen/GenMake.py              |   3 +-
 BaseTools/Source/Python/Common/DscClassObject.py        |   4 +-
 BaseTools/Source/Python/Common/EdkIIWorkspaceBuild.py   |  10 +-
 BaseTools/Source/Python/Common/Misc.py                  | 280 +-------------------
 BaseTools/Source/Python/CommonDataClass/PackageClass.py |   4 +-
 BaseTools/Source/Python/Eot/Eot.py                      |   9 -
 BaseTools/Source/Python/Eot/EotGlobalData.py            |  16 +-
 BaseTools/Source/Python/Eot/FvImage.py                  |  21 --
 BaseTools/Source/Python/Eot/Parser.py                   |   3 +-
 BaseTools/Source/Python/GenFds/GenFds.py                |   1 -
 BaseTools/Source/Python/Workspace/BuildClassObject.py   |   4 +-
 BaseTools/Source/Python/Workspace/DecBuildData.py       |  24 +-
 BaseTools/Source/Python/Workspace/DscBuildData.py       |  24 +-
 BaseTools/Source/Python/Workspace/InfBuildData.py       |  52 ++--
 BaseTools/Source/Python/Workspace/WorkspaceCommon.py    |  21 +-
 BaseTools/Source/Python/build/build.py                  |  10 +-
 18 files changed, 118 insertions(+), 429 deletions(-)

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2018-04-08  6:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 21:03 [PATCH v1 00/10] BaseTools: refactor code Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 01/10] BaseTools: Use local variable for list of constants Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 02/10] BaseTools: use built in dict instead of custom version Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 03/10] BaseTools: Eot tool never populates this dictionary Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 04/10] BaseTools: remove unused import statement Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 05/10] BaseTools - AutoGen - replace custom dictionary class with python standard one Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 06/10] BaseTools: Eot remove unused code Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 07/10] BaseTools: use built in OrderedDict instead of custom version Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 08/10] BaseTools: use combined version of OrderedDict Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 09/10] BaseTools: Workspace - use built in OrderedDict instead of custom version Jaben Carsey
2018-04-03 21:03 ` [PATCH v1 10/10] BaseTools: Remove unused code from Misc Jaben Carsey
2018-04-08  6:40 ` Zhu, Yonghong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51FDA42C@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox