From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2BA08226516A3 for ; Sun, 8 Apr 2018 00:05:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2018 00:05:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,422,1517904000"; d="scan'208";a="218546888" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 08 Apr 2018 00:05:37 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 8 Apr 2018 00:05:36 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.197]) with mapi id 14.03.0319.002; Sun, 8 Apr 2018 15:05:34 +0800 From: "Zhu, Yonghong" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring Thread-Index: AQHTy5vpu5S7F1r76EGIT4lGjTnPR6P2eKSA Date: Sun, 8 Apr 2018 07:05:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 0/5] BaseTools: RegEx refactoring X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Apr 2018 07:05:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patches are good to me. Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jabe= n Carsey Sent: Wednesday, April 04, 2018 6:34 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/5] BaseTools: RegEx refactoring move RegEx compile out of functions/loops share RegEx when have identical d= ata Jaben Carsey (5): BaseTools: Autogen - move RegEx compile BaseTools: GenFds - move RegEx compile BaseTools: Add new RegEx pattern to GlobalData BaseTools: AutoGen - use the new shared RegEx BaseTools: remove redundant check BaseTools/Source/Python/AutoGen/AutoGen.py | 22 +++++++++++++------= - BaseTools/Source/Python/AutoGen/IdfClassObject.py | 5 +++-- BaseTools/So= urce/Python/AutoGen/UniClassObject.py | 8 +++---- BaseTools/Source/Python/Common/GlobalData.py | 3 +++ BaseTools/Source/Python/GenFds/FdfParser.py | 5 ++--- 5 files changed, 27 insertions(+), 16 deletions(-) -- 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel