public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity
Date: Tue, 10 Apr 2018 01:53:44 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FDC6C2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1522969977.git.jaben.carsey@intel.com>

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Friday, April 06, 2018 7:14 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity

group of changes to make code smaller and reduce overhead.

Jaben Carsey (14):
  BaseTools: remove unused file
  BaseTools: remove uncalled functions
  BaseTools: defaultdict(set) allows us to just add to the set
  BaseTools: sets are faster to check via "in" due to hashing
  BaseTools: replace a dict with a set
  BaseTools: remove unused variables
  BaseTools: change list to set
  BaseTools: simplify testing for existance and containing data
  BaseTools: optimize buildoptions loop
  BaseTools: change another list to set
  BaseTools: remove unneeded function call
  BaseTools: change more list to set
  BaseTools: GenC - move content from both parts of if/else
  BaseTools: refactor and remove out of date use of .keys()

 BaseTools/Scripts/SmiHandlerProfileSymbolGen.py           |   4 +-
 BaseTools/Source/Python/AutoGen/AutoGen.py                | 101 +++++++-------------
 BaseTools/Source/Python/AutoGen/BuildEngine.py            |  29 ++----
 BaseTools/Source/Python/AutoGen/GenC.py                   |   6 +-
 BaseTools/Source/Python/AutoGen/GenMake.py                |   2 +-
 BaseTools/Source/Python/Common/Dictionary.py              |  76 ---------------
 BaseTools/Source/Python/Common/TargetTxtClassObject.py    |  27 ------
 BaseTools/Source/Python/Common/ToolDefClassObject.py      |   7 +-
 BaseTools/Source/Python/GenFds/Fv.py                      |   2 +-
 BaseTools/Source/Python/GenFds/Section.py                 |   5 +-
 BaseTools/Source/Python/TargetTool/TargetTool.py          |   3 +-
 BaseTools/Source/Python/UPT/PomAdapter/InfPomAlignment.py |   5 +-
 BaseTools/Source/Python/build/build.py                    |   4 +-
 13 files changed, 59 insertions(+), 212 deletions(-)  delete mode 100644 BaseTools/Source/Python/Common/Dictionary.py

--
2.16.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2018-04-10  1:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 23:13 [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 01/14] BaseTools: remove unused file Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 02/14] BaseTools: remove uncalled functions Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 03/14] BaseTools: defaultdict(set) allows us to just add to the set Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 04/14] BaseTools: sets are faster to check via "in" due to hashing Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 05/14] BaseTools: replace a dict with a set Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 06/14] BaseTools: remove unused variables Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 07/14] BaseTools: change list to set Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 08/14] BaseTools: simplify testing for existance and containing data Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 09/14] BaseTools: optimize buildoptions loop Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 10/14] BaseTools: change another list to set Jaben Carsey
2018-04-05 23:13 ` [PATCH v1 11/14] BaseTools: remove unneeded function call Jaben Carsey
2018-04-05 23:14 ` [PATCH v1 12/14] BaseTools: change more list to set Jaben Carsey
2018-04-05 23:14 ` [PATCH v1 13/14] BaseTools: GenC - move content from both parts of if/else Jaben Carsey
2018-04-05 23:14 ` [PATCH v1 14/14] BaseTools: refactor and remove out of date use of .keys() Jaben Carsey
2018-04-10  1:53 ` Zhu, Yonghong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51FDC6C2@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox