From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B8FC21F2E0EA for ; Mon, 9 Apr 2018 18:53:47 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 18:53:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,429,1517904000"; d="scan'208";a="45574692" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 09 Apr 2018 18:53:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Apr 2018 18:53:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.43]) with mapi id 14.03.0319.002; Tue, 10 Apr 2018 09:53:44 +0800 From: "Zhu, Yonghong" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity Thread-Index: AQHTzTPR78suQezfjEGLYtgtK4W0QKP5QwdA Date: Tue, 10 Apr 2018 01:53:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 01:53:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jabe= n Carsey Sent: Friday, April 06, 2018 7:14 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 00/14] BaseTools: refactoring the code for readab= ility and simplicity group of changes to make code smaller and reduce overhead. Jaben Carsey (14): BaseTools: remove unused file BaseTools: remove uncalled functions BaseTools: defaultdict(set) allows us to just add to the set BaseTools: sets are faster to check via "in" due to hashing BaseTools: replace a dict with a set BaseTools: remove unused variables BaseTools: change list to set BaseTools: simplify testing for existance and containing data BaseTools: optimize buildoptions loop BaseTools: change another list to set BaseTools: remove unneeded function call BaseTools: change more list to set BaseTools: GenC - move content from both parts of if/else BaseTools: refactor and remove out of date use of .keys() BaseTools/Scripts/SmiHandlerProfileSymbolGen.py | 4 +- BaseTools/Source/Python/AutoGen/AutoGen.py | 101 +++++++---= ---------- BaseTools/Source/Python/AutoGen/BuildEngine.py | 29 ++---- BaseTools/Source/Python/AutoGen/GenC.py | 6 +- BaseTools/Source/Python/AutoGen/GenMake.py | 2 +- BaseTools/Source/Python/Common/Dictionary.py | 76 ----------= ----- BaseTools/Source/Python/Common/TargetTxtClassObject.py | 27 ------ BaseTools/Source/Python/Common/ToolDefClassObject.py | 7 +- BaseTools/Source/Python/GenFds/Fv.py | 2 +- BaseTools/Source/Python/GenFds/Section.py | 5 +- BaseTools/Source/Python/TargetTool/TargetTool.py | 3 +- BaseTools/Source/Python/UPT/PomAdapter/InfPomAlignment.py | 5 +- BaseTools/Source/Python/build/build.py | 4 +- 13 files changed, 59 insertions(+), 212 deletions(-) delete mode 100644 B= aseTools/Source/Python/Common/Dictionary.py -- 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel