From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v1 0/5] BaseTools: remove or change un-needed variables
Date: Tue, 17 Apr 2018 12:42:27 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FED4CB@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1523402167.git.jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Wednesday, April 11, 2018 7:17 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/5] BaseTools: remove or change un-needed variables
use sets instead of lists when doing only "in" testing later use counts instead of lists when they just get counted after
Jaben Carsey (5):
BaseTools: use existing shared variable
BaseTools: no need to save the data
BaseTools: skip updating temporary variable.
BaseTools: use set instead of list for a variable to be used with in
BaseTools: reduce list usage when not needed
BaseTools/Source/Python/AutoGen/AutoGen.py | 26 ++++-------
BaseTools/Source/Python/AutoGen/GenC.py | 48 +++++++++++---------
BaseTools/Source/Python/AutoGen/GenVar.py | 15 +++---
BaseTools/Source/Python/Common/Misc.py | 2 +-
BaseTools/Source/Python/Workspace/DscBuildData.py | 38 ++++++++--------
5 files changed, 63 insertions(+), 66 deletions(-)
--
2.16.2.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-04-17 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 23:17 [PATCH v1 0/5] BaseTools: remove or change un-needed variables Jaben Carsey
2018-04-10 23:17 ` [PATCH v1 1/5] BaseTools: use existing shared variable Jaben Carsey
2018-04-10 23:17 ` [PATCH v1 2/5] BaseTools: no need to save the data Jaben Carsey
2018-04-10 23:17 ` [PATCH v1 3/5] BaseTools: skip updating temporary variable Jaben Carsey
2018-04-10 23:17 ` [PATCH v1 4/5] BaseTools: use set instead of list for a variable to be used with in Jaben Carsey
2018-04-10 23:17 ` [PATCH v1 5/5] BaseTools: reduce list usage when not needed Jaben Carsey
2018-04-17 12:42 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51FED4CB@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox