From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v1 0/9] BaseTools: refactoring
Date: Tue, 17 Apr 2018 13:18:48 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FED531@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1523652583.git.jaben.carsey@intel.com>
Reviewed this series patch.
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Saturday, April 14, 2018 4:51 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/9] BaseTools: refactoring
group of patches for refactoring BaseTools. removing unused functions, variables, and parameters. make functions statis where apropriate.
Jaben (9):
BaseTools: remove unused local variable.
BaseTools: change DscBuildData functions without need for self to
staticmethod
BaseTools: Remove unused functions from DscBuildData
BaseTools: move RegEx compile out of loops
BaseTools: use dictionary.get() when we have value if not found
BaseTools: refactor DepexSection.GenSection
BaseTools: FdfParser refactor to remove a dictionary
BaseTools: FdfParser - refactor functions to make static
BaseTools: FfsInfStatement - remove unused function
BaseTools/Source/Python/GenFds/DepexSection.py | 14 +-
BaseTools/Source/Python/GenFds/FdfParser.py | 20 +--
BaseTools/Source/Python/GenFds/FfsInfStatement.py | 27 +--- BaseTools/Source/Python/Workspace/DscBuildData.py | 146 +++++++++-----------
BaseTools/Source/Python/build/build.py | 4 +-
5 files changed, 87 insertions(+), 124 deletions(-)
--
2.16.2.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-04-17 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 20:51 [PATCH v1 0/9] BaseTools: refactoring Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 1/9] BaseTools: remove unused local variable Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 2/9] BaseTools: change DscBuildData functions without need for self to staticmethod Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 3/9] BaseTools: Remove unused functions from DscBuildData Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 4/9] BaseTools: move RegEx compile out of loops Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 5/9] BaseTools: use dictionary.get() when we have value if not found Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 6/9] BaseTools: refactor DepexSection.GenSection Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 7/9] BaseTools: FdfParser refactor to remove a dictionary Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 8/9] BaseTools: FdfParser - refactor functions to make static Jaben Carsey
2018-04-13 20:51 ` [PATCH v1 9/9] BaseTools: FfsInfStatement - remove unused function Jaben Carsey
2018-04-17 13:18 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51FED531@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox