From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 328B721F2E189 for ; Tue, 17 Apr 2018 06:18:51 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 06:18:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="34912029" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 17 Apr 2018 06:18:51 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 17 Apr 2018 06:18:51 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 17 Apr 2018 06:18:50 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.79]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.109]) with mapi id 14.03.0319.002; Tue, 17 Apr 2018 21:18:48 +0800 From: "Zhu, Yonghong" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v1 0/9] BaseTools: refactoring Thread-Index: AQHT02k9fFBeX4IkdkCKFoqgKPiLNaQE9l6w Date: Tue, 17 Apr 2018 13:18:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 0/9] BaseTools: refactoring X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 13:18:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed this series patch. Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jabe= n Carsey Sent: Saturday, April 14, 2018 4:51 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 0/9] BaseTools: refactoring group of patches for refactoring BaseTools. removing unused functions, var= iables, and parameters. make functions statis where apropriate. Jaben (9): BaseTools: remove unused local variable. BaseTools: change DscBuildData functions without need for self to staticmethod BaseTools: Remove unused functions from DscBuildData BaseTools: move RegEx compile out of loops BaseTools: use dictionary.get() when we have value if not found BaseTools: refactor DepexSection.GenSection BaseTools: FdfParser refactor to remove a dictionary BaseTools: FdfParser - refactor functions to make static BaseTools: FfsInfStatement - remove unused function BaseTools/Source/Python/GenFds/DepexSection.py | 14 +- BaseTools/Source/Python/GenFds/FdfParser.py | 20 +-- BaseTools/Source/Python/GenFds/FfsInfStatement.py | 27 +--- BaseTools/So= urce/Python/Workspace/DscBuildData.py | 146 +++++++++----------- BaseTools/Source/Python/build/build.py | 4 +- 5 files changed, 87 insertions(+), 124 deletions(-) -- 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel