public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [PATCH v1 1/4] BaseTools: remove duplicate function name
Date: Wed, 18 Apr 2018 08:37:44 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D51FEDCCB@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <6367bdaa2b96088e159225bd6032befa575dc76c.1523487973.git.jaben.carsey@intel.com>

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Carsey, Jaben 
Sent: Thursday, April 12, 2018 7:08 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [PATCH v1 1/4] BaseTools: remove duplicate function name

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Eot/FvImage.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/Eot/FvImage.py b/BaseTools/Source/Python/Eot/FvImage.py
index 472ae400506d..39c31d768d5d 100644
--- a/BaseTools/Source/Python/Eot/FvImage.py
+++ b/BaseTools/Source/Python/Eot/FvImage.py
@@ -1,7 +1,7 @@
 ## @file
 # Parse FV image
 #
-# Copyright (c) 2008 - 2014, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2008 - 2018, Intel Corporation. All rights 
+reserved.<BR>
 # This program and the accompanying materials  # are licensed and made available under the terms and conditions of the BSD License  # which accompanies this distribution.  The full text of the license may be found at @@ -363,7 +363,7 @@ class FirmwareVolume(Image):
                     NewFfs = self.UnDispatchedFfsDict.pop(FfsID)
                     NewFfs.Depex = DepexString
                     if FileDepex is not None:
-                        ScheduleList.insert.insert(FileDepex[1], FfsID, NewFfs, FileDepex[0])
+                        ScheduleList.insert(FileDepex[1], FfsID, 
+ NewFfs, FileDepex[0])
                     else:
                         ScheduleList[FfsID] = NewFfs
                 else:
--
2.16.2.windows.1



  reply	other threads:[~2018-04-18  8:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 23:08 [PATCH v1 0/4] BaseTools: refactoring (and one bug fix) Jaben
2018-04-11 23:08 ` [PATCH v1 1/4] BaseTools: remove duplicate function name Jaben
2018-04-18  8:37   ` Zhu, Yonghong [this message]
2018-04-11 23:08 ` [PATCH v1 2/4] BaseTools: replace 'UINT8', 'UINT16', 'UINT32', 'UINT64', 'VOID*' with shared constants Jaben
2018-04-17 13:32   ` Zhu, Yonghong
2018-04-11 23:08 ` [PATCH v1 3/4] BaseTools: Remove un-needed list comprehension Jaben
2018-04-18  8:38   ` Zhu, Yonghong
2018-04-11 23:08 ` [PATCH v1 4/4] BaseTools: merge towards minimum PCD MAX <something> methods Jaben
2018-04-12  0:40   ` Feng, Bob C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D51FEDCCB@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox