public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [PATCH v1 26/27] BaseTools: remove unused MigrationUtilities.py
Date: Wed, 2 May 2018 06:49:19 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D52000891@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <ebe5419fa5746c76dfa321e0de71306a8d704252.1524239028.git.jaben.carsey@intel.com>

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Carsey, Jaben 
Sent: Friday, April 20, 2018 11:52 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [PATCH v1 26/27] BaseTools: remove unused MigrationUtilities.py

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 BaseTools/Source/Python/Common/MigrationUtilities.py | 568 --------------------
 BaseTools/Source/Python/Makefile                     |   1 -
 2 files changed, 569 deletions(-)

diff --git a/BaseTools/Source/Python/Common/MigrationUtilities.py b/BaseTools/Source/Python/Common/MigrationUtilities.py
deleted file mode 100644
index 0c93c72a60f6..000000000000
--- a/BaseTools/Source/Python/Common/MigrationUtilities.py
+++ /dev/null
@@ -1,568 +0,0 @@
-## @file
-# Contains several utilitities shared by migration tools.
-#
-# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR> -# This program and the accompanying materials -# are licensed and made available under the terms and conditions of the BSD License -# which accompanies this distribution.  The full text of the license may be found at -# http://opensource.org/licenses/bsd-license.php
-#
-# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-
-##
-# Import Modules
-#
-import Common.LongFilePathOs as os
-import re
-import EdkLogger
-from optparse import OptionParser
-from Common.BuildToolError import *
-from XmlRoutines import *
-from CommonDataClass.CommonClass import * -from Common.LongFilePathSupport import OpenLongFilePath as open
-
-## Set all fields of CommonClass object.
-#
-# Set all attributes of CommonClass object from XML Dom object of XmlCommon.
-#
-# @param  Common     The destine CommonClass object.
-# @param  XmlCommon  The source XML Dom object.
-#
-def SetCommon(Common, XmlCommon):
-    XmlTag = "Usage"
-    Common.Usage = XmlAttribute(XmlCommon, XmlTag).split()
-
-    XmlTag = TAB_PCDS_FEATURE_FLAG
-    Common.FeatureFlag = XmlAttribute(XmlCommon, XmlTag)
-    
-    XmlTag = "SupArchList"
-    Common.SupArchList = XmlAttribute(XmlCommon, XmlTag).split()
-    
-    XmlTag = XmlNodeName(XmlCommon) + "/" + "HelpText"
-    Common.HelpText = XmlElement(XmlCommon, XmlTag)
-
-
-## Set some fields of CommonHeaderClass object.
-#
-# Set Name, Guid, FileName and FullPath fields of CommonHeaderClass object from -# XML Dom object of XmlCommonHeader, NameTag and FileName.
-#
-# @param  CommonHeader       The destine CommonClass object.
-# @param  XmlCommonHeader    The source XML Dom object.
-# @param  NameTag            The name tag in XML Dom object.
-# @param  FileName           The file name of the XML file.
-#
-def SetIdentification(CommonHeader, XmlCommonHeader, NameTag, FileName):
-    XmlParentTag = XmlNodeName(XmlCommonHeader)
-    
-    XmlTag = XmlParentTag + "/" + NameTag
-    CommonHeader.Name = XmlElement(XmlCommonHeader, XmlTag)
-
-    XmlTag = XmlParentTag + "/" + "GuidValue"
-    CommonHeader.Guid = XmlElement(XmlCommonHeader, XmlTag)
-
-    XmlTag = XmlParentTag + "/" + "Version"
-    CommonHeader.Version = XmlElement(XmlCommonHeader, XmlTag)
-
-    CommonHeader.FileName = os.path.basename(FileName)
-    CommonHeader.FullPath = os.path.abspath(FileName)
-
-
-## Regular expression to match specification and value.
-mReSpecification = re.compile(r"(?P<Specification>\w+)\s+(?P<Value>\w*)")
-
-## Add specification to specification dictionary.
-#
-# Abstract specification name, value pair from Specification String and add them -# to specification dictionary.
-#
-# @param  SpecificationDict   The destine Specification dictionary.
-# @param  SpecificationString The source Specification String from which the
-#                             specification name and value pair is abstracted.
-#
-def AddToSpecificationDict(SpecificationDict, SpecificationString):
-    """Abstract specification name, value pair from Specification String"""
-    for SpecificationMatch in mReSpecification.finditer(SpecificationString):
-        Specification = SpecificationMatch.group("Specification")
-        Value = SpecificationMatch.group("Value")
-        SpecificationDict[Specification] = Value
-
-## Set all fields of CommonHeaderClass object.
-#
-# Set all attributes of CommonHeaderClass object from XML Dom object of -# XmlCommonHeader, NameTag and FileName.
-#
-# @param  CommonHeader       The destine CommonClass object.
-# @param  XmlCommonHeader    The source XML Dom object.
-# @param  NameTag            The name tag in XML Dom object.
-# @param  FileName           The file name of the XML file.
-#
-def SetCommonHeader(CommonHeader, XmlCommonHeader):
-    """Set all attributes of CommonHeaderClass object from XmlCommonHeader"""
-    XmlParent = XmlNodeName(XmlCommonHeader)
-    
-    XmlTag = XmlParent + "/" + "Abstract"
-    CommonHeader.Abstract = XmlElement(XmlCommonHeader, XmlTag)
-
-    XmlTag = XmlParent + "/" + "Description"
-    CommonHeader.Description = XmlElement(XmlCommonHeader, XmlTag)
-
-    XmlTag = XmlParent + "/" + "Copyright"
-    CommonHeader.Copyright = XmlElement(XmlCommonHeader, XmlTag)
-
-    XmlTag = XmlParent + "/" + "License"
-    CommonHeader.License = XmlElement(XmlCommonHeader, XmlTag)
-
-    XmlTag = XmlParent + "/" + "Specification"
-    Specification = XmlElement(XmlCommonHeader, XmlTag)
-
-    AddToSpecificationDict(CommonHeader.Specification, Specification)
-
-    XmlTag = XmlParent + "/" + "ModuleType"
-    CommonHeader.ModuleType = XmlElement(XmlCommonHeader, XmlTag)
-
-
-## Load a new Cloned Record class object.
-#
-# Read an input XML ClonedRecord DOM object and return an object of Cloned Record -# contained in the DOM object.
-#
-# @param  XmlCloned            A child XML DOM object in a Common XML DOM.
-#
-# @retvel ClonedRecord         A new Cloned Record object created by XmlCloned.
-#
-def LoadClonedRecord(XmlCloned):
-    ClonedRecord = ClonedRecordClass()
-
-    XmlTag = "Id"
-    ClonedRecord.Id = int(XmlAttribute(XmlCloned, XmlTag))
-
-    XmlTag = "FarGuid"
-    ClonedRecord.FarGuid = XmlAttribute(XmlCloned, XmlTag)
-
-    XmlTag = "Cloned/PackageGuid"
-    ClonedRecord.PackageGuid = XmlElement(XmlCloned, XmlTag)
-    
-    XmlTag = "Cloned/PackageVersion"
-    ClonedRecord.PackageVersion = XmlElement(XmlCloned, XmlTag)
-    
-    XmlTag = "Cloned/ModuleGuid"
-    ClonedRecord.ModuleGuid = XmlElement(XmlCloned, XmlTag)
-    
-    XmlTag = "Cloned/ModuleVersion"
-    ClonedRecord.ModuleVersion = XmlElement(XmlCloned, XmlTag)
-    
-    return ClonedRecord
-
-
-## Load a new Guid/Protocol/Ppi common class object.
-#
-# Read an input XML Guid/Protocol/Ppi DOM object and return an object of -# Guid/Protocol/Ppi contained in the DOM object.
-#
-# @param  XmlGuidProtocolPpiCommon A child XML DOM object in a Common XML DOM.
-#
-# @retvel GuidProtocolPpiCommon    A new GuidProtocolPpiCommon class object
-#                                  created by XmlGuidProtocolPpiCommon.
-#
-def LoadGuidProtocolPpiCommon(XmlGuidProtocolPpiCommon):
-    GuidProtocolPpiCommon = GuidProtocolPpiCommonClass()
-    
-    XmlTag = "Name"
-    GuidProtocolPpiCommon.Name = XmlAttribute(XmlGuidProtocolPpiCommon, XmlTag)
-
-    XmlParent = XmlNodeName(XmlGuidProtocolPpiCommon)
-    if XmlParent == "Entry":
-        XmlTag = "%s/C_Name" % XmlParent
-    elif XmlParent == "GuidCNames":
-        XmlTag = "%s/GuidCName" % XmlParent
-    else:
-        XmlTag = "%s/%sCName" % (XmlParent, XmlParent)
-        
-    GuidProtocolPpiCommon.CName = XmlElement(XmlGuidProtocolPpiCommon, XmlTag)
-    
-    XmlTag = XmlParent + "/" + "GuidValue"
-    GuidProtocolPpiCommon.Guid = XmlElement(XmlGuidProtocolPpiCommon, XmlTag)
-    
-    if XmlParent.endswith("Notify"):
-        GuidProtocolPpiCommon.Notify = True
-
-    XmlTag = "GuidTypeList"
-    GuidTypes = XmlAttribute(XmlGuidProtocolPpiCommon, XmlTag)
-    GuidProtocolPpiCommon.GuidTypeList = GuidTypes.split()
-    
-    XmlTag = "SupModuleList"
-    SupModules = XmlAttribute(XmlGuidProtocolPpiCommon, XmlTag)
-    GuidProtocolPpiCommon.SupModuleList = SupModules.split()
-
-    SetCommon(GuidProtocolPpiCommon, XmlGuidProtocolPpiCommon)
-
-    return GuidProtocolPpiCommon
-
-
-## Load a new Pcd class object.
-#
-# Read an input XML Pcd DOM object and return an object of Pcd -# contained in the DOM object.
-#
-# @param  XmlPcd               A child XML DOM object in a Common XML DOM.
-#
-# @retvel Pcd                  A new Pcd object created by XmlPcd.
-#
-def LoadPcd(XmlPcd):
-    """Return a new PcdClass object equivalent to XmlPcd"""
-    Pcd = PcdClass()
-
-    XmlTag = "PcdEntry/C_Name"
-    Pcd.CName = XmlElement(XmlPcd, XmlTag)
-
-    XmlTag = "PcdEntry/Token"
-    Pcd.Token = XmlElement(XmlPcd, XmlTag)
-
-    XmlTag = "PcdEntry/TokenSpaceGuidCName"
-    Pcd.TokenSpaceGuidCName = XmlElement(XmlPcd, XmlTag)
-
-    XmlTag = "PcdEntry/DatumType"
-    Pcd.DatumType = XmlElement(XmlPcd, XmlTag)
-
-    XmlTag = "PcdEntry/MaxDatumSize"
-    Pcd.MaxDatumSize = XmlElement(XmlPcd, XmlTag)
-
-    XmlTag = "PcdEntry/DefaultValue"
-    Pcd.DefaultValue = XmlElement(XmlPcd, XmlTag)
-
-    XmlTag = "PcdItemType"
-    Pcd.ItemType = XmlAttribute(XmlPcd, XmlTag)
-
-    XmlTag = "PcdEntry/ValidUsage"
-    Pcd.ValidUsage = XmlElement(XmlPcd, XmlTag).split()
-
-    XmlTag = "SupModuleList"
-    Pcd.SupModuleList = XmlAttribute(XmlPcd, XmlTag).split()
-
-    SetCommon(Pcd, XmlPcd)
-
-    return Pcd
-
-
-## Load a new LibraryClass class object.
-#
-# Read an input XML LibraryClass DOM object and return an object of LibraryClass -# contained in the DOM object.
-#
-# @param  XmlLibraryClass    A child XML DOM object in a Common XML DOM.
-#
-# @retvel LibraryClass       A new LibraryClass object created by XmlLibraryClass.
-#
-def LoadLibraryClass(XmlLibraryClass):
-    LibraryClass = LibraryClassClass()
-
-    XmlTag = "LibraryClass/Keyword"
-    LibraryClass.LibraryClass = XmlElement(XmlLibraryClass, XmlTag)
-    if LibraryClass.LibraryClass == "":
-        XmlTag = "Name"
-        LibraryClass.LibraryClass = XmlAttribute(XmlLibraryClass, XmlTag)
-    
-    XmlTag = "LibraryClass/IncludeHeader"
-    LibraryClass.IncludeHeader = XmlElement(XmlLibraryClass, XmlTag)
-    
-    XmlTag = "RecommendedInstanceVersion"
-    RecommendedInstanceVersion = XmlAttribute(XmlLibraryClass, XmlTag)
-    LibraryClass.RecommendedInstanceVersion = RecommendedInstanceVersion
-    
-    XmlTag = "RecommendedInstanceGuid"
-    RecommendedInstanceGuid = XmlAttribute(XmlLibraryClass, XmlTag)
-    LibraryClass.RecommendedInstanceGuid = RecommendedInstanceGuid
-    
-    XmlTag = "SupModuleList"
-    SupModules = XmlAttribute(XmlLibraryClass, XmlTag)
-    LibraryClass.SupModuleList = SupModules.split()
-    
-    SetCommon(LibraryClass, XmlLibraryClass)
-    
-    return LibraryClass
-
-
-## Load a new Build Option class object.
-#
-# Read an input XML BuildOption DOM object and return an object of Build Option -# contained in the DOM object.
-#
-# @param  XmlBuildOption       A child XML DOM object in a Common XML DOM.
-#
-# @retvel BuildOption          A new Build Option object created by XmlBuildOption.
-#
-def LoadBuildOption(XmlBuildOption):
-    """Return a new BuildOptionClass object equivalent to XmlBuildOption"""
-    BuildOption = BuildOptionClass()
-    
-    BuildOption.Option = XmlElementData(XmlBuildOption)
-
-    XmlTag = "BuildTargets"
-    BuildOption.BuildTargetList = XmlAttribute(XmlBuildOption, XmlTag).split()
-    
-    XmlTag = "ToolChainFamily"
-    BuildOption.ToolChainFamily = XmlAttribute(XmlBuildOption, XmlTag)
-    
-    XmlTag = "TagName"
-    BuildOption.TagName = XmlAttribute(XmlBuildOption, XmlTag)
-    
-    XmlTag = "ToolCode"
-    BuildOption.ToolCode = XmlAttribute(XmlBuildOption, XmlTag)
-    
-    XmlTag = "SupArchList"
-    BuildOption.SupArchList = XmlAttribute(XmlBuildOption, XmlTag).split()
-    
-    return BuildOption
-
-
-## Load a new User Extensions class object.
-#
-# Read an input XML UserExtensions DOM object and return an object of User -# Extensions contained in the DOM object.
-#
-# @param  XmlUserExtensions    A child XML DOM object in a Common XML DOM.
-#
-# @retvel UserExtensions       A new User Extensions object created by
-#                              XmlUserExtensions.
-#
-def LoadUserExtensions(XmlUserExtensions):
-    UserExtensions = UserExtensionsClass()
-    
-    XmlTag = "UserID"
-    UserExtensions.UserID = XmlAttribute(XmlUserExtensions, XmlTag)
-    
-    XmlTag = "Identifier"
-    UserExtensions.Identifier = XmlAttribute(XmlUserExtensions, XmlTag)
-    
-    UserExtensions.Content = XmlElementData(XmlUserExtensions)
-    
-    return UserExtensions
-
-
-## Store content to a text file object.
-#
-# Write some text file content to a text file object. The contents may echo -# in screen in a verbose way.
-#
-# @param  TextFile           The text file object.
-# @param  Content            The string object to be written to a text file.
-#
-def StoreTextFile(TextFile, Content):
-    EdkLogger.verbose(Content)
-    TextFile.write(Content)
-
-
-## Add item to a section.
-#
-# Add an Item with specific CPU architecture to section dictionary.
-# The possible duplication is ensured to be removed.
-#
-# @param  Section            Section dictionary indexed by CPU architecture.
-# @param  Arch               CPU architecture: Ia32, X64, Ipf, ARM, AARCH64, Ebc or Common.
-# @param  Item               The Item to be added to section dictionary.
-#
-def AddToSection(Section, Arch, Item):
-    SectionArch = Section.get(Arch, [])
-    if Item not in SectionArch:
-        SectionArch.append(Item)
-        Section[Arch] = SectionArch
-
-
-## Get section contents.
-#
-# Return the content of section named SectionName.
-# the contents is based on Methods and ObjectLists.
-#
-# @param  SectionName        The name of the section.
-# @param  Method             A function returning a string item of an object.
-# @param  ObjectList         The list of object.
-#
-# @retval Section            The string content of a section.
-#
-def GetSection(SectionName, Method, ObjectList):
-    SupportedArches = ["common", "Ia32", "X64", "Ipf", "Ebc", "ARM", "AARCH64"]
-    SectionDict = {}
-    for Object in ObjectList:
-        Item = Method(Object)
-        if Item == "":
-            continue
-        Item = "  %s" % Item
-        Arches = Object.SupArchList
-        if len(Arches) == 0:
-            AddToSection(SectionDict, "common", Item)
-        else:
-            for Arch in SupportedArches:
-                if Arch.upper() in Arches:
-                    AddToSection(SectionDict, Arch, Item)
-
-    Section = ""
-    for Arch in SupportedArches:
-        SectionArch = "\n".join(SectionDict.get(Arch, []))
-        if SectionArch != "":
-            Section += "[%s.%s]\n%s\n" % (SectionName, Arch, SectionArch)
-            Section += "\n"
-    if Section != "":
-        Section += "\n"
-    return Section
-
-
-## Store file header to a text file.
-#
-# Write standard file header to a text file. The content includes copyright, -# abstract, description and license extracted from CommonHeader class object.
-#
-# @param  TextFile           The text file object.
-# @param  CommonHeader       The source CommonHeader class object.
-#
-def StoreHeader(TextFile, CommonHeader):
-    CopyRight = CommonHeader.Copyright
-    Abstract = CommonHeader.Abstract
-    Description = CommonHeader.Description
-    License = CommonHeader.License
-
-    Header = "#/** @file\n#\n"
-    Header += "# " + Abstract + "\n#\n"
-    Header += "# " + Description.strip().replace("\n", "\n# ") + "\n"
-    Header += "# " + CopyRight + "\n#\n"
-    Header += "#  " + License.replace("\n", "\n# ").replace("  ", " ")
-    Header += "\n#\n#**/\n\n"
-
-    StoreTextFile(TextFile, Header)
-
-## Store file header to a text file.
-#
-# Write Defines section to a text file. DefinesTupleList determines the content.
-#
-# @param  TextFile           The text file object.
-# @param  DefinesTupleList   The list of (Tag, Value) to be added as one item.
-#
-def StoreDefinesSection(TextFile, DefinesTupleList):
-    Section = "[Defines]\n"
-    for DefineItem in DefinesTupleList:
-        Section += "  %-30s = %s\n" % DefineItem
-
-    Section += "\n\n"
-    StoreTextFile(TextFile, Section)
-
-
-## Return one User Extension section.
-#
-# Read the input UserExtentsions class object and return one section.
-#
-# @param  UserExtensions       An input UserExtensions class object.
-#
-# @retval UserExtensionSection A section representing UserExtensions object.
-#
-def GetUserExtensions(UserExtensions):
-    UserId = UserExtensions.UserID
-    Identifier = UserExtensions.Identifier
-    Content = UserExtensions.Content
-
-    return "[UserExtensions.%s.%s]\n  %s\n\n" % (UserId, Identifier, Content)
-
-## Regular expression to match an equation.
-mReEquation = re.compile(r"\s*(\S+)\s*=\s*(\S*)\s*")
-
-## Return a value tuple matching information in a text fle.
-#
-# Parse the text file and return a value tuple corresponding to an input tag -# tuple. In case of any error, an tuple of empty strings is returned.
-#
-# @param  FileName           The file name of the text file.
-# @param  TagTuple           A tuple of tags as the key to the value.
-#
-# @param  ValueTupe          The returned tuple corresponding to the tag tuple.
-#
-def GetTextFileInfo(FileName, TagTuple):
-    ValueTuple = [""] * len(TagTuple)
-    try:
-        for Line in open(FileName):
-            Line = Line.split("#", 1)[0]
-            MatchEquation = mReEquation.match(Line)
-            if MatchEquation:
-                Tag = MatchEquation.group(1).upper()
-                Value = MatchEquation.group(2)
-                for Index in range(len(TagTuple)):
-                    if TagTuple[Index] == Tag:
-                        ValueTuple[Index] = Value
-    except:
-        EdkLogger.info("IO Error in reading file %s" % FileName)
-        
-    return ValueTuple
-
-
-## Return a value tuple matching information in an XML fle.
-#
-# Parse the XML file and return a value tuple corresponding to an input tag -# tuple. In case of any error, an tuple of empty strings is returned.
-#
-# @param  FileName           The file name of the XML file.
-# @param  TagTuple           A tuple of tags as the key to the value.
-#
-# @param  ValueTupe          The returned tuple corresponding to the tag tuple.
-#
-def GetXmlFileInfo(FileName, TagTuple):
-    XmlDom = XmlParseFile(FileName)
-    return tuple([XmlElement(XmlDom, XmlTag) for XmlTag in TagTuple])
-
-
-## Parse migration command line options -# -# Use standard Python module optparse to parse command line option of this tool.
-#
-# @param  Source             The source file type.
-# @param  Destinate          The destinate file type.
-#
-# @retval Options            A optparse object containing the parsed options.
-# @retval InputFile          Path of an source file to be migrated.
-#
-def MigrationOptionParser(Source, Destinate, ToolName, VersionNumber=1.0):
-    # use clearer usage to override default usage message
-    UsageString = "%s [-a] [-v|-q] [-o <output_file>] <input_file>" % ToolName
-    Version = "%s Version %.2f" % (ToolName, VersionNumber)
-    Copyright = "Copyright (c) 2007, Intel Corporation. All rights reserved."
-    
-    Parser = OptionParser(description=Copyright, version=Version, usage=UsageString)
-    Parser.add_option("-o", "--output", dest="OutputFile", help="The name of the %s file to be created." % Destinate)
-    Parser.add_option("-a", "--auto", dest="AutoWrite", action="store_true", default=False, help="Automatically create the %s file using the name of the %s file and replacing file extension" % (Source, Destinate))
-    Parser.add_option("-q", "--quiet", action="store_true", type=None, help="Disable all messages except FATAL ERRORS.")
-    Parser.add_option("-v", "--verbose", action="store_true", type=None, help="Turn on verbose output with informational messages printed.")
-
-    Options, Args = Parser.parse_args()
-
-    # Set logging level
-    if Options.verbose:
-        EdkLogger.setLevel(EdkLogger.VERBOSE)
-    elif Options.quiet:
-        EdkLogger.setLevel(EdkLogger.QUIET)
-    else:
-        EdkLogger.setLevel(EdkLogger.INFO)
-        
-    # error check
-    if len(Args) == 0:
-        raise MigrationError(PARAMETER_MISSING, name="Input file", usage=Parser.get_usage())
-    if len(Args) > 1:
-        raise MigrationError(PARAMETER_INVALID, name="Too many input files", usage=Parser.get_usage())
-
-    InputFile = Args[0]
-    if not os.path.exists(InputFile):
-        raise MigrationError(FILE_NOT_FOUND, name=InputFile)
-
-    if Options.OutputFile:
-        if Options.AutoWrite:
-            raise MigrationError(OPTION_CONFLICT, arg1="-o", arg2="-a", usage=Parser.get_usage())
-    else:
-        if Options.AutoWrite:
-            Options.OutputFile = os.path.splitext(InputFile)[0] + "." + Destinate.lower()
-        else:
-            raise MigrationError(OPTION_MISSING, name="-o", usage=Parser.get_usage())
-
-    return Options, InputFile
-
-# This acts like the main() function for the script, unless it is 'import'ed -# into another script.
-if __name__ == '__main__':
-    pass
diff --git a/BaseTools/Source/Python/Makefile b/BaseTools/Source/Python/Makefile
index a51207d3d831..7652d2b80901 100644
--- a/BaseTools/Source/Python/Makefile
+++ b/BaseTools/Source/Python/Makefile
@@ -45,7 +45,6 @@ COMMON_PYTHON=$(BASE_TOOLS_PATH)\Source\Python\Common\BuildToolError.py \
               $(BASE_TOOLS_PATH)\Source\Python\Common\LongFilePathOs.py \
               $(BASE_TOOLS_PATH)\Source\Python\Common\LongFilePathOsPath.py \
               $(BASE_TOOLS_PATH)\Source\Python\Common\LongFilePathSupport.py \
-              $(BASE_TOOLS_PATH)\Source\Python\Common\MigrationUtilities.py \
               $(BASE_TOOLS_PATH)\Source\Python\Common\Misc.py \
               $(BASE_TOOLS_PATH)\Source\Python\Common\Parsing.py \
               $(BASE_TOOLS_PATH)\Source\Python\Common\String.py \
--
2.16.2.windows.1



  reply	other threads:[~2018-05-02  6:49 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 15:51 [PATCH v1 00/27] BaseTools refactoring Jaben Carsey
2018-04-20 15:51 ` [PATCH v1 01/27] BaseTools: Misc - refactor RegEx to minimize multiple compiling Jaben Carsey
2018-04-25  8:49   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 02/27] BaseTools: GenPatchPcdTable " Jaben Carsey
2018-04-25  8:50   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 03/27] BaseTools: Share RegEx between files Jaben Carsey
2018-04-25  8:51   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 04/27] BaseTools: Workspace - refactor RegEx to minimize multiple compiling Jaben Carsey
2018-04-25  8:50   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 05/27] BaseTools: Autogen - replace string constants with those from DataType Jaben Carsey
2018-04-25  8:50   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 06/27] BaseTools: simplify if call Jaben Carsey
2018-04-25  8:50   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 07/27] BaseTools: Workspace - refactor GetStructurePcdInfo Jaben Carsey
2018-04-25  8:50   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 08/27] BaseTools: AutoGen - remove dictionary populated, but never accessed Jaben Carsey
2018-04-25  8:50   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 09/27] BaseTools: AutoGen - remove unused variables Jaben Carsey
2018-04-25  8:52   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 10/27] BaseTools: Remove extra .keys() Jaben Carsey
2018-04-25  8:51   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 11/27] BaseTools: Workspace/MetaFileParser - refactor dicts Jaben Carsey
2018-04-20 15:51 ` [PATCH v1 12/27] BaseTools: remove dict from DscBuildData Jaben Carsey
2018-04-25  8:50   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 13/27] BaseTools: replace string constants used for module types Jaben Carsey
2018-04-25  5:57   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 14/27] BaseTools: Define and use a set for common list Jaben Carsey
2018-05-02  6:48   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 15/27] BaseTools: Share a dictionary instead of keeping multiples Jaben Carsey
2018-04-20 15:51 ` [PATCH v1 16/27] BaseTools: Replace EDK Component strings with predefined constant Jaben Carsey
2018-04-24  7:42   ` Zhu, Yonghong
2018-04-24 14:13     ` Carsey, Jaben
2018-04-20 15:51 ` [PATCH v1 17/27] BaseTools: DataType - cleanup list constants Jaben Carsey
2018-05-04 11:14   ` Laszlo Ersek
2018-05-04 14:18     ` Carsey, Jaben
2018-05-04 15:03       ` Laszlo Ersek
2018-04-20 15:51 ` [PATCH v1 18/27] BaseTools: Replace PCD type strings with predefined constant Jaben Carsey
2018-04-25  6:00   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 19/27] BaseTools: Replace Binary File " Jaben Carsey
2018-04-24  7:38   ` Zhu, Yonghong
2018-04-24 14:12     ` Carsey, Jaben
2018-04-20 15:51 ` [PATCH v1 20/27] BaseTools: remove duplicate variable Jaben Carsey
2018-04-25  8:51   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 21/27] BaseTools: replace string with predefined constant Jaben Carsey
2018-04-25  6:04   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 22/27] BaseTools: remove redundant if comparison Jaben Carsey
2018-05-02  6:49   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 23/27] BaseTools: AutoGen - use dafultdict instead of dict Jaben Carsey
2018-04-20 15:51 ` [PATCH v1 24/27] BaseTools: GenFds - simplify testing for Hex number Jaben Carsey
2018-04-25  8:51   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 25/27] BaseTools: AutoGen - use defaultdict to auto initialize Jaben Carsey
2018-04-25  8:52   ` Zhu, Yonghong
2018-04-20 15:51 ` [PATCH v1 26/27] BaseTools: remove unused MigrationUtilities.py Jaben Carsey
2018-05-02  6:49   ` Zhu, Yonghong [this message]
2018-04-20 15:51 ` [PATCH v1 27/27] BaseTools: CommonClass - remove unused classes Jaben Carsey
2018-04-25  8:51   ` Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D52000891@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox