* [Patch] BaseTools: Retrieve /U and -U CC flags to structure PcdValueInit Makefile
@ 2018-05-04 5:28 Liming Gao
2018-05-04 5:40 ` Zhu, Yonghong
0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2018-05-04 5:28 UTC (permalink / raw)
To: edk2-devel
/D and -D flags have been added. So, /U and -U flags should be added.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 7e3187f..38a0acb 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -2075,11 +2075,11 @@ class DscBuildData(PlatformBuildClassObject):
ValueList = Value.split()
if ValueList:
for Id, Item in enumerate(ValueList):
- if Item == '-D' or Item == '/D':
+ if Item in ['-D', '/D', '-U', '/U']:
CC_FLAGS += ' ' + Item
if Id + 1 < len(ValueList):
CC_FLAGS += ' ' + ValueList[Id + 1]
- elif Item.startswith('/D') or Item.startswith('-D'):
+ elif Item.startswith(('-D', '/D', '-U', '/U')):
CC_FLAGS += ' ' + Item
MakeApp += CC_FLAGS
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Retrieve /U and -U CC flags to structure PcdValueInit Makefile
2018-05-04 5:28 [Patch] BaseTools: Retrieve /U and -U CC flags to structure PcdValueInit Makefile Liming Gao
@ 2018-05-04 5:40 ` Zhu, Yonghong
0 siblings, 0 replies; 2+ messages in thread
From: Zhu, Yonghong @ 2018-05-04 5:40 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: Gao, Liming
Sent: Friday, May 04, 2018 1:28 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [Patch] BaseTools: Retrieve /U and -U CC flags to structure PcdValueInit Makefile
/D and -D flags have been added. So, /U and -U flags should be added.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 7e3187f..38a0acb 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -2075,11 +2075,11 @@ class DscBuildData(PlatformBuildClassObject):
ValueList = Value.split()
if ValueList:
for Id, Item in enumerate(ValueList):
- if Item == '-D' or Item == '/D':
+ if Item in ['-D', '/D', '-U', '/U']:
CC_FLAGS += ' ' + Item
if Id + 1 < len(ValueList):
CC_FLAGS += ' ' + ValueList[Id + 1]
- elif Item.startswith('/D') or Item.startswith('-D'):
+ elif Item.startswith(('-D', '/D', '-U', '/U')):
CC_FLAGS += ' ' + Item
MakeApp += CC_FLAGS
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-04 5:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-04 5:28 [Patch] BaseTools: Retrieve /U and -U CC flags to structure PcdValueInit Makefile Liming Gao
2018-05-04 5:40 ` Zhu, Yonghong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox