public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] FDF spec: Correct the example with SET statement in [FD] section
Date: Tue, 5 Jun 2018 05:36:45 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D520908F5@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1528104144-3496-1-git-send-email-liming.gao@intel.com>

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: Gao, Liming 
Sent: Monday, June 04, 2018 5:22 PM
To: edk2-devel@lists.01.org
Cc: Sean Brogan <sean.brogan@microsoft.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [Patch] FDF spec: Correct the example with SET statement in [FD] section

Region base address needs to add FD base address as the final value.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
 2_fdf_design_discussion/24_[fd]_sections.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/2_fdf_design_discussion/24_[fd]_sections.md b/2_fdf_design_discussion/24_[fd]_sections.md
index d55b793..04053a0 100644
--- a/2_fdf_design_discussion/24_[fd]_sections.md
+++ b/2_fdf_design_discussion/24_[fd]_sections.md
@@ -212,7 +212,7 @@ gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress | gEfiMyTokenSpaceGuid.PcdFlashFv  FV = FvMain
 
 0x000000|0x0C0000
-SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000
+SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000 + 
+$(BaseAddress)
 SET gEfiMyTokenSpaceGuid.PcdFlashFvMainSize        = 0x0C0000
 FV = FvMain
 ```
--
2.8.0.windows.1



      reply	other threads:[~2018-06-05  5:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04  9:22 [Patch] FDF spec: Correct the example with SET statement in [FD] section Liming Gao
2018-06-05  5:36 ` Zhu, Yonghong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D520908F5@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox