From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B2912118D923 for ; Tue, 5 Jun 2018 05:36:28 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2018 05:36:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,478,1520924400"; d="scan'208";a="234798615" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 05 Jun 2018 05:36:27 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 5 Jun 2018 05:36:27 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 5 Jun 2018 05:36:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Tue, 5 Jun 2018 20:36:24 +0800 From: "Zhu, Yonghong" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Shaw, Kevin W" , "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [edk2] [Patch 1/5] Build Spec: Add !error statement support Thread-Index: AQHT+HpDunMEnrUJ8ESy1y98T0ngHaRQB74AgAGajdA= Date: Tue, 5 Jun 2018 12:36:24 +0000 Message-ID: References: <1527728184-1736-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 1/5] Build Spec: Add !error statement support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 12:36:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, Yes, build tool will return error code when build break. This is the docume= nt patch to add '!error' statement. Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Tuesday, June 05, 2018 4:06 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney= , Michael D Cc: Shaw, Kevin W ; Gao, Liming Subject: RE: [edk2] [Patch 1/5] Build Spec: Add !error statement support Yonghong, I think it should be stated that the build tool also returns an error code.= This allows scripts that invoke build to check the returned error code. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Yonghong Zhu > Sent: Wednesday, May 30, 2018 5:56 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Shaw, Kevin W=20 > ; Gao, Liming > Subject: [edk2] [Patch 1/5] Build Spec: Add !error statement support >=20 > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > 8_pre-build_autogen_stage/82_auto-generation_process.md > | 6 ++++++ > README.md > | 3 ++- > 2 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/8_pre-build_autogen_stage/82_auto- > generation_process.md b/8_pre- > build_autogen_stage/82_auto-generation_process.md > index 8f8f29b..abfa55c 100644 > --- a/8_pre-build_autogen_stage/82_auto- > generation_process.md > +++ b/8_pre-build_autogen_stage/82_auto- > generation_process.md > @@ -1058,10 +1058,16 @@ hash value file into the directory specified=20 > by binary-destination at the build When --hash and --binary-source=20 > are specified, build tool will try to get the binary files from the=20 > binary source directory at the build phase. If the cached binary has =20 > the same hash value, it will be directly used. > Otherwise, build tool will compile the source files and generate the=20 > binary files. >=20 > +#### 8.2.4.16 !error Statement > + > +The DSC and FDF file can use `!error` statement. The > argument of this statement is an > +error message, it causes build tool to stop at the > location where the statement is > +encountered and error message following the `!error` > statement is output as a message. > + > ### 8.2.5 Post processing >=20 > Once all files are parsed, the build tools will do following work for=20 > each EDK II module: >=20 > diff --git a/README.md b/README.md > index 18e46c9..9ca8733 100644 > --- a/README.md > +++ b/README.md > @@ -223,6 +223,7 @@ Copyright (c) 2008-2017, Intel Corporation. All=20 > rights reserved. > | | > [#775](https://bugzilla.tianocore.org/show_bug.cgi?id=3D77 > 5) Build spec: Add description about auto detect thread number > | | > | | Add Flexible PCD value format into spec > | | > | | Update PCD value and SKU, DefaultStore > info in build report > | | > | | Clarify structure PCD field value > assignment precedence > | | > | | Update description for build handles > PCDs for SKU support > | | > -| | Add statement about module scoped > `` section override scope > | | > +| | Add statement about module scoped > `` section override scope > | | > +| | Add !error statement section > | | > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel