Re: [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks

["Zhu, Yonghong" <yonghong.zhu@intel.com>]

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: Kinney, Michael D 
Sent: Saturday, June 09, 2018 2:15 PM
To: edk2-devel@lists.01.org
Cc: Sun, Yanyan <yanyan.sun@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks

https://bugzilla.tianocore.org/show_bug.cgi?id=962
https://bugzilla.tianocore.org/show_bug.cgi?id=963
https://bugzilla.tianocore.org/show_bug.cgi?id=974
https://bugzilla.tianocore.org/show_bug.cgi?id=965

* Change "PcdToBin" to "BinToPcd"
* Update error message for --type HII.  If either --variable-guid
  or --variable-name is missing, then print an error message that
  states that both --variable-guid and --variable-name are required.
* --offset must be 8-byte aligned.
* Compatible with both Python 2.x and Python 3.x.
* Return error code when error message printed.
* Follow PEP-8 indent of 4 spaces.  https://www.python.org/dev/peps/pep-0008/

Cc: Yanyan Sun <yanyan.sun@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1

Kinney, Michael D (5):
  BaseTools/BinToPcd: Fix typo in error messages
  BaseTools/BinToPcd: Clarify error message for --type HII
  BaseTools/BinToPcd: --offset must be 8-byte aligned
  BaseTools/BinToPcd: Update for Python 3 compatibility
  BaseTools/BinToPcd: Follow PEP-8 indent of 4 spaces

 BaseTools/Scripts/BinToPcd.py | 350 +++++++++++++++++++++---------------------
 1 file changed, 179 insertions(+), 171 deletions(-)

-- 
2.14.2.windows.3