From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB6A321128718 for ; Mon, 11 Jun 2018 17:40:58 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2018 17:40:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,212,1526367600"; d="scan'208";a="46378473" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 11 Jun 2018 17:40:58 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Jun 2018 17:40:58 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.70]) with mapi id 14.03.0319.002; Tue, 12 Jun 2018 08:40:56 +0800 From: "Zhu, Yonghong" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Sun, Yanyan" , "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks Thread-Index: AQHT/7lAS9q/6EgcoESwXjk10/5KwKRbzHvQ Date: Tue, 12 Jun 2018 00:40:56 +0000 Message-ID: References: <20180609061505.14380-1-michael.d.kinney@intel.com> In-Reply-To: <20180609061505.14380-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 00:40:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Saturday, June 09, 2018 2:15 PM To: edk2-devel@lists.01.org Cc: Sun, Yanyan ; Zhu, Yonghong ; Gao, Liming ; Kinney, Michael D Subject: [Patch 0/5] BaseTools/BinToPcd: Multiple clean up tasks https://bugzilla.tianocore.org/show_bug.cgi?id=3D962 https://bugzilla.tianocore.org/show_bug.cgi?id=3D963 https://bugzilla.tianocore.org/show_bug.cgi?id=3D974 https://bugzilla.tianocore.org/show_bug.cgi?id=3D965 * Change "PcdToBin" to "BinToPcd" * Update error message for --type HII. If either --variable-guid or --variable-name is missing, then print an error message that states that both --variable-guid and --variable-name are required. * --offset must be 8-byte aligned. * Compatible with both Python 2.x and Python 3.x. * Return error code when error message printed. * Follow PEP-8 indent of 4 spaces. https://www.python.org/dev/peps/pep-000= 8/ Cc: Yanyan Sun Cc: Yonghong Zhu Cc: Liming Gao Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Kinney, Michael D (5): BaseTools/BinToPcd: Fix typo in error messages BaseTools/BinToPcd: Clarify error message for --type HII BaseTools/BinToPcd: --offset must be 8-byte aligned BaseTools/BinToPcd: Update for Python 3 compatibility BaseTools/BinToPcd: Follow PEP-8 indent of 4 spaces BaseTools/Scripts/BinToPcd.py | 350 +++++++++++++++++++++-----------------= ---- 1 file changed, 179 insertions(+), 171 deletions(-) --=20 2.14.2.windows.3