From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v1 0/2] BaseTools: cleanup for speed
Date: Tue, 12 Jun 2018 06:43:10 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D52094AEB@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1526601941.git.jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Friday, May 18, 2018 8:07 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v1 0/2] BaseTools: cleanup for speed
the first patch merges 2 almost identical functions by moving optional output to the WorkspaceCommon version and then calls it from AutoGen.
the second patch is lots of small cleanups.
Jaben Carsey (2):
BaseTools: refactor to remove functions
BaseTools: Cleanup unneeded code
BaseTools/Source/Python/AutoGen/AutoGen.py | 500 +++++++-------------
BaseTools/Source/Python/AutoGen/GenC.py | 2 +-
BaseTools/Source/Python/AutoGen/GenMake.py | 4 +-
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 14 +-
BaseTools/Source/Python/AutoGen/GenVar.py | 2 +-
BaseTools/Source/Python/AutoGen/StrGather.py | 8 +-
BaseTools/Source/Python/Common/Misc.py | 2 +-
BaseTools/Source/Python/Common/String.py | 2 +-
BaseTools/Source/Python/Common/VpdInfoFile.py | 2 +-
BaseTools/Source/Python/GenFds/FdfParser.py | 8 +-
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 119 +++--
BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 52 +-
BaseTools/Source/Python/build/BuildReport.py | 26 +-
BaseTools/Source/Python/build/build.py | 6 +-
14 files changed, 291 insertions(+), 456 deletions(-)
--
2.16.2.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-06-12 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 0:06 [PATCH v1 0/2] BaseTools: cleanup for speed Jaben Carsey
2018-05-18 0:06 ` [PATCH v1 1/2] BaseTools: refactor to remove functions Jaben Carsey
2018-05-18 0:06 ` [PATCH v1 2/2] BaseTools: Cleanup unneeded code Jaben Carsey
2018-06-12 6:43 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D52094AEB@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox