From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: Michael Zimmermann <sigmaepsilon92@gmail.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: unknown section type handling in ElfConvert
Date: Fri, 22 Jun 2018 06:05:01 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D5209AE9F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <CAN9vWDL+ZQfn1a1Cisx0u9-R2qUqnQa2TbbEZw+jCa2Y1eYF-Q@mail.gmail.com>
Hi Michael,
We can update the VerboseMsg to same with the comment. We don't want to copy the unknown section.
Best Regards,
Zhu Yonghong
-----Original Message-----
From: Michael Zimmermann [mailto:sigmaepsilon92@gmail.com]
Sent: Friday, June 08, 2018 11:46 PM
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2] unknown section type handling in ElfConvert
ElfConvert iterates over the section headers and handles the following section types:
SHT_PROGBITS: Copy
SHT_NOBITS: memset to 0
the default case looks like this:
//
// Ignore for unkown section type.
//
VerboseMsg ("%s unknown section type %x. We directly copy this section into Coff file", mInImageName, (unsigned)Shdr->sh_type);
The comment kinda conflicts with the debug message. Is not copying unknown sections a bug?
I guess this could lead to problems if a module would ever rely on non-standard sections being available.
Thanks
Michael
prev parent reply other threads:[~2018-06-22 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 15:45 unknown section type handling in ElfConvert Michael Zimmermann
2018-06-22 6:05 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D5209AE9F@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox