From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6FD9B210D93DA for ; Fri, 22 Jun 2018 01:53:08 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jun 2018 01:53:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,256,1526367600"; d="scan'208";a="210231838" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 22 Jun 2018 01:53:07 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 22 Jun 2018 01:53:07 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 22 Jun 2018 01:53:06 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Fri, 22 Jun 2018 16:53:04 +0800 From: "Zhu, Yonghong" To: Gary Lin CC: "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions Thread-Index: AQHUCRqL/gFbxeh/EUaRJfTj+Ai0+aRqph8wgABcJ4CAAJSk8P//1MeAgAAGxYCAAIe0kA== Date: Fri, 22 Jun 2018 08:53:04 +0000 Message-ID: References: <20180621044346.28495-1-glin@suse.com> <20180621044346.28495-6-glin@suse.com> <20180622020405.qyazporzykhww7u7@GaryWorkstation> <20180622082122.bj6rpjgfcbsbeohf@GaryWorkstation> <20180622084537.5c262wd2fnafmpil@GaryWorkstation> In-Reply-To: <20180622084537.5c262wd2fnafmpil@GaryWorkstation> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDU0NjJmMmQtYWEwNi00NmYxLWFjZTItMmVlZWMyZGY2MDMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic1V6MTJWRk5XSENDVDBIUVJWckQ1bUZUQVpHMkxzMlFNSWJtd0xtNThFdkhyR2Q5MDBTMjA1NXJlKzIwOTFBTSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 05/20] BaseTools: Use the python3-range functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 08:53:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gary, My test env is Windows. I applied Patch 16, and seems this patch only for L= inux. Best Regards, Zhu Yonghong -----Original Message----- From: Gary Lin [mailto:glin@suse.com]=20 Sent: Friday, June 22, 2018 4:46 PM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range funct= ions On Fri, Jun 22, 2018 at 04:21:23PM +0800, Gary Lin wrote: > On Fri, Jun 22, 2018 at 05:29:21AM +0000, Zhu, Yonghong wrote: > > Hi Gary, > >=20 > > Patch 03 used some Tab characters, Patch 17 has some Trailing whitespac= e. You can use the BaseTools\Scripts\PatchCheck.py to check its format. > >=20 > Ok, will fix them in the next version. >=20 > > I try to build OVMF platform, it directly report error: > > from .BuildReport import BuildReport > > ValueError: Attempted relative import in non-package > >=20 > I didn't see this in my system. Will investigate what's wrong. >=20 Hi Yonghong, The error showed when I reverted patch 16. Would you mind to check whether = patch 16 was applied or not? Thanks, Gary Lin > Thanks, >=20 > Gary Lin >=20 > > Best Regards, > > Zhu Yonghong > >=20 > > -----Original Message----- > > From: Gary Lin [mailto:glin@suse.com] > > Sent: Friday, June 22, 2018 10:04 AM > > To: Zhu, Yonghong > > Cc: edk2-devel@lists.01.org; Gao, Liming > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the=20 > > python3-range functions > >=20 > > On Thu, Jun 21, 2018 at 12:40:29PM +0000, Zhu, Yonghong wrote: > > > Hi Gary, > > >=20 > > > Python 2.7 doesn't have the module builtins, if we apply this patch n= ow, it will cause build failure on Python 2.7. > > >=20 > > Urhh, I thought it's a "built-in" module but it's actually from=20 > > python-future. > >=20 > > I'll revert this patch and post a new patchset. > > BTW, would you might review the first patch? It's just a typo fix=20 > > and I just caught it while running the futurize script, so the patch=20 > > is actually independent from this patch series. > >=20 > > Thanks, > >=20 > > Gary Lin > >=20 > > > Best Regards, > > > Zhu Yonghong > > >=20 > > >=20 > > > -----Original Message----- > > > From: Gary Lin [mailto:glin@suse.com] > > > Sent: Thursday, June 21, 2018 12:44 PM > > > To: edk2-devel@lists.01.org > > > Cc: Zhu, Yonghong ; Gao, Liming=20 > > > > > > Subject: [PATCH v3 05/20] BaseTools: Use the python3-range=20 > > > functions > > >=20 > > > Replace xrange() and range() with the newer range() function Based on= "futurize -f libfuturize.fixes.fix_xrange_with_import" > > >=20 > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Cc: Yonghong Zhu > > > Cc: Liming Gao > > > Signed-off-by: Gary Lin