From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D82D203BBB80 for ; Sun, 24 Jun 2018 22:58:45 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jun 2018 22:58:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,269,1526367600"; d="scan'208";a="49635941" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 24 Jun 2018 22:58:45 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Jun 2018 22:58:44 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Mon, 25 Jun 2018 13:58:42 +0800 From: "Zhu, Yonghong" To: Gary Lin CC: "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions Thread-Index: AQHUCRqL/gFbxeh/EUaRJfTj+Ai0+aRqph8wgABcJ4CAAJSk8P//1MeAgAAGxYCAAIe0kP//gA6AgACH3tCAAAEuAP//gLeAABHr7nAAd+i5AAAVw5iQ Date: Mon, 25 Jun 2018 05:58:42 +0000 Message-ID: References: <20180622020405.qyazporzykhww7u7@GaryWorkstation> <20180622082122.bj6rpjgfcbsbeohf@GaryWorkstation> <20180622084537.5c262wd2fnafmpil@GaryWorkstation> <20180622091323.h5tcdy32wx5yjmmv@GaryWorkstation> <20180622094819.bzzqyvfoqrhdazxo@GaryWorkstation> <20180625033450.kmwulo4mjtwasttk@GaryWorkstation> In-Reply-To: <20180625033450.kmwulo4mjtwasttk@GaryWorkstation> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 05/20] BaseTools: Use the python3-range functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 05:58:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable You're correct, it is Patch 13 cause the 'long' type issue. Best Regards, Zhu Yonghong -----Original Message----- From: Gary Lin [mailto:glin@suse.com]=20 Sent: Monday, June 25, 2018 11:35 AM To: Zhu, Yonghong Cc: edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range funct= ions On Fri, Jun 22, 2018 at 10:22:10AM +0000, Zhu, Yonghong wrote: > No. I tried to only patch 1 to 15, it still report this failure. >=20 One possible patch may be patch 13, because the error is about long type, a= nd patch 13 converts 'long' to 'int'. Since I couldn't reproduce the error, would you mind to bisect through patc= h 1~13 if reverting patch 13 doesn't work? Thanks, Gary Lin > Best Regards, > Zhu Yonghong >=20 >=20 > -----Original Message----- > From: Gary Lin [mailto:glin@suse.com] > Sent: Friday, June 22, 2018 5:48 PM > To: Zhu, Yonghong > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range=20 > functions >=20 > On Fri, Jun 22, 2018 at 09:24:44AM +0000, Zhu, Yonghong wrote: > > Any comment on which patch may cause this issue ? I revert all the 20 p= atches, OVMF could build PASS. > >=20 > I wonder if reverting patch 16~20 helps or not. Changing to absolute impo= rt may be not as safe as I thought. >=20 > Thanks, >=20 > Gary Lin >=20 > > Best Regards, > > Zhu Yonghong > >=20 > >=20 > > -----Original Message----- > > From: Zhu, Yonghong > > Sent: Friday, June 22, 2018 5:22 PM > > To: 'Gary Lin' > > Cc: edk2-devel@lists.01.org; Gao, Liming ;=20 > > Zhu, Yonghong > > Subject: RE: [edk2] [PATCH v3 05/20] BaseTools: Use the=20 > > python3-range functions > >=20 > > Yes, after modify build.bat and GenFds.bat, I can avoid the previous er= ror, but a new error: > >=20 > > build.py... > > d:\git\edk2_new\OvmfPkg\OvmfPkg.fdf.inc(83): error 3000: Invalid syntax= /format > > near line 83, column 0: SET=20 > > gUefiOvmfPkgTokenSpaceGuid.Pcd OvmfFlashNvStorageEventLogBase =3D=20 > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorag > > eVariableBase + > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > >=20 > > Best Regards, > > Zhu Yonghong > >=20 > >=20 > > -----Original Message----- > > From: Gary Lin [mailto:glin@suse.com] > > Sent: Friday, June 22, 2018 5:13 PM > > To: Zhu, Yonghong > > Cc: edk2-devel@lists.01.org; Gao, Liming > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the=20 > > python3-range functions > >=20 > > On Fri, Jun 22, 2018 at 08:53:04AM +0000, Zhu, Yonghong wrote: > > > Hi Gary, > > >=20 > > > My test env is Windows. I applied Patch 16, and seems this patch only= for Linux. > > >=20 > > Ah, right. The patch is Linux only, and sadly I only have Linux. > > I guess the similar change may work for windows. > >=20 > > Could you try to modify build.bat and GenFds.bat in BaseTools\BinWrappe= rs\WindowsLike\ as the following? > >=20 > > @setlocal > > @set ToolName=3D%~n0% > > @set PYTHONPATH=3D%PYTHONPATH%;%BASE_TOOLS_PATH%\Source\Python > > @%PYTHON_HOME%\python.exe -m %ToolName%.%ToolName% %* > >=20 > > I'm not sure whether it should be '-m' or '/m' though. The goal is trea= t build and GenFds as modules to avoid the error you saw. > >=20 > > Thanks, > >=20 > > Gary Lin > >=20 > > > Best Regards, > > > Zhu Yonghong > > >=20 > > >=20 > > > -----Original Message----- > > > From: Gary Lin [mailto:glin@suse.com] > > > Sent: Friday, June 22, 2018 4:46 PM > > > To: Zhu, Yonghong > > > Cc: edk2-devel@lists.01.org; Gao, Liming > > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the=20 > > > python3-range functions > > >=20 > > > On Fri, Jun 22, 2018 at 04:21:23PM +0800, Gary Lin wrote: > > > > On Fri, Jun 22, 2018 at 05:29:21AM +0000, Zhu, Yonghong wrote: > > > > > Hi Gary, > > > > >=20 > > > > > Patch 03 used some Tab characters, Patch 17 has some Trailing whi= tespace. You can use the BaseTools\Scripts\PatchCheck.py to check its forma= t. > > > > >=20 > > > > Ok, will fix them in the next version. > > > >=20 > > > > > I try to build OVMF platform, it directly report error: > > > > > from .BuildReport import BuildReport > > > > > ValueError: Attempted relative import in non-package > > > > >=20 > > > > I didn't see this in my system. Will investigate what's wrong. > > > >=20 > > > Hi Yonghong, > > >=20 > > > The error showed when I reverted patch 16. Would you mind to check wh= ether patch 16 was applied or not? > > >=20 > > > Thanks, > > >=20 > > > Gary Lin > > >=20 > > > > Thanks, > > > >=20 > > > > Gary Lin > > > >=20 > > > > > Best Regards, > > > > > Zhu Yonghong > > > > >=20 > > > > > -----Original Message----- > > > > > From: Gary Lin [mailto:glin@suse.com] > > > > > Sent: Friday, June 22, 2018 10:04 AM > > > > > To: Zhu, Yonghong > > > > > Cc: edk2-devel@lists.01.org; Gao, Liming=20 > > > > > > > > > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the=20 > > > > > python3-range functions > > > > >=20 > > > > > On Thu, Jun 21, 2018 at 12:40:29PM +0000, Zhu, Yonghong wrote: > > > > > > Hi Gary, > > > > > >=20 > > > > > > Python 2.7 doesn't have the module builtins, if we apply this p= atch now, it will cause build failure on Python 2.7. > > > > > >=20 > > > > > Urhh, I thought it's a "built-in" module but it's actually=20 > > > > > from python-future. > > > > >=20 > > > > > I'll revert this patch and post a new patchset. > > > > > BTW, would you might review the first patch? It's just a typo=20 > > > > > fix and I just caught it while running the futurize script, so=20 > > > > > the patch is actually independent from this patch series. > > > > >=20 > > > > > Thanks, > > > > >=20 > > > > > Gary Lin > > > > >=20 > > > > > > Best Regards, > > > > > > Zhu Yonghong > > > > > >=20 > > > > > >=20 > > > > > > -----Original Message----- > > > > > > From: Gary Lin [mailto:glin@suse.com] > > > > > > Sent: Thursday, June 21, 2018 12:44 PM > > > > > > To: edk2-devel@lists.01.org > > > > > > Cc: Zhu, Yonghong ; Gao, Liming=20 > > > > > > > > > > > > Subject: [PATCH v3 05/20] BaseTools: Use the python3-range=20 > > > > > > functions > > > > > >=20 > > > > > > Replace xrange() and range() with the newer range() function Ba= sed on "futurize -f libfuturize.fixes.fix_xrange_with_import" > > > > > >=20 > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > Cc: Yonghong Zhu > > > > > > Cc: Liming Gao > > > > > > Signed-off-by: Gary Lin > > >=20 > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >=20