From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1381A2111FE43 for ; Wed, 5 Sep 2018 18:02:15 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2018 18:02:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,334,1531810800"; d="scan'208";a="68724193" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 05 Sep 2018 18:02:13 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 5 Sep 2018 18:02:12 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 5 Sep 2018 18:02:12 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Thu, 6 Sep 2018 09:02:10 +0800 From: "Zhu, Yonghong" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [PATCH v1 1/1] BaseTools/GenFds: remove function without callers Thread-Index: AQHURWfFSNTDKhxsVkKybJJn5TUS+aTib49A Date: Thu, 6 Sep 2018 01:02:09 +0000 Message-ID: References: <707987ff44e2cf6fb7d6e077b0c5e811ad243792.1536186330.git.jaben.carsey@intel.com> In-Reply-To: <707987ff44e2cf6fb7d6e077b0c5e811ad243792.1536186330.git.jaben.carsey@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 1/1] BaseTools/GenFds: remove function without callers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 01:02:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Carsey, Jaben=20 Sent: Thursday, September 06, 2018 6:26 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 1/1] BaseTools/GenFds: remove function without callers Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 17 --------------= --- 1 file changed, 17 deletions(-) diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py b/BaseT= ools/Source/Python/GenFds/GenFdsGlobalVariable.py index eb106b574420..d859a905eb84 100644 --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py @@ -591,23 +591,6 @@ class GenFdsGlobalVariable: =20 GenFdsGlobalVariable.CallExternalTool(Cmd, "Failed to generate FV"= ) =20 - @staticmethod - def GenerateVtf(Output, Input, BaseAddress=3DNone, FvSize=3DNone): - if not GenFdsGlobalVariable.NeedsUpdate(Output, Input): - return - GenFdsGlobalVariable.DebugLogger(EdkLogger.DEBUG_5, "%s needs upda= te because of newer %s" % (Output, Input)) - - Cmd =3D ["GenVtf"] - if BaseAddress and FvSize \ - and len(BaseAddress) =3D=3D len(FvSize): - for I in range(0, len(BaseAddress)): - Cmd +=3D ("-r", BaseAddress[I], "-s", FvSize[I]) - Cmd +=3D ("-o", Output) - for F in Input: - Cmd +=3D ("-f", F) - - GenFdsGlobalVariable.CallExternalTool(Cmd, "Failed to generate VTF= ") - @staticmethod def GenerateFirmwareImage(Output, Input, Type=3D"efi", SubType=3DNone,= Zero=3DFalse, Strip=3DFalse, Replace=3DFalse, TimeStamp=3D= None, Join=3DFalse, --=20 2.16.2.windows.1