* [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code @ 2018-09-25 1:36 Liming Gao 2018-09-25 6:22 ` Zhu, Yonghong 0 siblings, 1 reply; 3+ messages in thread From: Liming Gao @ 2018-09-25 1:36 UTC (permalink / raw) To: edk2-devel; +Cc: Yonghong Zhu, Jaben Carsey DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). The consumer code should refer to SkuIds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Yonghong Zhu <yonghong.zhu@intel.com> Cc: Jaben Carsey <jaben.carsey@intel.com> --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 5271b44..38f1260 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen): VpdRegionBase = FdRegion.Offset break - VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj._GetSkuIds()) + VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj.SkuIds) VariableInfo.SetVpdRegionMaxSize(VpdRegionSize) VariableInfo.SetVpdRegionOffset(VpdRegionBase) Index = 0 -- 2.10.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code 2018-09-25 1:36 [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code Liming Gao @ 2018-09-25 6:22 ` Zhu, Yonghong 2018-09-25 14:48 ` Carsey, Jaben 0 siblings, 1 reply; 3+ messages in thread From: Zhu, Yonghong @ 2018-09-25 6:22 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Carsey, Jaben, Zhu, Yonghong Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> Best Regards, Zhu Yonghong -----Original Message----- From: Gao, Liming Sent: Tuesday, September 25, 2018 9:36 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Carsey, Jaben <jaben.carsey@intel.com> Subject: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). The consumer code should refer to SkuIds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Yonghong Zhu <yonghong.zhu@intel.com> Cc: Jaben Carsey <jaben.carsey@intel.com> --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 5271b44..38f1260 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen): VpdRegionBase = FdRegion.Offset break - VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj._GetSkuIds()) + VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), self.DscBuildDataObj.SkuIds) VariableInfo.SetVpdRegionMaxSize(VpdRegionSize) VariableInfo.SetVpdRegionOffset(VpdRegionBase) Index = 0 -- 2.10.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code 2018-09-25 6:22 ` Zhu, Yonghong @ 2018-09-25 14:48 ` Carsey, Jaben 0 siblings, 0 replies; 3+ messages in thread From: Carsey, Jaben @ 2018-09-25 14:48 UTC (permalink / raw) To: Zhu, Yonghong, Gao, Liming, edk2-devel@lists.01.org Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> > -----Original Message----- > From: Zhu, Yonghong > Sent: Monday, September 24, 2018 11:23 PM > To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Zhu, Yonghong > <yonghong.zhu@intel.com> > Subject: RE: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in > AutoGen code > Importance: High > > Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> > > Best Regards, > Zhu Yonghong > > > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, September 25, 2018 9:36 AM > To: edk2-devel@lists.01.org > Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Carsey, Jaben > <jaben.carsey@intel.com> > Subject: [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in > AutoGen code > > DscBuildData has been updated to define SkuIds instead of _GetSkuIds(). > The consumer code should refer to SkuIds. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Yonghong Zhu <yonghong.zhu@intel.com> > Cc: Jaben Carsey <jaben.carsey@intel.com> > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index 5271b44..38f1260 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -1153,7 +1153,7 @@ class PlatformAutoGen(AutoGen): > VpdRegionBase = FdRegion.Offset > break > > - VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), > self.DscBuildDataObj._GetSkuIds()) > + VariableInfo = VariableMgr(self.DscBuildDataObj._GetDefaultStores(), > self.DscBuildDataObj.SkuIds) > VariableInfo.SetVpdRegionMaxSize(VpdRegionSize) > VariableInfo.SetVpdRegionOffset(VpdRegionBase) > Index = 0 > -- > 2.10.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-25 14:48 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-09-25 1:36 [Patch] BaseTools: Fix the wrong reference _GetSkuIds() in AutoGen code Liming Gao 2018-09-25 6:22 ` Zhu, Yonghong 2018-09-25 14:48 ` Carsey, Jaben
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox