public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Marvin.Haeuser@outlook.com" <Marvin.Haeuser@outlook.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file.
Date: Fri, 19 Oct 2018 00:30:10 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D5214322E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <VI1PR0801MB1790394490CCBB4C9F39E4F680FD0@VI1PR0801MB1790.eurprd08.prod.outlook.com>

Hi Marvin Häuser,

Liming sent some mail to notice that we drop the support of BaseTools Python run from the freeze binary in Windows OS, and he also sent patch to remove the steps to freeze python tool. So I don't think we need this patch now, please check it. Thanks.

https://lists.01.org/pipermail/edk2-devel/2018-September/029436.html 
 https://lists.01.org/pipermail/edk2-devel/2018-October/030969.html 
https://lists.01.org/pipermail/edk2-devel/2018-October/030589.html 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com] 
Sent: Monday, October 15, 2018 11:33 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file.

GenFds/Attributes.py has been deleted in 1ad635b, but was not removed from the Python Makefile. Remove it for successful compilation on Windows.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
 BaseTools/Source/Python/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/BaseTools/Source/Python/Makefile b/BaseTools/Source/Python/Makefile
index ac99259eb18a..2a80f1cf7fe9 100644
--- a/BaseTools/Source/Python/Makefile
+++ b/BaseTools/Source/Python/Makefile
@@ -114,7 +114,6 @@ CMD_BUILD=$(BASE_TOOLS_PATH)\Source\Python\build\BuildReport.py \
     $(BASE_TOOLS_PATH)\Source\Python\Eot\Report.py
 
 CMD_GENFDS=$(BASE_TOOLS_PATH)\Source\Python\GenFds\AprioriSection.py \
-    $(BASE_TOOLS_PATH)\Source\Python\GenFds\Attribute.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\Capsule.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\CapsuleData.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\ComponentStatement.py \
--
2.19.1.windows.1



      reply	other threads:[~2018-10-19  0:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15  3:32 [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file Marvin Häuser
2018-10-19  0:30 ` Zhu, Yonghong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D5214322E@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox