From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA4A621164EF8 for ; Sun, 21 Oct 2018 04:50:21 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2018 04:50:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,408,1534834800"; d="scan'208";a="97183303" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 21 Oct 2018 04:50:21 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 Oct 2018 04:50:20 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 Oct 2018 04:50:19 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.224]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.46]) with mapi id 14.03.0319.002; Sun, 21 Oct 2018 19:50:17 +0800 From: "Zhu, Yonghong" To: "Feng, Bob C" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [edk2] [Patch] BaseTools: Fixed a key error code bug. Thread-Index: AQHUaTMm37qclpDU7k6odZEKSF59gqUplXUA Date: Sun, 21 Oct 2018 11:50:17 +0000 Message-ID: References: <20181021114201.19592-1-bob.c.feng@intel.com> In-Reply-To: <20181021114201.19592-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fixed a key error code bug. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2018 11:50:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bob, I fixed this issue by below patch, I will check in the patch soon. https://lists.01.org/pipermail/edk2-devel/2018-October/031161.html=20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of BobC= F Sent: Sunday, October 21, 2018 7:42 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: Fixed a key error code bug. There is a code bug that used a wrong key. This Patch is to correct it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/= Python/AutoGen/AutoGen.py index f2146a7790..87d6107035 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -567,12 +567,12 @@ class WorkspaceAutoGen(AutoGen): if (Name, Guid) not in DecPcds: EdkLogger.error( 'build', PARSER_ERROR, "PCD (%s.%s) used in FDF is not declared in DEC fi= les." % (Guid, Name), - File =3D self.FdfProfile.PcdFileLineDict[Name, Gui= d][0], - Line =3D self.FdfProfile.PcdFileLineDict[Name, Gui= d][1] + File =3D self.FdfProfile.PcdFileLineDict[Name, Gui= d,Fileds][0], + Line =3D self.FdfProfile.PcdFileLineDict[Name,=20 + Guid,Fileds][1] ) else: # Check whether Dynamic or DynamicEx PCD used in FDF f= ile. If used, build break and give a error message. if (Name, Guid, TAB_PCDS_FIXED_AT_BUILD) in DecPcdsKey= \ or (Name, Guid, TAB_PCDS_PATCHABLE_IN_MODULE) in D= ecPcdsKey \ @@ -581,12 +581,12 @@ class WorkspaceAutoGen(AutoGen): elif (Name, Guid, TAB_PCDS_DYNAMIC) in DecPcdsKey or (= Name, Guid, TAB_PCDS_DYNAMIC_EX) in DecPcdsKey: EdkLogger.error( 'build', PARSER_ERROR, "Using Dynamic or DynamicEx type of PCD [%= s.%s] in FDF file is not allowed." % (Guid, Name), - File =3D self.FdfProfile.PcdFileLineDict[N= ame, Guid][0], - Line =3D self.FdfProfile.PcdFileLineDict[N= ame, Guid][1] + File =3D self.FdfProfile.PcdFileLineDict[N= ame, Guid,Fileds][0], + Line =3D=20 + self.FdfProfile.PcdFileLineDict[Name, Guid,Fileds][1] ) =20 Pa =3D PlatformAutoGen(self, self.MetaFile, Target, Toolchain,= Arch) # # Explicitly collect platform's dynamic PCDs -- 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel