From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch v3 0/6] BaseTools/GenFds: cleanup GenFds
Date: Thu, 25 Oct 2018 11:55:01 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D52162864@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cover.1540315635.git.jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Wednesday, October 24, 2018 1:29 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch v3 0/6] BaseTools/GenFds: cleanup GenFds
Cleanup to many files for GenFds. No command line visible changes are included.
1) refactor imports to reduce namespace clutter.
2) refactor to use existing sharable objects (and create a few new)
3) eliminate shadowing of names
4) remove double underscored private methods for PEP8
5) eliminate unused code/parameters/variables
6) add standard warnings and use them for common code
changes from v1:
1) do not shadow CapsuleFV.
2) rebase on master
changes from v2:
1) do not delete duplicate function calls.
2) add ".lower()" for GUID string comparison.
3) rebase on master
Jaben Carsey (6):
BaseTools/GenFds: cleanup GenFds
BaseTools/GenFds: change objects to sets
Basetools/GenFds: refactor class FV
BaseTools/GenFds: remove MacroDict parameter
BaseTools/GenFds: refactor FdfParser warnings
BaseTools/GenFds: create and use new variable in FdfParser
BaseTools/Source/Python/CommonDataClass/FdfClass.py | 73 -
BaseTools/Source/Python/Eot/EotMain.py | 372 +-
BaseTools/Source/Python/GenFds/AprioriSection.py | 45 +-
BaseTools/Source/Python/GenFds/Capsule.py | 26 +-
BaseTools/Source/Python/GenFds/CapsuleData.py | 1 -
BaseTools/Source/Python/GenFds/CompressSection.py | 4 +-
BaseTools/Source/Python/GenFds/DataSection.py | 4 +-
BaseTools/Source/Python/GenFds/DepexSection.py | 5 +-
BaseTools/Source/Python/GenFds/EfiSection.py | 16 +-
BaseTools/Source/Python/GenFds/FdfParser.py | 3780 ++++++++++----------
BaseTools/Source/Python/GenFds/Ffs.py | 82 +-
BaseTools/Source/Python/GenFds/FfsFileStatement.py | 37 +-
BaseTools/Source/Python/GenFds/FfsInfStatement.py | 10 +-
BaseTools/Source/Python/GenFds/Fv.py | 54 +-
BaseTools/Source/Python/GenFds/FvImageSection.py | 6 +-
BaseTools/Source/Python/GenFds/GenFds.py | 160 +-
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 208 +-
BaseTools/Source/Python/GenFds/GuidSection.py | 4 +-
BaseTools/Source/Python/GenFds/OptionRom.py | 6 +-
BaseTools/Source/Python/GenFds/Region.py | 12 +-
BaseTools/Source/Python/GenFds/UiSection.py | 4 +-
BaseTools/Source/Python/GenFds/VerSection.py | 16 +-
BaseTools/Source/Python/GenFds/Vtf.py | 48 +-
BaseTools/Source/Python/build/BuildReport.py | 5 +-
24 files changed, 2576 insertions(+), 2402 deletions(-)
--
2.16.2.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-10-25 11:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 17:29 [Patch v3 0/6] BaseTools/GenFds: cleanup GenFds Jaben Carsey
2018-10-23 17:29 ` [Patch v3 1/6] " Jaben Carsey
2018-10-25 13:45 ` Feng, Bob C
2018-10-26 4:53 ` Gary Lin
2018-10-26 5:25 ` Gao, Liming
2018-10-26 6:27 ` Gao, Liming
2018-10-26 6:54 ` Gary Lin
2018-10-23 17:29 ` [Patch v3 2/6] BaseTools/GenFds: change objects to sets Jaben Carsey
2018-10-23 17:29 ` [Patch v3 3/6] Basetools/GenFds: refactor class FV Jaben Carsey
2018-10-23 17:29 ` [Patch v3 4/6] BaseTools/GenFds: remove MacroDict parameter Jaben Carsey
2018-10-23 17:29 ` [Patch v3 5/6] BaseTools/GenFds: refactor FdfParser warnings Jaben Carsey
2018-10-23 17:29 ` [Patch v3 6/6] BaseTools/GenFds: create and use new variable in FdfParser Jaben Carsey
2018-10-25 13:57 ` Feng, Bob C
2018-10-25 11:55 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D52162864@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox