From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [edk2-InfSpecification][PATCH v2] Amend the OptionROM specification to allow multiple PCI_DEVICE_IDs
Date: Mon, 29 Oct 2018 12:05:09 +0000 [thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D521659FC@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <ee37ec33-9b23-ace5-c9cf-701feabd36a5@solarflare.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Tomas Pilar (tpilar)
Sent: Monday, October 29, 2018 6:48 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [edk2-InfSpecification][PATCH v2] Amend the OptionROM specification to allow multiple PCI_DEVICE_IDs
The BaseTools have been updated to allow multiple PCI_DEVICE_IDs following the Device List introduced in the PCI Spec rev 3.0. This change documents the syntax.
Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
2_inf_overview/24_[defines]_section.md | 2 +-
3_edk_ii_inf_file_format/34_[defines]_section.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/2_inf_overview/24_[defines]_section.md b/2_inf_overview/24_[defines]_section.md
index 0afdfed..8e5706c 100644
--- a/2_inf_overview/24_[defines]_section.md
+++ b/2_inf_overview/24_[defines]_section.md
@@ -128,7 +128,7 @@ dispatch instance.
|`CONSTRUCTOR` |Not required - Library Only |CName | This only applies to components that are libraries. It is required for EDK II libraries if the module's INF contains a Constructor element. This value is used to call the specified function before calling into the library itself. |
|`DESTRUCTOR` |Not required - Library Only |CName | This only applies to components that are libraries. This value is used to call the specified function before calling into the library itself. |
|`SHADOW` |Not required - SEC, PEIM and PEI_CORE Driver modules only |TRUE | FALSE | This boolean operator is used by `SEC`, `PEI_CORE` and `PEIM` modules to indicate if the module was coded to use `REGISTER_FOR_SHADOW`. If the value is TRUE, the .reloc section of the PE32 image is not removed, otherwise, the .reloc section is stripped to conserve space in the final binary images. The default value is FALSE. |
-|`PCI_DEVICE_ID` |Not required - Required for UEFI PCI Option ROMs |UINT16 Value | The PCI Device Id for this device |
+|`PCI_DEVICE_ID` |Not required - Required for UEFI PCI Option ROMs |List of UINT16 Values | The list of PCI Device Ids for this device |
|`PCI_VENDOR_ID` |Not required - Required for UEFI PCI Option ROMs |UINT16 Value | The PCI Vendor Id for this device |
|`PCI_CLASS_CODE` |Not required - Required for UEFI PCI Option ROMs |UINT8 Value | The PCI Class Code for this device |
|`PCI_REVISION` |Not required - Required for UEFI PCI Option ROMs |UINT8 Value | The PCI revision for this device |
diff --git a/3_edk_ii_inf_file_format/34_[defines]_section.md b/3_edk_ii_inf_file_format/34_[defines]_section.md
index f512ff9..394db53 100644
--- a/3_edk_ii_inf_file_format/34_[defines]_section.md
+++ b/3_edk_ii_inf_file_format/34_[defines]_section.md
@@ -173,7 +173,7 @@ recommended.
<FFE> ::= <FS> <Expression>
<SpecVersion> ::= {<HexVersion>} {(0-9))+ "." (0-9)+}
<OptionRomInfo> ::= <TS> "PCI_VENDOR_ID" <Eq> <UINT16> <EOL>
- <TS> "PCI_DEVICE_ID" <Eq> <UNIT16> <EOL>
+ <TS> "PCI_DEVICE_ID" <Eq> <UNIT16> [<MTS>
+ <UINT16>]* <EOL>
<TS> "PCI_CLASS_CODE" <Eq> <UINT8> <EOL>
<TS> "PCI_REVISION" <Eq> <UINT8> <EOL>
[<TS> "PCI_COMPRESS" <Eq> <TruFal> <EOL>]
--
2.17.2
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-10-29 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 10:48 [edk2-InfSpecification][PATCH v2] Amend the OptionROM specification to allow multiple PCI_DEVICE_IDs Tomas Pilar (tpilar)
2018-10-29 12:05 ` Zhu, Yonghong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D521659FC@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox