From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E0DEE2117D292 for ; Mon, 29 Oct 2018 05:05:13 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2018 05:05:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,440,1534834800"; d="scan'208";a="101574786" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 29 Oct 2018 05:05:12 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 05:05:12 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 05:05:12 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Mon, 29 Oct 2018 20:05:10 +0800 From: "Zhu, Yonghong" To: "Tomas Pilar (tpilar)" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [edk2-InfSpecification][PATCH v2] Amend the OptionROM specification to allow multiple PCI_DEVICE_IDs Thread-Index: AQHUb3dPmHqYciBXMk2vvjtxZ/EUR6U2ICNA Date: Mon, 29 Oct 2018 12:05:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-InfSpecification][PATCH v2] Amend the OptionROM specification to allow multiple PCI_DEVICE_IDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 12:05:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Toma= s Pilar (tpilar) Sent: Monday, October 29, 2018 6:48 PM To: edk2-devel@lists.01.org Subject: [edk2] [edk2-InfSpecification][PATCH v2] Amend the OptionROM speci= fication to allow multiple PCI_DEVICE_IDs The BaseTools have been updated to allow multiple PCI_DEVICE_IDs following = the Device List introduced in the PCI Spec rev 3.0. This change documents t= he syntax. Signed-off-by: Tomas Pilar Contributed-under: TianoCore Contribution Agreement 1.1 --- 2_inf_overview/24_[defines]_section.md | 2 +- 3_edk_ii_inf_file_format/34_[defines]_section.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/2_inf_overview/24_[defines]_section.md b/2_inf_overview/24_[de= fines]_section.md index 0afdfed..8e5706c 100644 --- a/2_inf_overview/24_[defines]_section.md +++ b/2_inf_overview/24_[defines]_section.md @@ -128,7 +128,7 @@ dispatch instance. |`CONSTRUCTOR` |Not required - Library Only = |CName | This only applies to co= mponents that are libraries. It is required for EDK II libraries if the mod= ule's INF contains a Constructor element. This value is used to call the sp= ecified function before calling into the library itself. = = | |`DESTRUCTOR` |Not required - Library Only = |CName | This only applies to co= mponents that are libraries. This value is used to call the specified funct= ion before calling into the library itself. = = = | |`SHADOW` |Not required - SEC, PEIM and PEI_CORE Driver= modules only |TRUE | FALSE | This boolean operator i= s used by `SEC`, `PEI_CORE` and `PEIM` modules to indicate if the module wa= s coded to use `REGISTER_FOR_SHADOW`. If the value is TRUE, the .reloc sect= ion of the PE32 image is not removed, otherwise, the .reloc section is stri= pped to conserve space in the final binary images. The default value is FAL= SE. | -|`PCI_DEVICE_ID` |Not required - Required for UEFI PCI Option = ROMs |UINT16 Value | The PCI Device Id for t= his device = = = = | +|`PCI_DEVICE_ID` |Not required - Required for UEFI PCI Option = ROMs |List of UINT16 Values | The list of PCI Device = Ids for this device = = = = | |`PCI_VENDOR_ID` |Not required - Required for UEFI PCI Option = ROMs |UINT16 Value | The PCI Vendor Id for t= his device = = = = | |`PCI_CLASS_CODE` |Not required - Required for UEFI PCI Option = ROMs |UINT8 Value | The PCI Class Code for = this device = = = = | |`PCI_REVISION` |Not required - Required for UEFI PCI Option = ROMs |UINT8 Value | The PCI revision for th= is device = = = = | diff --git a/3_edk_ii_inf_file_format/34_[defines]_section.md b/3_edk_ii_in= f_file_format/34_[defines]_section.md index f512ff9..394db53 100644 --- a/3_edk_ii_inf_file_format/34_[defines]_section.md +++ b/3_edk_ii_inf_file_format/34_[defines]_section.md @@ -173,7 +173,7 @@ recommended. ::=3D ::=3D {} {(0-9))+ "." (0-9)+} ::=3D "PCI_VENDOR_ID" - "PCI_DEVICE_ID" + "PCI_DEVICE_ID" [=20 + ]* "PCI_CLASS_CODE" "PCI_REVISION" [ "PCI_COMPRESS" ] -- 2.17.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel