From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CCC312117D292 for ; Mon, 29 Oct 2018 05:05:29 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2018 05:05:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,440,1534834800"; d="scan'208";a="104170410" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 29 Oct 2018 05:05:28 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 05:05:28 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 29 Oct 2018 05:05:28 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Mon, 29 Oct 2018 20:05:26 +0800 From: "Zhu, Yonghong" To: "Tomas Pilar (tpilar)" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs Thread-Index: AQHUb3YcdHgIrR6jkEipyORTrpA6/aU2IGkQ Date: Mon, 29 Oct 2018 12:05:25 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-FdfSpecification][PATCH v2] Amend the OptionROM definition to allow multiple PCI_DEVICE_IDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 12:05:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Toma= s Pilar (tpilar) Sent: Monday, October 29, 2018 6:48 PM To: edk2-devel@lists.01.org Subject: [edk2] [edk2-FdfSpecification][PATCH v2] Amend the OptionROM defin= ition to allow multiple PCI_DEVICE_IDs The BaseTools are updated to allow multiple PCI_DEVICE_ID fields following = the Device List introduced in the PCI Spec rev 3.0. This commit documents t= he amended syntax. Signed-off-by: Tomas Pilar Contributed-under: TianoCore Contribution Agreement 1.1 --- 3_edk_ii_fdf_file_format/311_pci_optionrom_section.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md b/3_edk_= ii_fdf_file_format/311_pci_optionrom_section.md index 08f50e7..8267fbb 100644 --- a/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md +++ b/3_edk_ii_fdf_file_format/311_pci_optionrom_section.md @@ -58,7 +58,7 @@ Conditional statements may be used anywhere within this s= ection. ::=3D "{" [ "PCI_VENDOR_ID" ] [ "PCI_CLASS_CODE" ] - [ "PCI_DEVICE_ID" ] + [ "PCI_DEVICE_ID" [=20 + ]* ] [ "PCI_REVISION" ] [ "PCI_COMPRESS" ] "}" @@ -108,6 +108,7 @@ for the .efi extension in the ENBF above. [OptionRom.AtapiPassThru] INF USE =3D IA32 OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf { PCI_REVISION =3D 0x0020 + PCI_DEVICE_ID =3D 0x0A03 0x0B03 } INF USE =3D EBC OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf ``` -- 2.17.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel