From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yonghong.zhu@intel.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=134.134.136.100; helo=mga07.intel.com;
 envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org 
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id ADD23211CC3D9
 for <edk2-devel@lists.01.org>; Thu,  7 Mar 2019 00:36:32 -0800 (PST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 07 Mar 2019 00:36:32 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="280527099"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by orsmga004.jf.intel.com with ESMTP; 07 Mar 2019 00:36:32 -0800
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 7 Mar 2019 00:36:31 -0800
Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by
 fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 7 Mar 2019 00:36:31 -0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by
 SHSMSX154.ccr.corp.intel.com ([169.254.7.223]) with mapi id 14.03.0415.000;
 Thu, 7 Mar 2019 16:36:29 +0800
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
CC: "Gao, Liming" <liming.gao@intel.com>, "Zhu, Yonghong"
 <yonghong.zhu@intel.com>
Thread-Topic: [Patch V2 1/1] Document: Add PCD flexible format value EBNF in
 Fdf.
Thread-Index: AQHU1KiRNWkhF/T9Jk2NApZFti9aeaX/2E2Q
Date: Thu, 7 Mar 2019 08:36:29 +0000
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D521E81CB@SHSMSX103.ccr.corp.intel.com>
References: <20190307054154.29636-1-bob.c.feng@intel.com>
 <20190307054154.29636-2-bob.c.feng@intel.com>
In-Reply-To: <20190307054154.29636-2-bob.c.feng@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [Patch V2 1/1] Document: Add PCD flexible format value EBNF in Fdf.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2019 08:36:33 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>=20

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Feng, Bob C=20
Sent: Thursday, March 07, 2019 1:42 PM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>;=
 Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [Patch V2 1/1] Document: Add PCD flexible format value EBNF in Fdf=
.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D541

This patch is to add flexible PCD value format EBNF into Fdf spec.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
 3_edk_ii_fdf_file_format/32_fdf_definition.md     | 25 +++++++++++++++++++=
++----
 3_edk_ii_fdf_file_format/35_[fd]_sections.md      |  4 ++--
 3_edk_ii_fdf_file_format/36_[fv]_sections.md      |  4 ++--
 3_edk_ii_fdf_file_format/37_[capsule]_sections.md |  4 ++--
 README.md                                         |  1 +
 5 files changed, 28 insertions(+), 10 deletions(-)

diff --git a/3_edk_ii_fdf_file_format/32_fdf_definition.md b/3_edk_ii_fdf_f=
ile_format/32_fdf_definition.md
index db098cf..2b044ab 100644
--- a/3_edk_ii_fdf_file_format/32_fdf_definition.md
+++ b/3_edk_ii_fdf_file_format/32_fdf_definition.md
@@ -1,9 +1,9 @@
 <!--- @file
   3.2 FDF Definition
=20
-  Copyright (c) 2006-2018, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006-2019, Intel Corporation. All rights reserved.<BR>
=20
   Redistribution and use in source (original document form) and 'compiled'
   forms (converted to PDF, epub, HTML and other formats) with or without
   modification, are permitted provided that the following conditions are m=
et:
=20
@@ -122,15 +122,17 @@ The following are common definitions used by multiple=
 section types.
 <AsciiString>          ::=3D [ <TS>* <AsciiChars>* ]*
 <EmptyString>          ::=3D <DblQuote> <DblQuote>
 <CFlags>               ::=3D <AsciiString>
 <PrintChars>           ::=3D {<TS>} {<CChars>}
 <QuotedString>         ::=3D <DblQuote> <PrintChars>* <DblQuote>
-<CString>              ::=3D ["L"] <QuotedString>
+<CString>              ::=3D ["L"] {<QuotedString>} {<SglQuotedString>}
+<SglQuotedString>      ::=3D <SglQuote> <PrintChars>* <SglQuote>
+<SglQuote>             ::=3D 0x27
 <NormalizedString>     ::=3D <DblQuote> [{<Word>} {<Space>}]+ <DblQuote>
 <GlobalComment>        ::=3D <WS> "#" [<AsciiString>] <EOL>+
 <Comment>              ::=3D "#" <AsciiString> <EOL>+
-<UnicodeString>        ::=3D "L" <QuotedString>
+<UnicodeString>        ::=3D "L" {<QuotedString>} {<SglQuotedString>}
 <HexDigit>             ::=3D (a-fA-F0-9)
 <HexByte>              ::=3D {"0x"} {"0X"} [<HexDigit>] <HexDigit>
 <HexNumber>            ::=3D {"0x"} {"0X"} <HexDigit>+
 <HexVersion>           ::=3D "0x" [0]* <Major> <Minor>
 <Major>                ::=3D <HexDigit>? <HexDigit>? <HexDigit>?
@@ -181,11 +183,11 @@ The following are common definitions used by multiple=
 section types.
 <PcdCName>             ::=3D <CName>
 <TokenSpaceGuidCName>  ::=3D <CName>
 <Field>                ::=3D <CName>
 <PCDVAL>               ::=3D "PCD(" <PcdName> ")"
 <UINT8>                ::=3D {"0x"} {"0X"} (\x0 - \xFF)
-<UINT16>               ::=3D "0x"} {"0X"} (\x0 - \xFFFF)
+<UINT16>               ::=3D {"0x"} {"0X"} (\x0 - \xFFFF)
 <UINT32>               ::=3D {"0x"} {"0X"} (\x0 - \xFFFFFFFF)
 <UINT64>               ::=3D {"0x"} {"0X"} (\x0 - \xFFFFFFFFFFFFFFFF)
 <UINT8z>               ::=3D {"0x"} {"0X"} <HexDigit> <HexDigit>
 <UINT16z>              ::=3D {"0x"} {"0X"} <HexDigit> <HexDigit> <HexDigit=
>
                            <HexDigit>
@@ -233,10 +235,25 @@ The following are common definitions used by multiple=
 section types.
                            {"128M"} {"256M"} {"512M"} {"1G"} {"2G"}
 <FfsAlignmentValues>   ::=3D {"Auto"} {"8"} {"16"} {"32"} {"64"} {"128"}
                            {"512"} {"1K"} {"4K"} {"32K"} {"64K"} {"128K"}
                            {"256K"} {"512K"} {"1M"} {"2M"} {"4M"} {"8M"}
                            {"16M"}
+<Array>                ::=3D "{" {<Array>} {[<Lable>] <ArrayVal>[<CommaSpa=
ce> [<Lable>] <ArrayVal>]* } "}"
+<Lable>                ::=3D "LABEL(" <CName> ")"
+<OffsetOf>             ::=3D "OFFSET_OF(" <CName> ")"
+<ArrayVal>             ::=3D {<Num8Array>} {<GuidStr>} {<DevicePath>}    1
+<Num8Array>            ::=3D {<NonNumType>} {<ShortNum>} {<UINT8>}
+<NonNumType>           ::=3D {<BoolVal>} {<UnicodeString>} {<CString>}{<Of=
fset>} {<UintMac>}
+<ShortNum>             ::=3D (0-255)
+<UintMac>              ::=3D {<Uint8Mac>} {<Uint16Mac>} {<Uint32Mac>} {<Ui=
nt64Mac>}
+<Uint8Mac>             ::=3D "UINT8(" <Num8Array> ")"
+<Uint16Mac>            ::=3D "UINT16(" <Num16Array> ")"
+<Uint32Mac>            ::=3D "UINT32(" <Num32Array> ")"
+<Uint64Mac>            ::=3D "UINT64(" <Num64Array> ")"
+<Num16Array>           ::=3D {<NonNumType>} {<IntNum>} {<UINT16>}
+<Num32Array>           ::=3D {<NonNumType>} {<LongNum>} {<UINT32>}
+<Num64Array>           ::=3D {<NonNumType>} {<LongLongNum>} {<UINT64>}
 ```
=20
 **********
 **Note:** When using the characters "|" or "||" in an expression, the  exp=
ression must be encapsulated in open "(" and close ")" parenthesis.
diff --git a/3_edk_ii_fdf_file_format/35_[fd]_sections.md b/3_edk_ii_fdf_fi=
le_format/35_[fd]_sections.md
index e46fd7b..d8fde52 100644
--- a/3_edk_ii_fdf_file_format/35_[fd]_sections.md
+++ b/3_edk_ii_fdf_file_format/35_[fd]_sections.md
@@ -1,9 +1,9 @@
 <!--- @file
   3.5 [FD] Sections
=20
-  Copyright (c) 2006-2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006-2019, Intel Corporation. All rights reserved.<BR>
=20
   Redistribution and use in source (original document form) and 'compiled'
   forms (converted to PDF, epub, HTML and other formats) with or without
   modification, are permitted provided that the following conditions are m=
et:
=20
@@ -66,11 +66,11 @@ Conditional statements may be used anywhere within this=
 section.
 <BlockStatements>  ::=3D <TS> "BlockSize" <Eq> <UINT32> [<SetPcd>]
                        <EOL>
                        [<TS> "NumBlocks" <Eq> <UINT32> <EOL>]
 <SetStatements>    ::=3D <TS> "SET" {<PcdName>} {<PcdFieldName>} <Eq> <VAL=
UE> <EOL>
 <VALUE>            ::=3D {<Number>} {<Boolean>} {<GUID>} {<CArray>}
-                       {<CString>} {<UnicodeString>} {<Expression>}
+                       {<CString>} {<UnicodeString>}=20
+ {<Expression>}{<Array>}{<OffsetOf>}
 <RegionLayout>     ::=3D <TS> <Offset> <FS> <Size> <EOL>
                        [<TS> <PcdOffset> [<FS> <PcdSize>] <EOL>]
                        [<RegionType>]
 <Offset>           ::=3D {<HexNumber>} {<Expression>}
 <Size>             ::=3D {<HexNumber>} {<Expression>}
diff --git a/3_edk_ii_fdf_file_format/36_[fv]_sections.md b/3_edk_ii_fdf_fi=
le_format/36_[fv]_sections.md
index 2b21906..7448f3c 100644
--- a/3_edk_ii_fdf_file_format/36_[fv]_sections.md
+++ b/3_edk_ii_fdf_file_format/36_[fv]_sections.md
@@ -1,9 +1,9 @@
 <!--- @file
   3.6 [FV] Sections
=20
-  Copyright (c) 2006-2018, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006-2019, Intel Corporation. All rights reserved.<BR>
=20
   Redistribution and use in source (original document form) and 'compiled'
   forms (converted to PDF, epub, HTML and other formats) with or without
   modification, are permitted provided that the following conditions are m=
et:
=20
@@ -90,11 +90,11 @@ Conditional statements may be used anywhere within this=
 section.
 <BlockStatements>   ::=3D <FixedBlocks>
 <FixedBlocks>       ::=3D [<TS> "BlockSize" <Eq> <UINT32> <EOL>]
                         [<TS> "NumBlocks" <Eq> <UINT32> <EOL>]
 <SetStatements>     ::=3D <TS> "SET" <MTS> {<PcdName>} {<PcdFieldName>} <E=
q> <VALUE> <EOL>
 <VALUE>             ::=3D {<Number>} {<Boolean>} {<GUID>} {<CArray>}
-                        {<CString>} {<UnicodeString>} {<Expression>}
+                        {<CString>} {<UnicodeString>}=20
+ {<Expression>}{<Array>}{<OffsetOf>}
 <FvAlignment>       ::=3D [<TS> "FvBaseAddress" <Eq> <UINT64> <EOL>]
                         [<TS> "FvForceRebase" <Eq> <TrueFalse> <EOL>]
                         <TS> "FvAlignment" <Eq>
                         <FvAlignmentValues> <EOL>
 <FvAttributes>      ::=3D [<TS> "MEMORY_MAPPED" <Eq> <TrueFalse> <EOL>]
diff --git a/3_edk_ii_fdf_file_format/37_[capsule]_sections.md b/3_edk_ii_f=
df_file_format/37_[capsule]_sections.md
index c20c73a..7dc975d 100644
--- a/3_edk_ii_fdf_file_format/37_[capsule]_sections.md
+++ b/3_edk_ii_fdf_file_format/37_[capsule]_sections.md
@@ -1,9 +1,9 @@
 <!--- @file
   3.7 [Capsule] Sections
=20
-  Copyright (c) 2006-2018, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006-2019, Intel Corporation. All rights reserved.<BR>
=20
   Redistribution and use in source (original document form) and 'compiled'
   forms (converted to PDF, epub, HTML and other formats) with or without
   modification, are permitted provided that the following conditions are m=
et:
=20
@@ -49,11 +49,11 @@ Conditional statements may be used anywhere within this=
 section.
                         <UefiTokens>
                         <CapsuleStmts>*
 <UiCapsuleName>     ::=3D "." <Word>
 <SetStatements>     ::=3D <TS> "SET" <MTS> {<PcdName>} {<PcdFieldName>} <E=
q> <VALUE> <EOL>
 <VALUE>             ::=3D {<Number>} {<Boolean>} {<GUID>} {<CArray>}
-                        {<CString>} {<UnicodeString>} {<Expression>}
+                        {<CString>} {<UnicodeString>}=20
+ {<Expression>}{<Array>}{<OffsetOf>}
 <UefiTokens>        ::=3D <TS> "CAPSULE_GUID" <Eq> <NamedGuidOrPcd> <EOL>
                         [<TS> "CAPSULE_HEADER_SIZE" <Eq> <Bytes> <EOL>] [<=
TS>
                         "CAPSULE_FLAGS" <Eq> <Flags> <EOL>]
                         [<TS> "CAPSULE_HEADER_INIT_VERSION" <Eq> <Hex2> <E=
OL>]
 <CapsuleStmts>      ::=3D {<MacroDefinition>} {<SetStatements>}
diff --git a/README.md b/README.md
index 7c7face..379ef42 100644
--- a/README.md
+++ b/README.md
@@ -215,5 +215,6 @@ Copyright (c) 2006-2017, Intel Corporation. All rights =
reserved.
 |            | clean up the <NamedGuidOrPcd> and <NamedGuid> usage in spec=
                                                                           =
                                     |               |
 |            | document WEAK_ALIGNMENT attribute                          =
                                                                           =
                                     |               |
 |            | support varstore template generation with a [FV] section   =
                                                                           =
                                     |               |
 |            | [#1110](https://bugzilla.tianocore.org/show_bug.cgi?id=3D11=
10) Extend exclamation statement's keyword to case-insensitive             =
                                       |               |
 |            | [#551] (https://bugzilla.tianocore.org/show_bug.cgi?id=3D55=
1) Add PI1.5 standalone SMM support in FDF file                            =
                                       |               |
+|            | Add flexible PCD value format into spec                    =
                                                                           =
                                     |               |
\ No newline at end of file
--
2.20.1.windows.1