public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 6/6] SignedCapsulePkg: enable package build for AARCH64/ARM
Date: Fri, 2 Nov 2018 00:00:11 +0000	[thread overview]
Message-ID: <B9EC57EE-5EC5-4F98-88AA-D95B39546541@intel.com> (raw)
In-Reply-To: <20181101153642.11315-7-leif.lindholm@linaro.org>

Reviewed-by: jiewen.yao@intel.com

thank you!
Yao, Jiewen


> 在 2018年11月1日,下午11:37,Leif Lindholm <leif.lindholm@linaro.org> 写道:
> 
> This package is used by several platforms in edk2-platforms, so ensure it
> can be built directly by adding AARCH64/ARM to SUPPORTED_ARCHITECTURES.
> 
> Also force-include CompilerIntrinsicsLib, BaseStackCheckLib and create a
> resolution for ArmSoftFloatLib for ARM.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> SignedCapsulePkg/SignedCapsulePkg.dsc | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc
> index db7f176166..3d9c4afb91 100644
> --- a/SignedCapsulePkg/SignedCapsulePkg.dsc
> +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc
> @@ -19,7 +19,7 @@ [Defines]
>   PLATFORM_VERSION               = 0.96
>   DSC_SPECIFICATION              = 0x00010005
>   OUTPUT_DIRECTORY               = Build/SignedCapsulePkg
> -  SUPPORTED_ARCHITECTURES        = IA32|X64
> +  SUPPORTED_ARCHITECTURES        = AARCH64|ARM|IA32|X64
>   BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>   SKUID_IDENTIFIER               = DEFAULT
> 
> @@ -105,6 +105,19 @@ [LibraryClasses]
>   IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf
>   PlatformFlashAccessLib|SignedCapsulePkg/Library/PlatformFlashAccessLibNull/PlatformFlashAccessLibNull.inf
> 
> +[LibraryClasses.ARM]
> +  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +
> +  #
> +  # It is not possible to prevent the ARM compiler for generic intrinsic functions.
> +  # This library provides the instrinsic functions generate by a given compiler.
> +  # And NULL mean link this library into all ARM images.
> +  #
> +  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> +
> +  # Add support for GCC stack protector
> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
> [LibraryClasses.common.PEI_CORE]
>   HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
>   MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> -- 
> 2.11.0
> 

  reply	other threads:[~2018-11-02  0:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 15:36 [PATCH 0/6] fix top-level package builds for AARCH64/ARM Leif Lindholm
2018-11-01 15:36 ` [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64 Leif Lindholm
2018-11-01 17:19   ` Kinney, Michael D
2018-11-01 17:56     ` Leif Lindholm
2018-11-01 15:36 ` [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM Leif Lindholm
2018-11-02  1:39   ` Gao, Liming
2018-11-02 10:15     ` Leif Lindholm
2018-11-02 14:20       ` Gao, Liming
2018-11-01 15:36 ` [PATCH 3/6] IntelFrameworkPkg: " Leif Lindholm
2018-11-01 17:23   ` Kinney, Michael D
2018-11-01 15:36 ` [PATCH 4/6] MdeModulePkg: drop DebugSupportDxe from AARCH64 components Leif Lindholm
2018-11-02  1:24   ` Zeng, Star
2018-11-01 15:36 ` [PATCH 5/6] SecurityPkg: fix package build on ARM Leif Lindholm
2018-11-02  0:00   ` Yao, Jiewen
2018-11-01 15:36 ` [PATCH 6/6] SignedCapsulePkg: enable package build for AARCH64/ARM Leif Lindholm
2018-11-02  0:00   ` Yao, Jiewen [this message]
2019-02-04 17:13 ` [PATCH 0/6] fix top-level package builds " Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9EC57EE-5EC5-4F98-88AA-D95B39546541@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox