From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ml01.01.org (Postfix) with ESMTP id C08321A1DFB for ; Thu, 4 Aug 2016 20:24:59 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 04 Aug 2016 20:25:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,472,1464678000"; d="scan'208";a="1030092366" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 04 Aug 2016 20:24:57 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 4 Aug 2016 20:24:56 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 4 Aug 2016 20:24:55 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.116]) with mapi id 14.03.0248.002; Fri, 5 Aug 2016 11:24:54 +0800 From: "Ye, Ting" To: Larry Cleeton , "edk2-devel@lists.01.org" Thread-Topic: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] Thread-Index: AdHs//Fgg3Y+nYxXTkizzBcV2CsIsgBxp7tg Date: Fri, 5 Aug 2016 03:24:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 03:24:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Larry, We are very sorry about the impact you suffered today. We made the change i= n early 2013 to support the existing NVRAM variable when firmware image was= updated from IA32 to X64. Unfortunately we introduced an incompatibility i= ssue as you raised. Now we prefer to keep the existing definition, since if= we change it back that would introduce another similar incompatibility iss= ue. What do you think about this? Best Regards, Ye Ting -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Larr= y Cleeton Sent: Wednesday, August 03, 2016 4:55 AM To: edk2-devel@lists.01.org Subject: [edk2] Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.= [c, h] This commit (fdc4b0b147b386e966e99893526181dfae9eaeef) changed a data struc= ture that is stored in an NVRAM variable.=20 See NetworkPkg/Ip6Dxe/Ip6ConfigImpl.[c,h] This data structure: typedef struct { UINT16 Offset; UINTN DataSize; EFI_IP6_CONFIG_DATA_TYPE DataType; } IP6_CONFIG_DATA_RECORD; Is now: typedef struct { UINT16 Offset; UINT32 DataSize; <---------------- changed size in= 64bit environments EFI_IP6_CONFIG_DATA_TYPE DataType; } IP6_CONFIG_DATA_RECORD; Unfortunately with a 64bit implementation this current structure is now *no= t* compatible with an existing NVRAM variable written with the previous ver= sion of the structure. It's causing me considerable grief so I'm just shari= ng the discovery. It would only impact you if you update some 64bit machin= e's firmware with a new version containing this change. --Larry _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel