public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ye, Ting" <ting.ye@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>,
	Santhapur Naveen <naveens@amiindia.co.in>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Sivaraman Nainar <sivaramann@amiindia.co.in>,
	"Madhan B. Santharam" <madhans@ami.com>
Subject: Re: Classless IP support for IPv4 PXE boot
Date: Thu, 18 Aug 2016 02:53:20 +0000	[thread overview]
Message-ID: <BC0C045B0E2A584CA4575E779FA2C12A17D9C2E6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <B1FF2E9001CE9041BD10B825821D5BC55495D463@shsmsx102.ccr.corp.intel.com>

I searched the log messages:

Revision: 21543
Author: edk2buildsystem
Date: Friday, July 01, 2016 5:05:51 AM
Message:
MdeModulePkg VariableInfo: Fix GCC build failure

GCC build failure: 'RealCommSize' may be used uninitialized

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
(cherry picked from commit 05b39efb669eaa173a76e58daf8e65bce2e0299e)
----
Modified : /trunk/edk2/MdeModulePkg/Application/VariableInfo/VariableInfo.c


This looks irrelevant. Could you please confirm the revision?

Thanks,
Ting

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu, Siyuan
Sent: Thursday, August 18, 2016 10:48 AM
To: Santhapur Naveen <naveens@amiindia.co.in>; edk2-devel@lists.01.org
Cc: Sivaraman Nainar <sivaramann@amiindia.co.in>; Madhan B. Santharam <madhans@ami.com>
Subject: Re: [edk2] Classless IP support for IPv4 PXE boot

Hi, Naveen

May I know the GIT version of the 21543, or the subject of the commit message? I can't see the svn revision number on my side.

Thanks
Siyuan

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Wednesday, August 17, 2016 7:41 PM
> To: edk2-devel@lists.01.org
> Cc: Sivaraman Nainar <sivaramann@amiindia.co.in>; Madhan B. Santharam 
> <madhans@ami.com>
> Subject: [edk2] Classless IP support for IPv4 PXE boot
> 
> Hello,
> 
>           We happened to observe that the IPv4 PXE boot was happening 
> successfully for both classless and classful IPs until the EDKII 
> revision 21542. It has been found that there are some changes made in 
> the revision
> 21543 and the IPv4 PXE boot is failing for classless IP addresses. The 
> failure scenario was debugged and is explained here. Let's assume the 
> subnet range is 192.168.1.0/16. The DHCP server tries to allot an IP 
> (let's say 192.168.1.0) but based on the first byte of the IP address 
> to be assigned, the function NetGetIpClass() returns the IP class as 
> Class-C and its respective subnet mask as 255.255.255.0 that should be 
> for a classful IP address whereas 255.255.0.0 is the actual subnet in 
> this scenario. The changes present in function 
> Dhcp4InstanceConfigUdpIo() seems to be responsible for the failure.
> 
> May we know the reason behind the changes present in the Dhcp4Impl.c 
> of the revision 21543? Is there any plan to bring the classless IP 
> support in NetworkPkg?
> 
> 
> Thanks,
> Naveen
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-08-18  2:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17 11:41 Classless IP support for IPv4 PXE boot Santhapur Naveen
2016-08-18  2:48 ` Fu, Siyuan
2016-08-18  2:53   ` Ye, Ting [this message]
2016-08-18  3:15     ` Santhapur Naveen
2016-08-18  3:20       ` Fu, Siyuan
2016-08-18  3:27         ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BC0C045B0E2A584CA4575E779FA2C12A17D9C2E6@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox