[Patch] NetworkPkg: Remove redundant code in HTTP boot driver.

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.
@ 2016-09-13  2:26 Fu Siyuan
  2016-09-13  8:05 ` Wu, Jiaxin
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fu Siyuan @ 2016-09-13  2:26 UTC (permalink / raw)
  To: edk2-devel; +Cc: Wu Jiaxin, Zhang Lubo

Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
 NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
index 809accc..8478642 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
@@ -418,9 +418,6 @@ HttpBootDhcp6CallBack (
    HTTP_BOOT_PRIVATE_DATA          *Private;
    EFI_DHCP6_PACKET                *SelectAd;
    EFI_STATUS                      Status;
-   if ((Dhcp6Event != Dhcp6RcvdAdvertise) && (Dhcp6Event != Dhcp6SelectAdvertise)) {
-     return EFI_SUCCESS;
-   }
 
    ASSERT (Packet != NULL);
    
-- 
2.7.4.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.
  2016-09-13  2:26 [Patch] NetworkPkg: Remove redundant code in HTTP boot driver Fu Siyuan
@ 2016-09-13  8:05 ` Wu, Jiaxin
  2016-09-13  8:23 ` Ye, Ting
  2016-09-13 14:07 ` Subramanian, Sriram (EG Servers Platform SW)
  2 siblings, 0 replies; 4+ messages in thread
From: Wu, Jiaxin @ 2016-09-13  8:05 UTC (permalink / raw)
  To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Zhang, Lubo

Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com>

Best Regards!
Jiaxin

> -----Original Message-----
> From: Fu, Siyuan
> Sent: Tuesday, September 13, 2016 10:26 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>
> Subject: [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.
> 
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Zhang Lubo <lubo.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> ---
>  NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> index 809accc..8478642 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> @@ -418,9 +418,6 @@ HttpBootDhcp6CallBack (
>     HTTP_BOOT_PRIVATE_DATA          *Private;
>     EFI_DHCP6_PACKET                *SelectAd;
>     EFI_STATUS                      Status;
> -   if ((Dhcp6Event != Dhcp6RcvdAdvertise) && (Dhcp6Event !=
> Dhcp6SelectAdvertise)) {
> -     return EFI_SUCCESS;
> -   }
> 
>     ASSERT (Packet != NULL);
> 
> --
> 2.7.4.windows.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.
  2016-09-13  2:26 [Patch] NetworkPkg: Remove redundant code in HTTP boot driver Fu Siyuan
  2016-09-13  8:05 ` Wu, Jiaxin
@ 2016-09-13  8:23 ` Ye, Ting
  2016-09-13 14:07 ` Subramanian, Sriram (EG Servers Platform SW)
  2 siblings, 0 replies; 4+ messages in thread
From: Ye, Ting @ 2016-09-13  8:23 UTC (permalink / raw)
  To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Zhang, Lubo, Wu, Jiaxin

Reviewed-by: Ye Ting <ting.ye@intel.com> 

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu Siyuan
Sent: Tuesday, September 13, 2016 10:26 AM
To: edk2-devel@lists.01.org
Cc: Zhang, Lubo <lubo.zhang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [edk2] [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.

Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
 NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
index 809accc..8478642 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
@@ -418,9 +418,6 @@ HttpBootDhcp6CallBack (
    HTTP_BOOT_PRIVATE_DATA          *Private;
    EFI_DHCP6_PACKET                *SelectAd;
    EFI_STATUS                      Status;
-   if ((Dhcp6Event != Dhcp6RcvdAdvertise) && (Dhcp6Event != Dhcp6SelectAdvertise)) {
-     return EFI_SUCCESS;
-   }
 
    ASSERT (Packet != NULL);
    
-- 
2.7.4.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.
  2016-09-13  2:26 [Patch] NetworkPkg: Remove redundant code in HTTP boot driver Fu Siyuan
  2016-09-13  8:05 ` Wu, Jiaxin
  2016-09-13  8:23 ` Ye, Ting
@ 2016-09-13 14:07 ` Subramanian, Sriram (EG Servers Platform SW)
  2 siblings, 0 replies; 4+ messages in thread
From: Subramanian, Sriram (EG Servers Platform SW) @ 2016-09-13 14:07 UTC (permalink / raw)
  To: Fu Siyuan, edk2-devel@lists.01.org; +Cc: Zhang Lubo, Wu Jiaxin

Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu Siyuan
Sent: Tuesday, September 13, 2016 7:56 AM
To: edk2-devel@lists.01.org
Cc: Zhang Lubo <lubo.zhang@intel.com>; Wu Jiaxin <jiaxin.wu@intel.com>
Subject: [edk2] [Patch] NetworkPkg: Remove redundant code in HTTP boot driver.

Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
 NetworkPkg/HttpBootDxe/HttpBootDhcp6.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
index 809accc..8478642 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
@@ -418,9 +418,6 @@ HttpBootDhcp6CallBack (
    HTTP_BOOT_PRIVATE_DATA          *Private;
    EFI_DHCP6_PACKET                *SelectAd;
    EFI_STATUS                      Status;
-   if ((Dhcp6Event != Dhcp6RcvdAdvertise) && (Dhcp6Event != Dhcp6SelectAdvertise)) {
-     return EFI_SUCCESS;
-   }
 
    ASSERT (Packet != NULL);
    
-- 
2.7.4.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-13 14:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-13  2:26 [Patch] NetworkPkg: Remove redundant code in HTTP boot driver Fu Siyuan
2016-09-13  8:05 ` Wu, Jiaxin
2016-09-13  8:23 ` Ye, Ting
2016-09-13 14:07 ` Subramanian, Sriram (EG Servers Platform SW)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox