From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3E4E181F1D for ; Tue, 6 Dec 2016 23:48:56 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 06 Dec 2016 23:48:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="39896748" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 06 Dec 2016 23:48:55 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 6 Dec 2016 23:48:55 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 6 Dec 2016 23:48:55 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.96]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 15:48:51 +0800 From: "Ye, Ting" To: Gary Lin , "edk2-devel@lists.01.org" CC: "Zhang, Lubo" , "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus Thread-Index: AQHSUDvOn5aZdEERV0yPhCAB3XHp8qD8HC0A Date: Wed, 7 Dec 2016 07:48:51 +0000 Message-ID: References: <20161207034051.12723-1-glin@suse.com> In-Reply-To: <20161207034051.12723-1-glin@suse.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 07:48:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ye Ting =20 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gary= Lin Sent: Wednesday, December 7, 2016 11:41 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Zhang, Lubo ; Fu, S= iyuan ; Wu, Jiaxin Subject: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus Since the type of ShellStatus is SHELL_STATUS, we should use SHELL_INVALID_= PARAMETER instead of EFI_INVALID_PARAMETER. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin Cc: Zhang Lubo Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin --- ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/Sh= ellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c index fb308cc3b6..d71688ed66 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo ( =20 if (StrCmp (VarArg->Arg, L"host") =3D=3D 0) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INV= ALID_IP_CONFIG), gShellNetwork2HiiHandle, Status); - ShellStatus =3D EFI_INVALID_PARAMETER; + ShellStatus =3D SHELL_INVALID_PARAMETER; goto ON_EXIT; } else if (StrCmp (VarArg->Arg, L"gw") =3D=3D 0) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INV= ALID_GW_CONFIG), gShellNetwork2HiiHandle, Status); - ShellStatus =3D EFI_INVALID_PARAMETER; + ShellStatus =3D SHELL_INVALID_PARAMETER; goto ON_EXIT; } else if (StrCmp (VarArg->Arg, L"dns") =3D=3D 0) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INV= ALID_DNS_CONFIG), gShellNetwork2HiiHandle, Status); - ShellStatus =3D EFI_INVALID_PARAMETER; + ShellStatus =3D SHELL_INVALID_PARAMETER; goto ON_EXIT; } =20 -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel