From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1075881EAC for ; Wed, 14 Dec 2016 23:32:53 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 14 Dec 2016 23:32:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,350,1477983600"; d="scan'208";a="1082082405" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2016 23:32:50 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Dec 2016 23:32:50 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Dec 2016 23:32:50 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.77]) with mapi id 14.03.0248.002; Thu, 15 Dec 2016 15:32:46 +0800 From: "Ye, Ting" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH 6/6] NetworkPkg: Refine UintnToAscDecWithFormat functions logic Thread-Index: AQHSVf0HtT9MFXZxXEmw5xllaC/xb6EIntDA Date: Thu, 15 Dec 2016 07:32:46 +0000 Message-ID: References: <1481714811-12568-1-git-send-email-hao.a.wu@intel.com> <1481714811-12568-7-git-send-email-hao.a.wu@intel.com> In-Reply-To: <1481714811-12568-7-git-send-email-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 6/6] NetworkPkg: Refine UintnToAscDecWithFormat functions logic X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 07:32:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ye Ting =20 -----Original Message----- From: Wu, Hao A=20 Sent: Wednesday, December 14, 2016 7:27 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Fu, Siyuan ; Ye, T= ing ; Wu, Jiaxin Subject: [PATCH 6/6] NetworkPkg: Refine UintnToAscDecWithFormat functions l= ogic This commit refines the logic for HttpBootUintnToAscDecWithFormat and PxeBc= UintnToAscDecWithFormat. It avoids using the decrement operator '--' for array index to prevent possible mis-reports by static code checkers. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- NetworkPkg/HttpBootDxe/HttpBootSupport.c | 5 ++--- NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/NetworkPkg/HttpBootDxe/HttpBootSupport.c b/NetworkPkg/HttpBoot= Dxe/HttpBootSupport.c index 9410bf9..bdb29ae 100644 --- a/NetworkPkg/HttpBootDxe/HttpBootSupport.c +++ b/NetworkPkg/HttpBootDxe/HttpBootSupport.c @@ -86,11 +86,10 @@ HttpBootUintnToAscDecWithFormat ( { UINTN Remainder; =20 - while (Length > 0) { - Length--; + for (; Length > 0; Length--) { Remainder =3D Number % 10; Number /=3D 10; - Buffer[Length] =3D (UINT8) ('0' + Remainder); + Buffer[Length - 1] =3D (UINT8) ('0' + Remainder); } } =20 diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c b/NetworkPkg/UefiPxeBcD= xe/PxeBcSupport.c index 00c652d..568360d 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c @@ -1383,11 +1383,10 @@ PxeBcUintnToAscDecWithFormat ( { UINTN Remainder; =20 - while (Length > 0) { - Length--; + for (; Length > 0; Length--) { Remainder =3D Number % 10; Number /=3D 10; - Buffer[Length] =3D (UINT8) ('0' + Remainder); + Buffer[Length - 1] =3D (UINT8) ('0' + Remainder); } } =20 -- 1.9.5.msysgit.0