public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ye, Ting" <ting.ye@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Long, Qin" <qin.long@intel.com>,
	"Fu, Siyuan" <siyuan.fu@intel.com>
Subject: Re: [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default
Date: Mon, 26 Dec 2016 02:35:12 +0000	[thread overview]
Message-ID: <BC0C045B0E2A584CA4575E779FA2C12A1A8A205E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1482482484-344648-1-git-send-email-jiaxin.wu@intel.com>

Reviewed-by: Ye Ting <ting.ye@intel.com> 

-----Original Message-----
From: Wu, Jiaxin 
Sent: Friday, December 23, 2016 4:41 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default

TLS feature highly depends on the OpenSSL building. To avoid the default Nt32 platform build failure, we should change the default value of TLS_ENABLE to FALSE.

The notes are also provided for Secure Boot and TLS features.

Cc: Ni Ruiyu <ruiyu.ni@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Long Qin <qin.long@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 Nt32Pkg/Nt32Pkg.dsc | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index 0a59e46..134afb8 100644
--- a/Nt32Pkg/Nt32Pkg.dsc
+++ b/Nt32Pkg/Nt32Pkg.dsc
@@ -42,18 +42,26 @@
 
   #
   # Defines for default states.  These can be changed on the command line.
   # -D FLAG=VALUE
   #
+  # Note: Secure Boot feature highly depends on the OpenSSL building. To enable this 
+  #       feature, please follow the instructions found in the file "Patch-HOWTO.txt" 
+  #       located in CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.
+  #
   DEFINE SECURE_BOOT_ENABLE      = FALSE
   
   #
   # This flag is to enable or disable TLS feature.  
   # These can be changed on the command line.
   # -D FLAG=VALUE
   #
-  DEFINE TLS_ENABLE      = TRUE
+  # Note: TLS feature highly depends on the OpenSSL building. To enable this 
+  #       feature, please follow the instructions found in the file "Patch-HOWTO.txt" 
+  #       located in CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.
+  #
+  DEFINE TLS_ENABLE      = FALSE
 
 ################################################################################
 #
 # SKU Identification section - list of all SKU IDs supported by this
 #                              Platform.
--
1.9.5.msysgit.1



      reply	other threads:[~2016-12-26  2:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23  8:41 [Patch] Nt32Pkg/Nt32Pkg.dsc: Change TLS_ENABLE flag to FALSE by default Jiaxin Wu
2016-12-26  2:35 ` Ye, Ting [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BC0C045B0E2A584CA4575E779FA2C12A1A8A205E@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox